From patchwork Mon Mar 30 16:50:09 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Chiang X-Patchwork-Id: 15159 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n2UGsDGe018391 for ; Mon, 30 Mar 2009 16:54:14 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756576AbZC3QuN (ORCPT ); Mon, 30 Mar 2009 12:50:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756344AbZC3QuN (ORCPT ); Mon, 30 Mar 2009 12:50:13 -0400 Received: from g1t0027.austin.hp.com ([15.216.28.34]:10240 "EHLO g1t0027.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756576AbZC3QuK (ORCPT ); Mon, 30 Mar 2009 12:50:10 -0400 Received: from smtp1.fc.hp.com (smtp.fc.hp.com [15.15.136.127]) by g1t0027.austin.hp.com (Postfix) with ESMTP id 49AE538446; Mon, 30 Mar 2009 16:50:09 +0000 (UTC) Received: from localhost.localdomain (lart.fc.hp.com [15.11.146.31]) by smtp1.fc.hp.com (Postfix) with ESMTP id A76042435B2; Mon, 30 Mar 2009 16:20:44 +0000 (UTC) Received: from bob.kio (localhost [127.0.0.1]) by localhost.localdomain (Postfix) with ESMTP id 1FE6D26143; Mon, 30 Mar 2009 10:50:09 -0600 (MDT) Subject: [PATCH v2 1/3] PCI: allow PCI core hotplug to remove PCI root bus To: jbarnes@virtuousgeek.org From: Alex Chiang Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 30 Mar 2009 10:50:09 -0600 Message-ID: <20090330165009.18855.43672.stgit@bob.kio> In-Reply-To: <20090330164737.18855.7137.stgit@bob.kio> References: <20090330164737.18855.7137.stgit@bob.kio> User-Agent: StGit/0.14.3.347.g594a MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org There is no reason to prevent removal of root bus devices. A subsequent rescan will find them just fine. Signed-off-by: Alex Chiang Reviewed-by: Kenji Kaneshige --- drivers/pci/pci-sysfs.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c index e9a8706..7b2cb27 100644 --- a/drivers/pci/pci-sysfs.c +++ b/drivers/pci/pci-sysfs.c @@ -277,14 +277,10 @@ remove_store(struct device *dev, struct device_attribute *dummy, { int ret = 0; unsigned long val; - struct pci_dev *pdev = to_pci_dev(dev); if (strict_strtoul(buf, 0, &val) < 0) return -EINVAL; - if (pci_is_root_bus(pdev->bus)) - return -EBUSY; - /* An attribute cannot be unregistered by one of its own methods, * so we have to use this roundabout approach. */