From patchwork Tue May 19 01:02:38 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Chiang X-Patchwork-Id: 24651 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n4J151K8005890 for ; Tue, 19 May 2009 01:05:02 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756598AbZESBCj (ORCPT ); Mon, 18 May 2009 21:02:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756494AbZESBCj (ORCPT ); Mon, 18 May 2009 21:02:39 -0400 Received: from g4t0015.houston.hp.com ([15.201.24.18]:38255 "EHLO g4t0015.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756581AbZESBCh (ORCPT ); Mon, 18 May 2009 21:02:37 -0400 Received: from smtp1.fc.hp.com (smtp.cnd.hp.com [15.15.136.127]) by g4t0015.houston.hp.com (Postfix) with ESMTP id CD08A81E1; Tue, 19 May 2009 01:02:38 +0000 (UTC) Received: from localhost.localdomain (lart.fc.hp.com [15.11.146.31]) by smtp1.fc.hp.com (Postfix) with ESMTP id 739D5254760; Tue, 19 May 2009 00:29:22 +0000 (UTC) Received: from bob.kio (localhost [127.0.0.1]) by localhost.localdomain (Postfix) with ESMTP id 648FD26168; Mon, 18 May 2009 19:02:38 -0600 (MDT) Subject: [PATCH] PCI: eliminate redundant pci_stop_dev() call from pci_destroy_dev() To: jbarnes@virtuousgeek.org From: Alex Chiang Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 18 May 2009 19:02:38 -0600 Message-ID: <20090519010222.12679.74898.stgit@bob.kio> User-Agent: StGit/0.14.3.347.g594a MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org We always call pci_stop_bus_device before calling pci_destroy_dev. Since pci_stop_bus_device calls pci_stop_dev, there is no need for pci_destroy_dev to repeat the call. Signed-off-by: Alex Chiang --- drivers/pci/remove.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pci/remove.c b/drivers/pci/remove.c index 86503c1..176615e 100644 --- a/drivers/pci/remove.c +++ b/drivers/pci/remove.c @@ -32,8 +32,6 @@ static void pci_stop_dev(struct pci_dev *dev) static void pci_destroy_dev(struct pci_dev *dev) { - pci_stop_dev(dev); - /* Remove the device from the device lists, and prevent any further * list accesses from this device */ down_write(&pci_bus_sem);