diff mbox

[Regression] PCI resources allocation problem on HP nx6325

Message ID 20090802165926.GB3711@parisc-linux.org (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Matthew Wilcox Aug. 2, 2009, 4:59 p.m. UTC
On Sun, Aug 02, 2009 at 04:19:47PM +0200, Rafael J. Wysocki wrote:
> Hi Matthew,
> 
> As reported at
> 
> http://bugzilla.kernel.org/show_bug.cgi?id=13891
> 
> there is a problem with allocating PCI resources on HP nx6325 introduced by
> your commit a76117dfd687ec4be0a9a05214f3009cc5f73a42
> (x86: Use pci_claim_resource).
> 
> On this particular box it causes the audio adapter's PCI memory space to
> be allocated for something else.

Could you also attach lspci -v?  It seems that the 0000:00:12.0 resource
is nesting inside the 0000:00:14.2 resource, which is just not possible.

Also, could you boot -rc5 (without
a76117dfd687ec4be0a9a05214f3009cc5f73a42 reverted) with this patch
applied?  It may give us some idea of what's going wrong.

Comments

Rafael Wysocki Aug. 2, 2009, 8:18 p.m. UTC | #1
On Sunday 02 August 2009, Matthew Wilcox wrote:
> On Sun, Aug 02, 2009 at 04:19:47PM +0200, Rafael J. Wysocki wrote:
> > Hi Matthew,
> > 
> > As reported at
> > 
> > http://bugzilla.kernel.org/show_bug.cgi?id=13891
> > 
> > there is a problem with allocating PCI resources on HP nx6325 introduced by
> > your commit a76117dfd687ec4be0a9a05214f3009cc5f73a42
> > (x86: Use pci_claim_resource).
> > 
> > On this particular box it causes the audio adapter's PCI memory space to
> > be allocated for something else.
> 
> Could you also attach lspci -v?  It seems that the 0000:00:12.0 resource
> is nesting inside the 0000:00:14.2 resource, which is just not possible.

It only looks like that in the failing case, though.

> Also, could you boot -rc5 (without
> a76117dfd687ec4be0a9a05214f3009cc5f73a42 reverted) with this patch
> applied?  It may give us some idea of what's going wrong.

I tested the Linus' patch replacing insert_resource() with request_resource()
and it worked, so do you still want me to provide this information?

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/pci/setup-res.c b/drivers/pci/setup-res.c
index ec80b88..3f422db 100644
--- a/drivers/pci/setup-res.c
+++ b/drivers/pci/setup-res.c
@@ -105,6 +105,10 @@  int pci_claim_resource(struct pci_dev *dev, int resource)
 
 	root = pci_find_parent_resource(dev, res);
 
+if (root)
+ printk("Inserting resource %s %pR (BAR %d) inside resource %s %pR\n", res->name, res, resource, root->name, root);
+else
+ printk("No parent found for resource %s %pR\n", res->name, res);
 	err = -EINVAL;
 	if (root != NULL)
 		err = insert_resource(root, res);