From patchwork Mon May 17 18:02:00 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prarit Bhargava X-Patchwork-Id: 100170 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o4HI24vS000712 for ; Mon, 17 May 2010 18:02:04 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754390Ab0EQSCD (ORCPT ); Mon, 17 May 2010 14:02:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28996 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753952Ab0EQSCD (ORCPT ); Mon, 17 May 2010 14:02:03 -0400 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4HI21Qd028388 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 17 May 2010 14:02:01 -0400 Received: from prarit.bos.redhat.com (prarit.bos.redhat.com [10.16.16.23]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o4HI203k011594; Mon, 17 May 2010 14:02:00 -0400 Date: Mon, 17 May 2010 14:02:00 -0400 From: Prarit Bhargava To: linux-pci@vger.kernel.org, jbarnes@virtuousgeek.org Cc: Prarit Bhargava Message-Id: <20100517175830.17298.84619.sendpatchset@prarit.bos.redhat.com> Subject: [PATCH]: Output FW warning in pci_read/write_vpd X-Scanned-By: MIMEDefang 2.67 on 10.5.11.16 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Mon, 17 May 2010 18:02:04 +0000 (UTC) diff --git a/drivers/pci/access.c b/drivers/pci/access.c index 2f646fe..5ea8aaf 100644 --- a/drivers/pci/access.c +++ b/drivers/pci/access.c @@ -220,8 +220,13 @@ static int pci_vpd_pci22_wait(struct pci_dev *dev) return 0; } - if (time_after(jiffies, timeout)) + if (time_after(jiffies, timeout)) { + dev_printk(KERN_DEBUG, &dev->dev, + "vpd read failed. This is likely a FW bug " + "on this device. Contact the card vendor " + "a FW update."); return -ETIMEDOUT; + } if (fatal_signal_pending(current)) return -EINTR; if (!cond_resched())