From patchwork Fri Nov 14 22:19:03 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 5309881 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 0F6ED9F2ED for ; Fri, 14 Nov 2014 22:19:12 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DA0942017D for ; Fri, 14 Nov 2014 22:19:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 044ED20149 for ; Fri, 14 Nov 2014 22:19:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422727AbaKNWTI (ORCPT ); Fri, 14 Nov 2014 17:19:08 -0500 Received: from mail-ig0-f169.google.com ([209.85.213.169]:62289 "EHLO mail-ig0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422703AbaKNWTH (ORCPT ); Fri, 14 Nov 2014 17:19:07 -0500 Received: by mail-ig0-f169.google.com with SMTP id hn18so538544igb.0 for ; Fri, 14 Nov 2014 14:19:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-type:content-disposition:user-agent; bh=i7uWqArBoj8qxEvBLViTUOfT9gCSgNPsNB8gzWcPQa4=; b=VuQ+B5lcriUhAFrKwOzRZjxoG9dl+6BjxLTC1zXltUwHGiY2LGWv1qUwORx0AMn6/y lLI/KEUJ2OwmqJKSGhJJS//kK5hIqJikm0Xu+R96m09F0gc8Zrl5uqu8G58EMoGAfegJ 6jbyjgVaMEH4u7MXRZPQIXm8JX3jd3XuUxAQWxFdZ4whr3TIeVQZAfFkfJ/mTq6LdjCh KT4AdEP5op9aQO3+EXE8EV6COMByaF6N7L7aOj66V/RrIUjebjl2sFmbASnoQjdcRaz1 lTYvOED8inXKXyqnsPXyl0a0zMIJwqdnJfOnSfWd+fq4rRttgsqaP8Z81whj/Dd42QbP VO7g== X-Gm-Message-State: ALoCoQkQdpP+3WDpf11FVxOq1JfLu8f0o+yR2s+doqyucI9Lm5rXepFOyg57rQjzAoUB+Fmqvpx2 X-Received: by 10.107.155.209 with SMTP id d200mr13570450ioe.12.1416003545972; Fri, 14 Nov 2014 14:19:05 -0800 (PST) Received: from dtor-ws ([2620:0:1000:1301:8c0e:c406:dbcd:b83b]) by mx.google.com with ESMTPSA id 40sm14993341iom.43.2014.11.14.14.19.05 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 14 Nov 2014 14:19:05 -0800 (PST) Date: Fri, 14 Nov 2014 14:19:03 -0800 From: Dmitry Torokhov To: Murali Karicheri Cc: Bjorn Helgaas , Santosh Shilimkar , Arnd Bergmann , Wolfram Sang , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] PCI: keystone: fix error handling of irq_of_parse_and_map Message-ID: <20141114221903.GA38539@dtor-ws> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Return value of irq_of_parse_and_map() is unsigned int, with 0 indicating failure, so testing for negative result never works. Signed-off-by: Dmitry Torokhov Acked-By: Murali Karicheri --- Not tested, found by casual code inspection. drivers/pci/host/pci-keystone.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/host/pci-keystone.c b/drivers/pci/host/pci-keystone.c index 8a27078..f2bd48d 100644 --- a/drivers/pci/host/pci-keystone.c +++ b/drivers/pci/host/pci-keystone.c @@ -197,7 +197,7 @@ static int ks_pcie_get_irq_controller_info(struct keystone_pcie *ks_pcie, */ for (temp = 0; temp < max_host_irqs; temp++) { host_irqs[temp] = irq_of_parse_and_map(*np_temp, temp); - if (host_irqs[temp] < 0) + if (!host_irqs[temp]) break; } if (temp) {