From patchwork Fri Oct 7 16:39:31 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 9366893 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id ECEA060752 for ; Fri, 7 Oct 2016 16:39:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DE94529274 for ; Fri, 7 Oct 2016 16:39:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D397E29745; Fri, 7 Oct 2016 16:39:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5B60929274 for ; Fri, 7 Oct 2016 16:39:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941153AbcJGQjg (ORCPT ); Fri, 7 Oct 2016 12:39:36 -0400 Received: from mail.kernel.org ([198.145.29.136]:56644 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941142AbcJGQjf (ORCPT ); Fri, 7 Oct 2016 12:39:35 -0400 Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6ABD3201D3; Fri, 7 Oct 2016 16:39:34 +0000 (UTC) Received: from localhost (unknown [69.55.156.165]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E0F7D20373; Fri, 7 Oct 2016 16:39:32 +0000 (UTC) Subject: [PATCH 07/10] PCI: imx6: Remove unused return values To: Richard Zhu , Lucas Stach From: Bjorn Helgaas Cc: linux-pci@vger.kernel.org Date: Fri, 07 Oct 2016 11:39:31 -0500 Message-ID: <20161007163931.25776.92712.stgit@bhelgaas-glaptop2.roam.corp.google.com> In-Reply-To: <20161007163839.25776.2512.stgit@bhelgaas-glaptop2.roam.corp.google.com> References: <20161007163839.25776.2512.stgit@bhelgaas-glaptop2.roam.corp.google.com> User-Agent: StGit/0.16 MIME-Version: 1.0 X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Remove unused return values. No functional change intended. Signed-off-by: Bjorn Helgaas --- drivers/pci/host/pci-imx6.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c index 1a89165..9971b73 100644 --- a/drivers/pci/host/pci-imx6.c +++ b/drivers/pci/host/pci-imx6.c @@ -251,7 +251,7 @@ static int imx6q_pcie_abort_handler(unsigned long addr, return 0; } -static int imx6_pcie_assert_core_reset(struct imx6_pcie *imx6) +static void imx6_pcie_assert_core_reset(struct imx6_pcie *imx6) { u32 val, gpr1, gpr12; @@ -304,8 +304,6 @@ static int imx6_pcie_assert_core_reset(struct imx6_pcie *imx6) IMX6Q_GPR1_PCIE_REF_CLK_EN, 0 << 16); break; } - - return 0; } static int imx6_pcie_enable_ref_clk(struct imx6_pcie *imx6) @@ -344,7 +342,7 @@ static int imx6_pcie_enable_ref_clk(struct imx6_pcie *imx6) return ret; } -static int imx6_pcie_deassert_core_reset(struct imx6_pcie *imx6) +static void imx6_pcie_deassert_core_reset(struct imx6_pcie *imx6) { struct pcie_port *pp = &imx6->pp; int ret; @@ -352,7 +350,7 @@ static int imx6_pcie_deassert_core_reset(struct imx6_pcie *imx6) ret = clk_prepare_enable(imx6->pcie_phy); if (ret) { dev_err(pp->dev, "unable to enable pcie_phy clock\n"); - goto err_pcie_phy; + return; } ret = clk_prepare_enable(imx6->pcie_bus); @@ -400,7 +398,7 @@ static int imx6_pcie_deassert_core_reset(struct imx6_pcie *imx6) break; } - return 0; + return; err_ref_clk: clk_disable_unprepare(imx6->pcie); @@ -408,8 +406,6 @@ err_pcie: clk_disable_unprepare(imx6->pcie_bus); err_pcie_bus: clk_disable_unprepare(imx6->pcie_phy); -err_pcie_phy: - return ret; } static void imx6_pcie_init_phy(struct imx6_pcie *imx6)