From patchwork Tue Nov 29 18:43:34 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 9452959 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C955E6071C for ; Tue, 29 Nov 2016 18:44:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BAD04283D3 for ; Tue, 29 Nov 2016 18:44:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AEDAA283F7; Tue, 29 Nov 2016 18:44:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_HI,SUSPICIOUS_RECIPS autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5EB84283D3 for ; Tue, 29 Nov 2016 18:44:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933481AbcK2Snm (ORCPT ); Tue, 29 Nov 2016 13:43:42 -0500 Received: from mail.kernel.org ([198.145.29.136]:40754 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934392AbcK2Snh (ORCPT ); Tue, 29 Nov 2016 13:43:37 -0500 Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3F02420204; Tue, 29 Nov 2016 18:43:36 +0000 (UTC) Received: from localhost (unknown [69.55.156.165]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 35D4020142; Tue, 29 Nov 2016 18:43:35 +0000 (UTC) Subject: [PATCH 2/2] ACPI: Ignore Consumer/Producer for QWord/DWord/Word Address Space From: Bjorn Helgaas To: linux-pci@vger.kernel.org Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linaro-acpi@lists.linaro.org Date: Tue, 29 Nov 2016 12:43:34 -0600 Message-ID: <20161129184334.7618.5495.stgit@bhelgaas-glaptop.roam.corp.google.com> In-Reply-To: <20161129182415.7618.99129.stgit@bhelgaas-glaptop.roam.corp.google.com> References: <20161129182415.7618.99129.stgit@bhelgaas-glaptop.roam.corp.google.com> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Per ACPI spec r6.0, sec 6.4.3.5.1, 2, 3, Bit [0] of General Flags (the Consumer/Producer bit) should be ignored for QWord/DWord/Word Address Space descriptors. The Consumer/Producer bit is defined only for the Extended Address Space descriptor. Ignore Consumer/Producer except for Extended Address Space descriptors. Note that for QWord/DWord/Word descriptors, we previously applied the translation offset (_TRA) only when the Consumer/Producer bit was set. This patch changes that: for those descriptors, we ignore Consumer/Producer and always apply the translation offset. Signed-off-by: Bjorn Helgaas --- drivers/acpi/resource.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c index 2732d39e..b45cd8f 100644 --- a/drivers/acpi/resource.c +++ b/drivers/acpi/resource.c @@ -261,11 +261,16 @@ bool acpi_dev_resource_address_space(struct acpi_resource *ares, * primary side. Non-bridge devices must list 0 for all Address * Translation offset bits. */ - if (addr->producer_consumer == ACPI_PRODUCER) + if (ares->type == ACPI_RESOURCE_TYPE_EXTENDED_ADDRESS64) { + if (addr->producer_consumer == ACPI_PRODUCER) + offset = attr->translation_offset; + else if (attr->translation_offset) + pr_debug("ACPI: translation_offset(%lld) is invalid for non-bridge device.\n", + attr->translation_offset); + } else { offset = attr->translation_offset; - else if (attr->translation_offset) - pr_debug("ACPI: translation_offset(%lld) is invalid for non-bridge device.\n", - attr->translation_offset); + } + start = attr->minimum + offset; end = attr->maximum + offset; @@ -294,7 +299,8 @@ bool acpi_dev_resource_address_space(struct acpi_resource *ares, return false; } - if (addr->producer_consumer == ACPI_PRODUCER) + if (ares->type == ACPI_RESOURCE_TYPE_EXTENDED_ADDRESS64 && + addr->producer_consumer == ACPI_PRODUCER) res->flags |= IORESOURCE_WINDOW; if (addr->info.mem.caching == ACPI_PREFETCHABLE_MEMORY)