From patchwork Tue Jan 3 09:51:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mika Westerberg X-Patchwork-Id: 9494683 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A616860414 for ; Tue, 3 Jan 2017 10:00:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7B6ED266F3 for ; Tue, 3 Jan 2017 10:00:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6C9C126B39; Tue, 3 Jan 2017 10:00:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 04E71266F3 for ; Tue, 3 Jan 2017 10:00:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755848AbdACKAt (ORCPT ); Tue, 3 Jan 2017 05:00:49 -0500 Received: from mga06.intel.com ([134.134.136.31]:7564 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750879AbdACKAs (ORCPT ); Tue, 3 Jan 2017 05:00:48 -0500 Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP; 03 Jan 2017 02:00:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,451,1477983600"; d="scan'208";a="804570328" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.157]) by FMSMGA003.fm.intel.com with SMTP; 03 Jan 2017 02:00:44 -0800 Received: by lahna (sSMTP sendmail emulation); Tue, 03 Jan 2017 11:51:58 +0200 Date: Tue, 3 Jan 2017 11:51:58 +0200 From: Mika Westerberg To: "Rafael J. Wysocki" Cc: Lukas Wunner , Kilian Singer , Bjorn Helgaas , linux-pci , Peter Wu Subject: Re: PCI: Revert "PCI: Add runtime PM support for PCIe ports" Message-ID: <20170103095158.GH3353@lahna.fi.intel.com> References: <20161228161816.GA19653@bhelgaas-glaptop.roam.corp.google.com> <20170102121019.GA3353@lahna.fi.intel.com> <20170102144852.GE3353@lahna.fi.intel.com> <1731082.izJCnRoq0n@aspire.rjw.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1731082.izJCnRoq0n@aspire.rjw.lan> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, Jan 02, 2017 at 10:31:07PM +0100, Rafael J. Wysocki wrote: > On Monday, January 02, 2017 04:48:52 PM Mika Westerberg wrote: > > On Mon, Jan 02, 2017 at 02:10:19PM +0200, Mika Westerberg wrote: > > > I've checked the acpidump of this machine and it does not seem to be a > > > traditional Optimus machine. At least this one is missing the magic _DSM > > > which is used to gather capabilities of the graphics device. > > > > > > However, it does have _PR3 and it is attached to the device > > > (_SB.PCI0.PEG) itself, not the root port. > > > > Nah, actually PEG is the root port. So it certainly looks like > > a traditional Optimus machine. > > So can we quirk that thing somehow and see if that helps (for debugging > purposes at least)? I was kind of hoping disabling D3cold would do that (prevent it from turning off power resources). But we can also just force it to use _DSM instead and see if it makes a difference. I guess the reason why keyboard and mouse become unresponsive is because the driver tries to resume the device and hogs the CPU. At least it looks like so from the dmesg in comment 27 (of the bugzilla bug) where NMI watchdog is triggered. Since this might be related to nouveau, adding Peter Wu to the loop. Peter the bug in question is https://bugzilla.kernel.org/show_bug.cgi?id=190861. Kilian, can you try the following hack as well? --- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/gpu/drm/nouveau/nouveau_acpi.c b/drivers/gpu/drm/nouveau/nouveau_acpi.c index 193573d191e5..50482d5c8072 100644 --- a/drivers/gpu/drm/nouveau/nouveau_acpi.c +++ b/drivers/gpu/drm/nouveau/nouveau_acpi.c @@ -282,7 +282,7 @@ static void nouveau_dsm_pci_probe(struct pci_dev *pdev, acpi_handle *dhandle_out (result & OPTIMUS_DYNAMIC_PWR_CAP) ? "dynamic power, " : "", (result & OPTIMUS_HDA_CODEC_MASK) ? "hda bios codec supported" : ""); - *has_pr3 = nouveau_pr3_present(pdev); +// *has_pr3 = nouveau_pr3_present(pdev); } }