From patchwork Mon Feb 20 15:30:25 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 9583111 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E7DC760578 for ; Mon, 20 Feb 2017 15:39:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D9E3128880 for ; Mon, 20 Feb 2017 15:39:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CEA9228882; Mon, 20 Feb 2017 15:39:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3253B28880 for ; Mon, 20 Feb 2017 15:39:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753333AbdBTPjs (ORCPT ); Mon, 20 Feb 2017 10:39:48 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:36607 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752767AbdBTPjr (ORCPT ); Mon, 20 Feb 2017 10:39:47 -0500 Received: by mail-pg0-f68.google.com with SMTP id a123so10608800pgc.3; Mon, 20 Feb 2017 07:39:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=N/RX2NDxIfdk5iAVhOAuvlfMvQVorpiMahRUad7mryc=; b=IyLuswRBvELMjLwgQSe51WPek8GAyQowBnxwcxI3b/ydBnzMi0OgG1zJpAJhUehQMa TTXQ2SxVVGydBPv8lHyHQLOUvUbrNEmKiX5GWV/QjZSwjstZst/DDXUu8pIwOrnOq0SW ciqbklYug511uoeBmK4ea1+QP70Kdmu95m4jgwUl87T3obWtNaqUqXASnupHbj8qoJoN LY5FO5EIL527oNXznErz0IQmnnO+DpeSgPkSoeftiW29mPXo8P/sdQpN5M0pmBBMU+LV nkTzT6rPn7Dh9f/n1WTgegzFwb3IpEXjQ8h8RBFVH5KRkPpk024tQDZ7LkfIeZjUks3b NCcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=N/RX2NDxIfdk5iAVhOAuvlfMvQVorpiMahRUad7mryc=; b=kfuITGy7fb7iYXCsoYkA7k/MNM2M34PnHktCnU3cxA1nx6x9YCFMOUzUyIlwF7jA65 wwg0sRUNBPsnz+PAdELueLm497TS77WgvyiQYPGHANUgbEbg80pAnAVTHpK+xzGG9xeZ EjJMkwx6FtP+ZULh/UTeBp1WTd4uoeQg44nY4rBiSGv5ZQvFgcGFX4o4DkVOyHhMibd1 dTxphPL7sg2UKebWGcK5qPY/IrG5SSVt02vwNZyiJKOV837rHITvDK3ZGP9wl/bYc0IW cXVjT2BqxmploaOijRUpCk2QSR2KAqUbJEaItTTxbo/EePJ50vEbgym+EhM17lKIybMV 6QGQ== X-Gm-Message-State: AMke39l6wIDXq0z6jye8YneCnUKpzj5TABK7ZfG6Ag7rKG9mFv5WOmx60qjHGsS66QqJTA== X-Received: by 10.98.89.21 with SMTP id n21mr26952624pfb.163.1487604638121; Mon, 20 Feb 2017 07:30:38 -0800 (PST) Received: from localhost.localdomain (c-73-19-0-61.hsd1.wa.comcast.net. [73.19.0.61]) by smtp.gmail.com with ESMTPSA id 67sm35815004pfd.120.2017.02.20.07.30.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Feb 2017 07:30:37 -0800 (PST) From: Andrey Smirnov To: linux-pci@vger.kernel.org Cc: Andrey Smirnov , yurovsky@gmail.com, Lucas Stach , Bjorn Helgaas , Fabio Estevam , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 4/4] PCI: imx6: Allow probe deferal by reset GPIO Date: Mon, 20 Feb 2017 07:30:25 -0800 Message-Id: <20170220153025.32096-5-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170220153025.32096-1-andrew.smirnov@gmail.com> References: <20170220153025.32096-1-andrew.smirnov@gmail.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Some designs implement reset GPIO via a GPIO expander connected to a peripheral bus. One such example would be i.MX7 Sabre board where said GPIO is provided by SPI shift register connected to a bitbanged SPI bus. In order to support such designs allow reset GPIO request to defer probing of the driver. Cc: yurovsky@gmail.com Cc: Lucas Stach Cc: Bjorn Helgaas Cc: Fabio Estevam Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Reviewed-by: Lucas Stach Signed-off-by: Andrey Smirnov --- drivers/pci/host/pci-imx6.c | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c index 071251f3..fe832e7f 100644 --- a/drivers/pci/host/pci-imx6.c +++ b/drivers/pci/host/pci-imx6.c @@ -638,8 +638,8 @@ static struct pcie_host_ops imx6_pcie_host_ops = { .host_init = imx6_pcie_host_init, }; -static int __init imx6_add_pcie_port(struct imx6_pcie *imx6_pcie, - struct platform_device *pdev) +static int imx6_add_pcie_port(struct imx6_pcie *imx6_pcie, + struct platform_device *pdev) { struct pcie_port *pp = &imx6_pcie->pp; struct device *dev = pp->dev; @@ -674,7 +674,7 @@ static int __init imx6_add_pcie_port(struct imx6_pcie *imx6_pcie, return 0; } -static int __init imx6_pcie_probe(struct platform_device *pdev) +static int imx6_pcie_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct imx6_pcie *imx6_pcie; @@ -693,10 +693,6 @@ static int __init imx6_pcie_probe(struct platform_device *pdev) imx6_pcie->variant = (enum imx6_pcie_variants)of_device_get_match_data(dev); - /* Added for PCI abort handling */ - hook_fault_code(16 + 6, imx6q_pcie_abort_handler, SIGBUS, 0, - "imprecise external abort"); - dbi_base = platform_get_resource(pdev, IORESOURCE_MEM, 0); pp->dbi_base = devm_ioremap_resource(dev, dbi_base); if (IS_ERR(pp->dbi_base)) @@ -716,6 +712,8 @@ static int __init imx6_pcie_probe(struct platform_device *pdev) dev_err(dev, "unable to get reset gpio\n"); return ret; } + } else if (imx6_pcie->reset_gpio == -EPROBE_DEFER) { + return imx6_pcie->reset_gpio; } /* Fetch clocks */ @@ -828,11 +826,22 @@ static struct platform_driver imx6_pcie_driver = { .name = "imx6q-pcie", .of_match_table = imx6_pcie_of_match, }, + .probe = imx6_pcie_probe, .shutdown = imx6_pcie_shutdown, }; static int __init imx6_pcie_init(void) { - return platform_driver_probe(&imx6_pcie_driver, imx6_pcie_probe); + /* + * Since probe() can be deferred we need to make sure that + * hook_fault_code is not called after __init memory is freed + * by kernel and since imx6q_pcie_abort_handler() is a no-op + * we can install the handler here without risking it + * accessing some unitialized driver state + */ + hook_fault_code(16 + 6, imx6q_pcie_abort_handler, SIGBUS, 0, + "imprecise external abort"); + + return platform_driver_register(&imx6_pcie_driver); } device_initcall(imx6_pcie_init);