From patchwork Tue Mar 21 15:59:52 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9637045 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A8924602D6 for ; Tue, 21 Mar 2017 16:11:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9C9E927165 for ; Tue, 21 Mar 2017 16:11:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9153D28338; Tue, 21 Mar 2017 16:11:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 56D1A27165 for ; Tue, 21 Mar 2017 16:11:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933124AbdCUQKo (ORCPT ); Tue, 21 Mar 2017 12:10:44 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:50964 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933120AbdCUQJj (ORCPT ); Tue, 21 Mar 2017 12:09:39 -0400 Received: from wuerfel.lan ([78.42.17.5]) by mrelayeu.kundenserver.de (mreue104 [212.227.15.145]) with ESMTPA (Nemesis) id 0MTgXI-1chWX41li4-00QVqQ; Tue, 21 Mar 2017 17:00:10 +0100 From: Arnd Bergmann To: Bjorn Helgaas Cc: Arnd Bergmann , Jayachandran C , Tomasz Nowicki , Lorenzo Pieralisi , Dongdong Liu , Christopher Covington , Duc Dang , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] PCI: generic: stop hiding pci_host_common_probe declaration Date: Tue, 21 Mar 2017 16:59:52 +0100 Message-Id: <20170321160003.339217-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:bUCmjftg18nJ+1UKqLjDkB7aMOkoiSIyPYenY+H1CIMXB6c/fh7 W4v87v0xdqDyjlVUJd6A0BdpfSZ8L654NofKxP7Mrv7p0hEeiTB2w52oM3/gfH4/QVGLrRA cRs+BjIOQgmpiFzKaL2mSAR6/bzZ+dG4wvM5toD07ylDbaCuFNdKJntpngIhkBLoLUXvDa3 0B6HJkOKBCQsX8wTScTkg== X-UI-Out-Filterresults: notjunk:1; V01:K0:W+Xb+7SXuck=:xomu1qGVqx4bQVB1w0opQs VFT1isZQs0WYgL/x43sdtzylzZ2RTME4LY/LTTafwmG/bx5z5+yhFBL6b8iYY5FNAIaFLKRm3 OCR/tlzcOXY3kQtmBHI7nNhlLNEHbzqgYWE5DanV+UrVi0cSrXEqf/roZq+wzkvavErRS0PpX UlzcwTbTS9xVcuHs9knWa7EiKb3Fj66Tyq59CboNM9mIu8YMHFIMg/vajkILnU5rVAP4AMSkF HpzvFthBbJry2+nSFnxz/ysjzdDGyBTlZgjvsIkiWEcyv1bgyshxtV96/++/d7GohznEnXEIm rG5/Tg+HggI2XaGGeL5+JWDeS0aT+xc7k7b/OVRKnScasA/js/g4XwBucm7xFAiR7Xf4TjYgv vBVABObzB5xCUkEhVODoq2jfeGUrUoYM2sxqUi9TWc8lpXetcUlCwvCtJQsx9Q3xPsi5KYW6/ Kqd1Rx24laZflvVbWqwYPNkDDg7kK4Kt2cu8wJSAF+YeEts594T16Ee0FSlWjpiEdzf+SOu4r wCnJC6Ijmcd/3oEbapv0ffgOmcNnc4pUF6NajCGIAPAXL2ZsVES26bQOOJM+ymHvXXmCAaRU9 +BK4SxDIvhPXe5PTuubhFPM4ORaaBTKIwsTU6aKAGz/84UMbGai9wwlEK8uuC1ieINDgYhk0e gSoqNJLC8dbEmkwvJ8F+Kf/aPdxSWDkQDemOnVjrC3C6mZ0Ha73mD6hnYeZlASHgGhMI= Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When pci_host_common_probe() was moved into a separate module, the #ifdef around the declaration was left in the header file, which can lead to build errors in some configurations: drivers/pci/host/pci-thunder-pem.c: In function 'thunder_pem_probe': drivers/pci/host/pci-thunder-pem.c:412:9: error: implicit declaration of function 'pci_host_common_probe';did you mean 'pci_host_bridge_priv'? [-Werror=implicit-function-declaration] The ifdef serves no real purpose anyway, so we can just remove it. Fixes: 4e64dbe226e7 ("PCI: generic: Expose pci_host_common_probe() for use by other drivers") Signed-off-by: Arnd Bergmann Reviewed-by: Tomasz Nowicki Tested-by: Tomasz Nowicki --- include/linux/pci-ecam.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/linux/pci-ecam.h b/include/linux/pci-ecam.h index f0d2b9451270..92a73847e1d3 100644 --- a/include/linux/pci-ecam.h +++ b/include/linux/pci-ecam.h @@ -68,9 +68,7 @@ extern struct pci_ecam_ops xgene_v1_pcie_ecam_ops; /* APM X-Gene PCIe v1 */ extern struct pci_ecam_ops xgene_v2_pcie_ecam_ops; /* APM X-Gene PCIe v2.x */ #endif -#ifdef CONFIG_PCI_HOST_GENERIC /* for DT-based PCI controllers that support ECAM */ int pci_host_common_probe(struct platform_device *pdev, struct pci_ecam_ops *ops); #endif -#endif