| Message ID | 20170614082338.15673-15-guodong.xu@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Wed, Jun 14, 2017 at 04:23:31PM +0800, Guodong Xu wrote: > From: Leo Yan <leo.yan@linaro.org> > > On Hi3660 there have two clusters, one is CA53 cluster and another is > CA73 cluster. This two clusters have different idle states separately. > With Daniel Lezcano's patch (ARM: cpuidle: Support asymmetric idle > definition), now ARM idle driver can support different clusters with > different idle states. > > Base on this, this patch is to bind two clusters idle states on Hi3660. > Except the "WFI" states are enabled by default for all CPUs, this patch > also binds below extra idle states: > > - CA53 CPUs have two more states: > CPU_SLEEP: CPU power off state > CLUSTER_SLEEP_0: Cluster power off state > > - CA73 CPUs have three more states: > CPU_NAP: CPU retention state > CPU_SLEEP: CPU power off state > CLUSTER_SLEEP_1: Cluster power off state Hi Guodong, Wei and all, As Daniel reminded, this patch is dependent on patch (ARM: cpuidle: Support asymmetric idle definition) [1] but his patch has not been finally merged yet. So let us hold on this patch for Daniel's patch is picked up firstly. At the meantime welcome the review and comment for this patch ahead. [1] https://patchwork.kernel.org/patch/9781869/ [...] Thanks, Leo Yan
On Thu, Jun 15, 2017 at 8:23 AM, Leo Yan <leo.yan@linaro.org> wrote: > On Wed, Jun 14, 2017 at 04:23:31PM +0800, Guodong Xu wrote: >> From: Leo Yan <leo.yan@linaro.org> >> >> On Hi3660 there have two clusters, one is CA53 cluster and another is >> CA73 cluster. This two clusters have different idle states separately. >> With Daniel Lezcano's patch (ARM: cpuidle: Support asymmetric idle >> definition), now ARM idle driver can support different clusters with >> different idle states. >> >> Base on this, this patch is to bind two clusters idle states on Hi3660. >> Except the "WFI" states are enabled by default for all CPUs, this patch >> also binds below extra idle states: >> >> - CA53 CPUs have two more states: >> CPU_SLEEP: CPU power off state >> CLUSTER_SLEEP_0: Cluster power off state >> >> - CA73 CPUs have three more states: >> CPU_NAP: CPU retention state >> CPU_SLEEP: CPU power off state >> CLUSTER_SLEEP_1: Cluster power off state > > Hi Guodong, Wei and all, > > As Daniel reminded, this patch is dependent on patch (ARM: cpuidle: > Support asymmetric idle definition) [1] but his patch has not been > finally merged yet. So let us hold on this patch for Daniel's patch > is picked up firstly. > > At the meantime welcome the review and comment for this patch ahead. > Ok, so, I will drop this patch, and resend my patchset as v4. -Guodong > [1] https://patchwork.kernel.org/patch/9781869/ > > [...] > > Thanks, > Leo Yan
diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi index e138973..4101bf5 100644 --- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi +++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi @@ -58,6 +58,7 @@ device_type = "cpu"; reg = <0x0 0x0>; enable-method = "psci"; + cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP_0>; }; cpu1: cpu@1 { @@ -65,6 +66,7 @@ device_type = "cpu"; reg = <0x0 0x1>; enable-method = "psci"; + cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP_0>; }; cpu2: cpu@2 { @@ -72,6 +74,7 @@ device_type = "cpu"; reg = <0x0 0x2>; enable-method = "psci"; + cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP_0>; }; cpu3: cpu@3 { @@ -79,6 +82,7 @@ device_type = "cpu"; reg = <0x0 0x3>; enable-method = "psci"; + cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP_0>; }; cpu4: cpu@100 { @@ -86,6 +90,11 @@ device_type = "cpu"; reg = <0x0 0x100>; enable-method = "psci"; + cpu-idle-states = < + &CPU_NAP + &CPU_SLEEP + &CLUSTER_SLEEP_1 + >; }; cpu5: cpu@101 { @@ -93,6 +102,11 @@ device_type = "cpu"; reg = <0x0 0x101>; enable-method = "psci"; + cpu-idle-states = < + &CPU_NAP + &CPU_SLEEP + &CLUSTER_SLEEP_1 + >; }; cpu6: cpu@102 { @@ -100,6 +114,11 @@ device_type = "cpu"; reg = <0x0 0x102>; enable-method = "psci"; + cpu-idle-states = < + &CPU_NAP + &CPU_SLEEP + &CLUSTER_SLEEP_1 + >; }; cpu7: cpu@103 { @@ -107,6 +126,50 @@ device_type = "cpu"; reg = <0x0 0x103>; enable-method = "psci"; + cpu-idle-states = < + &CPU_NAP + &CPU_SLEEP + &CLUSTER_SLEEP_1 + >; + }; + + idle-states { + entry-method = "psci"; + + CPU_NAP: cpu-nap { + compatible = "arm,idle-state"; + arm,psci-suspend-param = <0x0000001>; + entry-latency-us = <7>; + exit-latency-us = <2>; + min-residency-us = <15>; + }; + + CPU_SLEEP: cpu-sleep { + compatible = "arm,idle-state"; + local-timer-stop; + arm,psci-suspend-param = <0x0010000>; + entry-latency-us = <40>; + exit-latency-us = <70>; + min-residency-us = <3000>; + }; + + CLUSTER_SLEEP_0: cluster-sleep-0 { + compatible = "arm,idle-state"; + local-timer-stop; + arm,psci-suspend-param = <0x1010000>; + entry-latency-us = <500>; + exit-latency-us = <5000>; + min-residency-us = <20000>; + }; + + CLUSTER_SLEEP_1: cluster-sleep-1 { + compatible = "arm,idle-state"; + local-timer-stop; + arm,psci-suspend-param = <0x1010000>; + entry-latency-us = <1000>; + exit-latency-us = <5000>; + min-residency-us = <20000>; + }; }; };