From patchwork Wed Oct 11 14:02:09 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9999741 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 78D83602BF for ; Wed, 11 Oct 2017 14:02:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6AF7628A51 for ; Wed, 11 Oct 2017 14:02:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5EC8B28A53; Wed, 11 Oct 2017 14:02:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D6B8528A51 for ; Wed, 11 Oct 2017 14:02:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757460AbdJKOCa (ORCPT ); Wed, 11 Oct 2017 10:02:30 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:50244 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751691AbdJKOC2 (ORCPT ); Wed, 11 Oct 2017 10:02:28 -0400 Received: from wuerfel.lan ([95.208.190.237]) by mrelayeu.kundenserver.de (mreue006 [212.227.15.129]) with ESMTPA (Nemesis) id 0MSCWE-1dqmJH0uV8-00TGpM; Wed, 11 Oct 2017 16:02:25 +0200 From: Arnd Bergmann To: Linus Walleij , Bjorn Helgaas Cc: Arnd Bergmann , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] PCI: v3-semi: print resources using %pR format string Date: Wed, 11 Oct 2017 16:02:09 +0200 Message-Id: <20171011140224.3770968-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:AeDyABIfd8VYz7HGaM8V/k4KXamkf17C++j/W/qnzWgYG/QGahA jGCV+tUMlUTGE5SujgThHH02/ORWt0D8xV2/MfVjqe6BwwHA9tFVE+Ir8pM5a4iPHVNmk4z pLap7r9RIWaIqYJRbdO7U3t53Wgn4jhxP/LjyJQrx+alyqZOh9mDrTpBbhIxTLM58Rz+Vj5 qRY9FfxQUpgAYZIFKLz4Q== X-UI-Out-Filterresults: notjunk:1; V01:K0:g61mooAJG4s=:GVAmMCVqZEEmRU3KXWWWV+ cQVDmnnV4X/VUO9VAk4Ye8GpIfsWbkTbfAg8jqVWhp5fspormZLBSX4zBdMFmggQLwX7GDztb 9UtURc1FyrQwZ2JI8xkhkdZdjlDi0aH1Ka8VmXgiPde6c2ZISMhA4Nor9Bv1txIGi6RsglAvr 2mtZPp0cQ8uwQq2qUKQrFBQuoKyAfYzNxnISEyB/mlyQusM/HYNN7luKD11bHQg/7xwRzR6lP TVsz5uxEPeiCCO3ERx2VnVyoxz/QANDyGsmF/lWYqCZZ2RlQwU7t2Iw4xyqRGi9gUgbnHwCj0 JiWfLqDVoHQvgYF+A8OqQ15ccw8ki1pNxbT6VMW2dq26x7/RaSAd+/kvohVUx53E8yStL9xse 8djs9z1s25GwF6THacvpVVvKzSQ5ndPXFsiAZ9+c9XwTcSvMCIJCd6sfmThCBnuDuGoxOkg5j 1gu/C5ZsobLyHJ36uYwU/iScxPFWBFyQaG/WAd2n20X4fZMQfnbxoCqbcQvPhUDvcZelYQDnk 97xTa23AhKTpTvKE1o+zbRSqlESBNFKPGiEtNQmXpeZMztr0EdF+33yZ0z7UMczn1G37NcYZG GKUuMvs/3bdi+KNYgEJT7P/WRRvm+2ILKLj0IFGhgqgfj6aOaSxvBvAfRdYjSIFL6SB0D138h sMr6vQXBbh61WpId3bl+GdNMUtgYfgJD5GhD0tJ/wi+GMBCzK16xEbKkk9QVDQ3JM1cV7xs+j d6GdQJ4w/CmI9OHDVpDvRBKOK787WJ5H8uIdbg== Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP A resource_size_t can be 32 or 64 bit on arm32, causing a number of warnings for incorrect format strings: In file included from include/linux/printk.h:327:0, from include/linux/kernel.h:13, from include/linux/interrupt.h:5, from drivers/pci/host/pci-v3-semi.c:19: drivers/pci/host/pci-v3-semi.c: In function 'v3_pci_setup_resource': drivers/pci/host/pci-v3-semi.c:536:4: error: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'phys_addr_t {aka long long unsigned int}' [-Werror=format=] "I/O window start %08x, bus addr %08x, size %08x\n", drivers/pci/host/pci-v3-semi.c:536:4: error: format '%x' expects argument of type 'unsigned int', but argument 6 has type 'resource_size_t {aka long long unsigned int}' [-Werror=format=] The best way to print this instead is to pass the resource itself to printk as a pointerm, using the special '%pR' format string for pretty-printing the range. For the bus address, we use %pap, respectively. Fixes: 132d10e24ff3 ("PCI: v3-semi: Add V3 Semiconductor PCI host driver") Signed-off-by: Arnd Bergmann Reviewed-by: Linus Walleij --- drivers/pci/host/pci-v3-semi.c | 24 +++++++++--------------- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/drivers/pci/host/pci-v3-semi.c b/drivers/pci/host/pci-v3-semi.c index a544d722aef1..02f6e1e3a421 100644 --- a/drivers/pci/host/pci-v3-semi.c +++ b/drivers/pci/host/pci-v3-semi.c @@ -532,10 +532,8 @@ static int v3_pci_setup_resource(struct v3_pci *v3, io->name = "V3 PCI I/O"; v3->io_mem = io_base; v3->io_bus_addr = io->start - win->offset; - dev_dbg(dev, - "I/O window start %08x, bus addr %08x, size %08x\n", - v3->io_mem, v3->io_bus_addr, - resource_size(io)); + dev_dbg(dev, "I/O window %pR, bus addr %pap\n", + io, &v3->io_bus_addr); ret = pci_remap_iospace(io, io_base); if (ret) { dev_warn(dev, @@ -556,9 +554,8 @@ static int v3_pci_setup_resource(struct v3_pci *v3, mem->name = "V3 PCI PRE-MEM"; v3->pre_mem = mem->start; v3->pre_bus_addr = mem->start - win->offset; - dev_dbg(dev, "PREFETCHABLE MEM window start %08x, bus addr %08x, size %08x\n", - v3->pre_mem, v3->pre_bus_addr, - resource_size(mem)); + dev_dbg(dev, "PREFETCHABLE MEM window %pR, bus addr %pap\n", + mem, &v3->pre_bus_addr); if (resource_size(mem) != SZ_256M) { dev_err(dev, "prefetchable memory range is not 256MB\n"); return -EINVAL; @@ -582,10 +579,8 @@ static int v3_pci_setup_resource(struct v3_pci *v3, mem->name = "V3 PCI NON-PRE-MEM"; v3->non_pre_mem = mem->start; v3->non_pre_bus_addr = mem->start - win->offset; - dev_dbg(dev, - "NON-PREFETCHABLE MEM window start %08x, bus addr %08x, size %08x\n", - v3->non_pre_mem, v3->non_pre_bus_addr, - resource_size(mem)); + dev_dbg(dev, "NON-PREFETCHABLE MEM window %pR, bus addr %pap\n", + mem, &v3->non_pre_bus_addr); if (resource_size(mem) != SZ_256M) { dev_err(dev, "non-prefetchable memory range is not 256MB\n"); @@ -602,7 +597,7 @@ static int v3_pci_setup_resource(struct v3_pci *v3, } break; case IORESOURCE_BUS: - dev_dbg(dev, "BUS %d\n", win->res->start); + dev_dbg(dev, "BUS %pR\n", win->res); host->busnr = win->res->start; break; default: @@ -781,9 +776,8 @@ static int v3_pci_probe(struct platform_device *pdev) * as the physical memory we've remapped it from. */ if (readl(v3->base + V3_LB_IO_BASE) != (regs->start >> 16)) - dev_err(dev, "V3_LB_IO_BASE = %08x but device is @%08x\n", - readl(v3->base + V3_LB_IO_BASE), - regs->start); + dev_err(dev, "V3_LB_IO_BASE = %08x but device is @%pR\n", + readl(v3->base + V3_LB_IO_BASE), regs); /* Configuration space is 16MB directly mapped */ regs = platform_get_resource(pdev, IORESOURCE_MEM, 1);