From patchwork Mon Nov 27 17:21:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alex Deucher X-Patchwork-Id: 10077669 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6F4C3602BC for ; Mon, 27 Nov 2017 17:21:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5123228A35 for ; Mon, 27 Nov 2017 17:21:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 45DD128CA3; Mon, 27 Nov 2017 17:21:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_WEB autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EA49E28A35 for ; Mon, 27 Nov 2017 17:21:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932310AbdK0RV0 (ORCPT ); Mon, 27 Nov 2017 12:21:26 -0500 Received: from mail-it0-f68.google.com ([209.85.214.68]:36350 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932305AbdK0RVY (ORCPT ); Mon, 27 Nov 2017 12:21:24 -0500 Received: by mail-it0-f68.google.com with SMTP id y71so10394263ita.1 for ; Mon, 27 Nov 2017 09:21:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=UOhKY2Tu50Y8ZK8bwKacGoEr2dYNoBCrHukAB2xDwE0=; b=IqIdBbbfuyUjVffvh6kCIcZ25PPiqIwWYapW0u3MDe3LaSx0pGr1ZYPuP6ExcyeQsu T9y3u50R1fYZs7gTnuif1KHMz0t9GkoHrVAK0bDwbYFSvIvfAqu+RONQW4PyXZASvRch XJ8uDaRUxDKXoQ6N58+MEYDy3Cpy4OcC1tGED8biBZkGeqjxEnA5n2qGglgob61+sLTr YiAkdaWhWehoCZLh8drI9/yVgAwQm6TvWRahw4yAyhQlA3U514aAHSWT3FHZ9w3AGuve 0YIGcgZ97gwqCukYLvcFWxibSulSERIvWu6d0PA+9QvsFlsXIWMjcME6s0Vl/V27aRXB g5YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=UOhKY2Tu50Y8ZK8bwKacGoEr2dYNoBCrHukAB2xDwE0=; b=uOkwQ6KkHo19rBd3NIsDii27M9Gii8zJEUEsZV6cvPTjVAHqEy2PJgbHQrSf/QOuBL BMGeDnPSGIKE+Opr6OLAV+z6iccq9GUv6ZBjFUPE323zTdoF5CPOyQDbAB/8A8ZiOR6N ao+go5UuBg0NuwpTdyyT6WGEfS4UeXvV3Zpqh75Dx/UQvv6Dpv+4td4aBQlViYbu/han 3y8LXu5lILenJ49INq1ekhs0JygBey6QXbC3zrkVXpPw7AdgtD4GQJR/9cVCF7wuZ5UM qjiCAxliUSCHIVdl4Xpjlm+hAa/WYhmp7qEUQS4BlPyczYIw5b+wFQ1pfSe2Uf8Syu+a 9vGw== X-Gm-Message-State: AJaThX6XVnr2f5zz5FJrcy9w51C39gSdATyOJmByNu/jfIYJdPXjcRwO 6RaG9DWEW+w7wNRFnsgmdKyy9w== X-Google-Smtp-Source: AGs4zMaiYE3bJQ/ln2efaa9ggpXoik3l4DH3XrLRZV+LKFq91tU/G+QPT4eyIBnb9W2UK8tA2iqcTw== X-Received: by 10.36.77.143 with SMTP id l137mr29474453itb.50.1511803283790; Mon, 27 Nov 2017 09:21:23 -0800 (PST) Received: from localhost.localdomain ([165.204.55.251]) by smtp.gmail.com with ESMTPSA id w186sm7544375itd.12.2017.11.27.09.21.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Nov 2017 09:21:23 -0800 (PST) From: Alex Deucher X-Google-Original-From: Alex Deucher To: dri-devel@lists.freedesktop.org, linux-pci@vger.kernel.org, helgaas@kernel.org Cc: Alex Deucher Subject: [PATCH] PCI: use dev_info rather than dev_err for rom validation Date: Mon, 27 Nov 2017 12:21:10 -0500 Message-Id: <20171127172110.16699-1-alexander.deucher@amd.com> X-Mailer: git-send-email 2.13.6 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On AMD GPUs, we use several mechanisms to fetch the vbios rom depending on the platform. We try to read the rom back via the rom BAR and fall back to other methods in some cases. This leads to spurious error messages from the pci rom code which are harmless in our case. This leads to bugs being files, etc. Change these to dev_info rather than dev_err to avoid that. Signed-off-by: Alex Deucher Reviewed-by: Christian König --- drivers/pci/rom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/rom.c b/drivers/pci/rom.c index b6edb187d160..7ab7c6bb17c6 100644 --- a/drivers/pci/rom.c +++ b/drivers/pci/rom.c @@ -92,14 +92,14 @@ size_t pci_get_rom_size(struct pci_dev *pdev, void __iomem *rom, size_t size) void __iomem *pds; /* Standard PCI ROMs start out with these bytes 55 AA */ if (readw(image) != 0xAA55) { - dev_err(&pdev->dev, "Invalid PCI ROM header signature: expecting 0xaa55, got %#06x\n", + dev_info(&pdev->dev, "Invalid PCI ROM header signature: expecting 0xaa55, got %#06x\n", readw(image)); break; } /* get the PCI data structure and check its "PCIR" signature */ pds = image + readw(image + 24); if (readl(pds) != 0x52494350) { - dev_err(&pdev->dev, "Invalid PCI ROM data signature: expecting 0x52494350, got %#010x\n", + dev_info(&pdev->dev, "Invalid PCI ROM data signature: expecting 0x52494350, got %#010x\n", readl(pds)); break; }