From patchwork Sat Mar 3 00:20:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dexuan Cui X-Patchwork-Id: 10255895 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DF2EF60211 for ; Sat, 3 Mar 2018 00:21:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CCE2127E5A for ; Sat, 3 Mar 2018 00:21:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C09D528604; Sat, 3 Mar 2018 00:21:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0EA8927E5A for ; Sat, 3 Mar 2018 00:21:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935487AbeCCAVa (ORCPT ); Fri, 2 Mar 2018 19:21:30 -0500 Received: from mail-sg2apc01on0106.outbound.protection.outlook.com ([104.47.125.106]:49948 "EHLO APC01-SG2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S935421AbeCCAU5 (ORCPT ); Fri, 2 Mar 2018 19:20:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=p/Dc06zl5xAhA4SRL1CzqoHya6EREbhXIpwQS1qNrU0=; b=PMesG9Fd5edCRe9ZOllxZcO3KVu/bwyF4KSXX9v5OwmztEcOz4mW/oZ1y/kpkGvyWKfbTI/2iFx3JQstKAfEEudZyLxgETw941+xGELE14n1bYHCLrMLi6NVwfSFYJ7Gc9B/2OLnKhS64NAFMNa1z+vP5UQehd7GcF2XFYW3y4Y= Received: from KL1P15301MB0006.APCP153.PROD.OUTLOOK.COM (10.170.167.17) by KL1P15301MB0054.APCP153.PROD.OUTLOOK.COM (10.170.168.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.567.6; Sat, 3 Mar 2018 00:20:48 +0000 Received: from KL1P15301MB0006.APCP153.PROD.OUTLOOK.COM ([10.170.167.17]) by KL1P15301MB0006.APCP153.PROD.OUTLOOK.COM ([10.170.167.17]) with mapi id 15.20.0567.002; Sat, 3 Mar 2018 00:20:48 +0000 From: Dexuan Cui To: "bhelgaas@google.com" , "linux-pci@vger.kernel.org" , KY Srinivasan , Stephen Hemminger CC: "linux-kernel@vger.kernel.org" , "driverdev-devel@linuxdriverproject.org" , Haiyang Zhang , "olaf@aepfle.de" , "apw@canonical.com" , "jasowang@redhat.com" , "vkuznets@redhat.com" , "marcelo.cerri@canonical.com" , Dexuan Cui , "stable@vger.kernel.org" , Jack Morgenstein Subject: [PATCH 3/3] PCI: hv: fix 2 hang issues in hv_compose_msi_msg() Thread-Topic: [PATCH 3/3] PCI: hv: fix 2 hang issues in hv_compose_msi_msg() Thread-Index: AQHTsoV6L95yC1dTN0ioPU1T64sHqw== Date: Sat, 3 Mar 2018 00:20:47 +0000 Message-ID: <20180303001947.20564-3-decui@microsoft.com> References: <20180303001947.20564-1-decui@microsoft.com> In-Reply-To: <20180303001947.20564-1-decui@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.15.1 authentication-results: spf=none (sender IP is ) smtp.mailfrom=decui@microsoft.com; x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; KL1P15301MB0054; 6:R4WaJhpG4KHsj/7ZXrbrFw/0mjcuqViw6kaSi8xIlJIAsZdHh+kz76kleTUZiWJ34AJHfcwgXUwAE7lCrRicOPNz9QOE29lG+WM6qxlYzISqkNeLAeMq6PAhq339hRXGE85w0xcnARRGnGsAuLY2r6t5NNGf2B0XDLM67m6RUXXx/tk4AViFsrWBVVGtDifICdge9h5LN+rGNA3n0TQIKaSMyRQun0ZAMJ6CA/z77/N7tX15ufp9BS4qYL+qJt/iV8lBbFo6fGGYvHvH7DDRZTOMtCo1FjaY3Z8IPB+UdRh5DtDnR63cfa2kA9RdVNzS3R69HkZfSdGSbk8Mw7hiWGvcIb057PRbn3gI8Rbc/042C+uq+Oh4HngDl7ez1PgN; 5:0GDHJTrd+yT4ST+SkbntEU/0R6MF2Rdfx+w6wOq0k7S/PC9Im0Oxd/f9aYXjt22+1Rlql+sWcWWhOw4ljj1iUJ+vCo7H/ewPLMsgEyeSrMq+aCSkr3l784ECfjc4nm+5D/sdeyzPWe4BuD87g46ydQ+5iB40Z/vkmxq/KJV4EPM=; 24:LOvUWXXDgg36Sxa1ZX9MVvXlC9kH5WCrZEmjs/TJuygdu8TFrsB+fLrHV8yStYdH07oTikPCFbFGPXrjaXMnxG7j2R4N83BQiLB2ujX9U9s=; 7:vi5aAjl+IDD8XVY4HpWDzTmgoi7ETacs4djZdJsbH3+I+t0NtvnePQh7I+ypDLWzpvClaLRn+4qkkUl4R2fCszHxoPIorIOsXYBuVVZTDg+ivsNLqoC0skPQE0iWt5X+pBZX6k7geXmWVErzJON1xrPjDy0fAS7exOj0vc+pZxeRLlzLz60SdhGogA2R+XJTRK/N2uMhoCFk0yyo15YWHARykLNWMWfNhTky3queuqFgeQazMnVUUbfZLlUWYd3I x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: c3070aba-d2f6-4335-50d9-08d5809c9d01 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603307)(7193020); SRVR:KL1P15301MB0054; x-ms-traffictypediagnostic: KL1P15301MB0054: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(9452136761055); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040501)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231220)(944501244)(52105095)(6055026)(61426038)(61427038)(6041288)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(6072148)(201708071742011); SRVR:KL1P15301MB0054; BCL:0; PCL:0; RULEID:; SRVR:KL1P15301MB0054; x-forefront-prvs: 0600F93FE1 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39860400002)(396003)(39380400002)(346002)(366004)(376002)(189003)(199004)(5660300001)(2906002)(4326008)(6116002)(8936002)(86362001)(2501003)(8676002)(6506007)(2900100001)(6436002)(14454004)(3660700001)(86612001)(305945005)(36756003)(99286004)(316002)(97736004)(25786009)(110136005)(1511001)(102836004)(54906003)(81166006)(10090500001)(81156014)(59450400001)(3280700002)(26005)(186003)(77096007)(6512007)(6636002)(76176011)(478600001)(2950100002)(3846002)(1076002)(22452003)(10290500003)(106356001)(66066001)(6486002)(50226002)(7416002)(68736007)(7736002)(105586002)(53936002)(22906009); DIR:OUT; SFP:1102; SCL:1; SRVR:KL1P15301MB0054; H:KL1P15301MB0006.APCP153.PROD.OUTLOOK.COM; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: ksyLwVvxzSFbl08WN4s2dp5vNH86iz12D5fRmPUt6Sfrs1EHXnQEotzONA2DzDyQJMyCFZiZbhVtKaiNSzKcvt5LUFzD3BwN8ZtW2BULSBMFZeGWg5sj3ZPfSBMn2iMKxNsoUdZvUyzzAEPqXQgBMDbno51INKBcQ3/hxmr3D4I= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: c3070aba-d2f6-4335-50d9-08d5809c9d01 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Mar 2018 00:20:47.5321 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1P15301MB0054 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP 1. With the patch "x86/vector/msi: Switch to global reservation mode" (4900be8360), the recent v4.15 and newer kernels always hang for 1-vCPU Hyper-V VM with SR-IOV. This is because when we reach hv_compose_msi_msg() by request_irq() -> request_threaded_irq() -> __setup_irq()->irq_startup() -> __irq_startup() -> irq_domain_activate_irq() -> ... -> msi_domain_activate() -> ... -> hv_compose_msi_msg(), local irq is disabled in __setup_irq(). Fix this by polling the channel. 2. If the host is ejecting the VF device before we reach hv_compose_msi_msg(), in a UP VM, we can hang in hv_compose_msi_msg() forever, because at this time the host doesn't respond to the CREATE_INTERRUPT request. This issue also happens to old kernels like v4.14, v4.13, etc. Fix this by polling the channel for the PCI_EJECT message and hpdev->state, and by checking the PCI vendor ID. Note: actually the above issues also happen to a SMP VM, if "hbus->hdev->channel->target_cpu == smp_processor_id()" is true. Signed-off-by: Dexuan Cui Tested-by: Adrian Suhov Tested-by: Chris Valean Cc: stable@vger.kernel.org Cc: Stephen Hemminger Cc: K. Y. Srinivasan Cc: Vitaly Kuznetsov Cc: Jack Morgenstein --- drivers/pci/host/pci-hyperv.c | 58 ++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 57 insertions(+), 1 deletion(-) diff --git a/drivers/pci/host/pci-hyperv.c b/drivers/pci/host/pci-hyperv.c index 57b1fb3ebdb9..32d6b03cdd40 100644 --- a/drivers/pci/host/pci-hyperv.c +++ b/drivers/pci/host/pci-hyperv.c @@ -522,6 +522,8 @@ struct hv_pci_compl { s32 completion_status; }; +static void hv_pci_onchannelcallback(void *context); + /** * hv_pci_generic_compl() - Invoked for a completion packet * @context: Set up by the sender of the packet. @@ -666,6 +668,31 @@ static void _hv_pcifront_read_config(struct hv_pci_dev *hpdev, int where, } } +static u16 hv_pcifront_get_vendor_id(struct hv_pci_dev *hpdev) +{ + u16 ret; + unsigned long flags; + void __iomem *addr = hpdev->hbus->cfg_addr + CFG_PAGE_OFFSET + + PCI_VENDOR_ID; + + spin_lock_irqsave(&hpdev->hbus->config_lock, flags); + + /* Choose the function to be read. (See comment above) */ + writel(hpdev->desc.win_slot.slot, hpdev->hbus->cfg_addr); + /* Make sure the function was chosen before we start reading. */ + mb(); + /* Read from that function's config space. */ + ret = readw(addr); + /* + * mb() is not required here, because the spin_unlock_irqrestore() + * is a barrier. + */ + + spin_unlock_irqrestore(&hpdev->hbus->config_lock, flags); + + return ret; +} + /** * _hv_pcifront_write_config() - Internal PCI config write * @hpdev: The PCI driver's representation of the device @@ -1108,8 +1135,37 @@ static void hv_compose_msi_msg(struct irq_data *data, struct msi_msg *msg) * Since this function is called with IRQ locks held, can't * do normal wait for completion; instead poll. */ - while (!try_wait_for_completion(&comp.comp_pkt.host_event)) + while (!try_wait_for_completion(&comp.comp_pkt.host_event)) { + /* 0xFFFF means an invalid PCI VENDOR ID. */ + if (hv_pcifront_get_vendor_id(hpdev) == 0xFFFF) { + dev_err_once(&hbus->hdev->device, + "the device has gone\n"); + goto free_int_desc; + } + + /* + * When the higher level interrupt code calls us with + * interrupt disabled, we must poll the channel by calling + * the channel callback directly when channel->target_cpu is + * the current CPU. When the higher level interrupt code + * calls us with interrupt enabled, let's add the + * local_bh_disable()/enable() to avoid race. + */ + local_bh_disable(); + + if (hbus->hdev->channel->target_cpu == smp_processor_id()) + hv_pci_onchannelcallback(hbus); + + local_bh_enable(); + + if (hpdev->state == hv_pcichild_ejecting) { + dev_err_once(&hbus->hdev->device, + "the device is being ejected\n"); + goto free_int_desc; + } + udelay(100); + } if (comp.comp_pkt.completion_status < 0) { dev_err(&hbus->hdev->device,