| Message ID | 20180315161901.772729-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Thu, Mar 15, 2018 at 05:18:39PM +0100, Arnd Bergmann wrote: > The new PM support causes a warning when CONFIG_PM is disabled: > > drivers/pci/host/pci-tegra.c:2482:12: error: 'tegra_pcie_pm_resume' defined but not used [-Werror=unused-function] > static int tegra_pcie_pm_resume(struct device *dev) > drivers/pci/host/pci-tegra.c:2463:12: error: 'tegra_pcie_pm_suspend' defined but not used [-Werror=unused-function] > static int tegra_pcie_pm_suspend(struct device *dev) > > Marking the functions as __maybe_unused lets the compiler drop them > silently instead. > > Fixes: b90b44154023 ("PCI: tegra: Add power management support") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/pci/host/pci-tegra.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Thierry Reding <treding@nvidia.com>
diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegra.c index 39c4af9cf055..389e74be846c 100644 --- a/drivers/pci/host/pci-tegra.c +++ b/drivers/pci/host/pci-tegra.c @@ -2460,7 +2460,7 @@ static int tegra_pcie_remove(struct platform_device *pdev) return 0; } -static int tegra_pcie_pm_suspend(struct device *dev) +static int __maybe_unused tegra_pcie_pm_suspend(struct device *dev) { struct tegra_pcie *pcie = dev_get_drvdata(dev); struct tegra_pcie_port *port; @@ -2479,7 +2479,7 @@ static int tegra_pcie_pm_suspend(struct device *dev) return 0; } -static int tegra_pcie_pm_resume(struct device *dev) +static int __maybe_unused tegra_pcie_pm_resume(struct device *dev) { struct tegra_pcie *pcie = dev_get_drvdata(dev); int err;
The new PM support causes a warning when CONFIG_PM is disabled: drivers/pci/host/pci-tegra.c:2482:12: error: 'tegra_pcie_pm_resume' defined but not used [-Werror=unused-function] static int tegra_pcie_pm_resume(struct device *dev) drivers/pci/host/pci-tegra.c:2463:12: error: 'tegra_pcie_pm_suspend' defined but not used [-Werror=unused-function] static int tegra_pcie_pm_suspend(struct device *dev) Marking the functions as __maybe_unused lets the compiler drop them silently instead. Fixes: b90b44154023 ("PCI: tegra: Add power management support") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/pci/host/pci-tegra.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)