| Message ID | 20180413181638.6424-1-jakub.kicinski@netronome.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Fri, 13 Apr 2018 11:16:38 -0700, Jakub Kicinski wrote: > Currently the pcie_print_link_status() will print PCIe bandwidth > and link width information but does not mention it is pertaining > to the PCIe. Since this and related functions are used exclusively > by networking drivers today users may get confused into thinking > that it's the NIC bandwidth that is being talked about. Insert a > "PCIe" into the messages. > > Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> Hi Bjorn! Could this small change still make it into 4.17 or are you planning to apply it in 4.18 cycle? IMHO the message clarification may be worth considering for 4.17.. > drivers/pci/pci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index aa86e904f93c..73a0a4993f6a 100644 > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -5273,11 +5273,11 @@ void pcie_print_link_status(struct pci_dev *dev) > bw_avail = pcie_bandwidth_available(dev, &limiting_dev, &speed, &width); > > if (bw_avail >= bw_cap) > - pci_info(dev, "%u.%03u Gb/s available bandwidth (%s x%d link)\n", > + pci_info(dev, "%u.%03u Gb/s available PCIe bandwidth (%s x%d link)\n", > bw_cap / 1000, bw_cap % 1000, > PCIE_SPEED2STR(speed_cap), width_cap); > else > - pci_info(dev, "%u.%03u Gb/s available bandwidth, limited by %s x%d link at %s (capable of %u.%03u Gb/s with %s x%d link)\n", > + pci_info(dev, "%u.%03u Gb/s available PCIe bandwidth, limited by %s x%d link at %s (capable of %u.%03u Gb/s with %s x%d link)\n", > bw_avail / 1000, bw_avail % 1000, > PCIE_SPEED2STR(speed), width, > limiting_dev ? pci_name(limiting_dev) : "<unknown>",
On Fri, Apr 13, 2018 at 11:16:38AM -0700, Jakub Kicinski wrote: > Currently the pcie_print_link_status() will print PCIe bandwidth > and link width information but does not mention it is pertaining > to the PCIe. Since this and related functions are used exclusively > by networking drivers today users may get confused into thinking > that it's the NIC bandwidth that is being talked about. Insert a > "PCIe" into the messages. > > Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> Applied to for-linus for v4.17, thanks! > --- > drivers/pci/pci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index aa86e904f93c..73a0a4993f6a 100644 > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -5273,11 +5273,11 @@ void pcie_print_link_status(struct pci_dev *dev) > bw_avail = pcie_bandwidth_available(dev, &limiting_dev, &speed, &width); > > if (bw_avail >= bw_cap) > - pci_info(dev, "%u.%03u Gb/s available bandwidth (%s x%d link)\n", > + pci_info(dev, "%u.%03u Gb/s available PCIe bandwidth (%s x%d link)\n", > bw_cap / 1000, bw_cap % 1000, > PCIE_SPEED2STR(speed_cap), width_cap); > else > - pci_info(dev, "%u.%03u Gb/s available bandwidth, limited by %s x%d link at %s (capable of %u.%03u Gb/s with %s x%d link)\n", > + pci_info(dev, "%u.%03u Gb/s available PCIe bandwidth, limited by %s x%d link at %s (capable of %u.%03u Gb/s with %s x%d link)\n", > bw_avail / 1000, bw_avail % 1000, > PCIE_SPEED2STR(speed), width, > limiting_dev ? pci_name(limiting_dev) : "<unknown>", > -- > 2.16.2 >
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index aa86e904f93c..73a0a4993f6a 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -5273,11 +5273,11 @@ void pcie_print_link_status(struct pci_dev *dev) bw_avail = pcie_bandwidth_available(dev, &limiting_dev, &speed, &width); if (bw_avail >= bw_cap) - pci_info(dev, "%u.%03u Gb/s available bandwidth (%s x%d link)\n", + pci_info(dev, "%u.%03u Gb/s available PCIe bandwidth (%s x%d link)\n", bw_cap / 1000, bw_cap % 1000, PCIE_SPEED2STR(speed_cap), width_cap); else - pci_info(dev, "%u.%03u Gb/s available bandwidth, limited by %s x%d link at %s (capable of %u.%03u Gb/s with %s x%d link)\n", + pci_info(dev, "%u.%03u Gb/s available PCIe bandwidth, limited by %s x%d link at %s (capable of %u.%03u Gb/s with %s x%d link)\n", bw_avail / 1000, bw_avail % 1000, PCIE_SPEED2STR(speed), width, limiting_dev ? pci_name(limiting_dev) : "<unknown>",
Currently the pcie_print_link_status() will print PCIe bandwidth and link width information but does not mention it is pertaining to the PCIe. Since this and related functions are used exclusively by networking drivers today users may get confused into thinking that it's the NIC bandwidth that is being talked about. Insert a "PCIe" into the messages. Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> --- drivers/pci/pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)