From patchwork Tue May 29 09:41:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 10434645 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9B1A7602BF for ; Tue, 29 May 2018 09:42:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8AB14286B7 for ; Tue, 29 May 2018 09:42:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7D854286C1; Tue, 29 May 2018 09:42:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EE24A286B7 for ; Tue, 29 May 2018 09:42:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932418AbeE2Jmc (ORCPT ); Tue, 29 May 2018 05:42:32 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:43221 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932354AbeE2Jma (ORCPT ); Tue, 29 May 2018 05:42:30 -0400 Received: from wuerfel.lan ([95.208.111.237]) by mrelayeu.kundenserver.de (mreue007 [212.227.15.129]) with ESMTPA (Nemesis) id 0MGsxZ-1faVQf16XZ-00DboJ; Tue, 29 May 2018 11:42:08 +0200 From: Arnd Bergmann To: Lorenzo Pieralisi , Bjorn Helgaas Cc: Arnd Bergmann , Ryder Lee , Cyrille Pitchen , Shawn Lin , Rob Herring , Marc Gonzalez , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] pci: mvebu: add MVEBU_MBUS dependency Date: Tue, 29 May 2018 11:41:51 +0200 Message-Id: <20180529094204.3945660-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K1:sR3iNluZSWEI52q+/OiRhj9MGoP3MUR5Zx0BiGB7p+MgiaUra4d cPb4IafqASGm2cnqwMmPOnGS7XOtMJrForIo+8OhC7wRMXo6m8HbJEtb5Ktfu01qhnL/HiA dSmrCWD2l7PDFtlesyZCC51eXmOgexE7V6uvjbvMLZOQt9AYs/w5knTvitfC4fNqBx0vj1o jVOCVnaJmrdizMfbuzq6g== X-UI-Out-Filterresults: notjunk:1; V01:K0:/ucZw6WphFw=:4rGQA28B3ltN0YIYNzKwrI ZHwOi+dci0T5NF967NUMKszuuxhkCEXIUXu97tQ6j5i2/bHFabtO6FkOc2MRozO8WFUSffqcG jvAsRe4L8hjmTEYUVBuTYD8pRA8EpKoDGUO9djZVjbM2C9U5Prqr4g78rXOrTUGiwVBuxZp7H iBpEyAIwiP9ex3P/imzDFjEKHses51wvSxj/sAv0V/iFEcdR13HwceFEhKG0cSFbOGJINnabD CaaPBlD1Bzn4RGIO/U5UXayc5jYj1TZFOnX5UnCODT67lelWlVnEzw+8jm+aVIkfvTrE4G+C0 2QPSzU4ciRizQzqF9UL2QYUBb8KExVXl60pC1jH1jS+73/97FZccAYUWHwUmIkzqDBy+OGH4p rL0nx2wFCOLk5rWs37BG7f3WdJaSWAbQBErVMUyT8IWSpLNQQwxxJoL1zooTAcxMDw/D3zy+U YOtdPurVi0M+PQd7lyo9CQSlGpZtQsYgwaaP14RTeNR7stgzqXELo++i0eG3pcgr4qglM4PPC McOmwuyiw7HTAAtuMK96bUPzpti7xibrM3dOX/8Fg38FctmEMXn8TwWAyshKh493BghiWXixz SD/9xu4ca8xRXgkN780O5X5r3sXsWMYR/8eDYWuc1JpvEwKdGMaPbL2Pn/r7LmPForO0pPshb hCqoiBiz8rH13D4bsF3pNutiPZCxD+KSxSQVbGGm+7AED5brgIYeemYXUAFndlNIBK/k= Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Enabling the PCI_MVEBU driver for compile testing caused a build failure on ARM randconfig builds: drivers/pci/host/pci-mvebu.c: In function 'mvebu_pcie_del_windows': drivers/pci/host/pci-mvebu.c:341:3: error: implicit declaration of function 'mvebu_mbus_del_window'; did you mean 'mvebu_pcie_del_windows'? [-Werror=implicit-function-declaration] mvebu_mbus_del_window(base, sz); ^~~~~~~~~~~~~~~~~~~~~ mvebu_pcie_del_windows drivers/pci/host/pci-mvebu.c: In function 'mvebu_pcie_add_windows': drivers/pci/host/pci-mvebu.c:364:9: error: implicit declaration of function 'mvebu_mbus_add_window_remap_by_id'; did you mean 'mvebu_pcie_add_windows'? [-Werror=implicit-function-declaration] ret = mvebu_mbus_add_window_remap_by_id(target, attribute, base, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ mvebu_pcie_add_windows drivers/pci/host/pci-mvebu.c: In function 'mvebu_pcie_probe': drivers/pci/host/pci-mvebu.c:1209:2: error: implicit declaration of function 'mvebu_mbus_get_pcie_mem_aperture'; did you mean 'mvebu_mbus_get_io_win_info'? [-Werror=implicit-function-declaration] drivers/pci/host/pci-mvebu.c:1215:2: error: implicit declaration of function 'mvebu_mbus_get_pcie_io_aperture'; did you mean 'mvebu_mbus_get_io_win_info'? [-Werror=implicit-function-declaration] The problem is that the mbus helper functions are not declared in the header. There are two ways of solving this: we can change the header to provide empty stub functions for CONFIG_MVEBU_MBUS=n, or we can add back the dependency here. I picked the second option since that is simpler, but it somewhat defeats the purpose of the original patch because we still cannot compile test on other platforms this way. Fixes: 51bc085d6454 ("PCI: Improve host drivers compile test coverage") Signed-off-by: Arnd Bergmann Acked-by: Rob Herring --- drivers/pci/host/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig index fa51d0893384..5340950f4b98 100644 --- a/drivers/pci/host/Kconfig +++ b/drivers/pci/host/Kconfig @@ -6,6 +6,7 @@ menu "PCI host controller drivers" config PCI_MVEBU bool "Marvell EBU PCIe controller" depends on ARCH_MVEBU || ARCH_DOVE || COMPILE_TEST + depends on MVEBU_MBUS depends on ARM depends on OF