| Message ID | 20180709083650.23549-10-daniel.vetter@ffwll.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Mon, Jul 09, 2018 at 10:36:48AM +0200, Daniel Vetter wrote: > Avoids the inverted condition compared to the open-coded version. > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: linux-pci@vger.kernel.org Acked-by: Bjorn Helgaas <bhelgaas@google.com> I assume you'll merge this with the rest of the series. > --- > include/linux/pci.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/pci.h b/include/linux/pci.h > index 340029b2fb38..1484471ed048 100644 > --- a/include/linux/pci.h > +++ b/include/linux/pci.h > @@ -601,7 +601,7 @@ static inline bool pci_is_bridge(struct pci_dev *dev) > > #define for_each_pci_bridge(dev, bus) \ > list_for_each_entry(dev, &bus->devices, bus_list) \ > - if (!pci_is_bridge(dev)) {} else > + for_each_if (pci_is_bridge(dev)) > > static inline struct pci_dev *pci_upstream_bridge(struct pci_dev *dev) > { > -- > 2.18.0 >
diff --git a/include/linux/pci.h b/include/linux/pci.h index 340029b2fb38..1484471ed048 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -601,7 +601,7 @@ static inline bool pci_is_bridge(struct pci_dev *dev) #define for_each_pci_bridge(dev, bus) \ list_for_each_entry(dev, &bus->devices, bus_list) \ - if (!pci_is_bridge(dev)) {} else + for_each_if (pci_is_bridge(dev)) static inline struct pci_dev *pci_upstream_bridge(struct pci_dev *dev) {
Avoids the inverted condition compared to the open-coded version. Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: linux-pci@vger.kernel.org --- include/linux/pci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)