From patchwork Sun Dec 16 23:09:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 10732619 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 69E2314E2 for ; Sun, 16 Dec 2018 23:09:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 56247298E3 for ; Sun, 16 Dec 2018 23:09:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 49D1C298E8; Sun, 16 Dec 2018 23:09:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D663C298E3 for ; Sun, 16 Dec 2018 23:09:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731020AbeLPXJp (ORCPT ); Sun, 16 Dec 2018 18:09:45 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:35042 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728203AbeLPXJo (ORCPT ); Sun, 16 Dec 2018 18:09:44 -0500 Received: by mail-pg1-f193.google.com with SMTP id s198so5185666pgs.2; Sun, 16 Dec 2018 15:09:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5Ky7pgVvvF9hLcoAABtSFG13zMfTe+6ohhmnBjH727g=; b=tGIdgDb675KcT+PZnOTanBgWwaRyRZ8akrzY/vSuOGVM6xzj5vyScaAVotj5bZpEkE FVoDtXtL3k7gKaJWHU1Wq0E21vMIcZNUIHPcWwH452UDtgxX4pkbAaFCA906Abxtu30a Db9Iti09HC0aKdfYRLmzFKM90w3eRdmmBx2fJqoBDNvKjWufckWbDUJJuwUsdDoLctMK VUz8KjXSvUV09jhFTOVucBOU8bP+6Rj/qXvMSXsKM9pPCoWVTpJsptes7aHLA8QP0EGH Yr03NV4WKX2YCp5CECk6Bjw0nNcJ5WnlmWHMrB3RGn8DpJDgdLCFxE9uF3xG/aomtjU8 GDbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5Ky7pgVvvF9hLcoAABtSFG13zMfTe+6ohhmnBjH727g=; b=XtyJ1bYzcuCde/f/dVj972ufMV/ClXSe0B++WkQiILEYzj7Hdz3OX5YzS0riui3hxz mdKxJMGwAJ+q7ZKMdTn2ZBZoTDOuIIz5bVI1wdrqHwPDqQObs6eLu4pQPSU/igTSLjyF KuWEFIsMuIi64IoRHU5GRnAXG7Se4scJ13g2Sz8CYRLRtdu84hKqJupF+DJPhsAHZogE Q/uFmN7/UwR1Zq7ZFxkQldGwaBJIrxIotao+rXq8PoLoicR83vHB52sqAEBRUc3oG5Xm kosn30ClPCf+2luNeNh3AlwHV9n7BLyIg5NCg5yO8eCvnYXtxio+uRSL0iO6L0UEAx/X z64w== X-Gm-Message-State: AA+aEWbY8MyAhcyvk/tpeALo0aiaYHUa3IDGf97F4fAcbv4aatdQM4w8 EdB1ggAtN1SoigWVv+Sagwg= X-Google-Smtp-Source: AFSGD/XZNYx2ZnQ0ULXCggr6Tfm83Im0nuTyZ09O2JjFgAMUa2UbKSPGJU0RhePW3s4ea+HzH6fobg== X-Received: by 2002:a63:1e56:: with SMTP id p22mr10128690pgm.126.1545001783805; Sun, 16 Dec 2018 15:09:43 -0800 (PST) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id d18sm13837878pfj.47.2018.12.16.15.09.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 16 Dec 2018 15:09:42 -0800 (PST) From: Andrey Smirnov To: Lorenzo Pieralisi Cc: Andrey Smirnov , Bjorn Helgaas , Fabio Estevam , Chris Healy , Lucas Stach , Leonard Crestez , "A.s. Dong" , Richard Zhu , linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: [PATCH 3/3] PCI: imx6: Make fallthrough comments more consistent Date: Sun, 16 Dec 2018 15:09:16 -0800 Message-Id: <20181216230916.22982-4-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181216230916.22982-1-andrew.smirnov@gmail.com> References: <20181216230916.22982-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Convert all fallthrough comments to say "fall through", as well as modify their placement to the point where the "break" would normally be. Cc: Bjorn Helgaas Cc: Fabio Estevam Cc: Chris Healy Cc: Lucas Stach Cc: Leonard Crestez Cc: "A.s. Dong" Cc: Richard Zhu Cc: linux-imx@nxp.com Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: linux-pci@vger.kernel.org Suggested-by: Bjorn Helgaas Signed-off-by: Andrey Smirnov --- drivers/pci/controller/dwc/pci-imx6.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index 59658577e81d..a0510e185d44 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -362,7 +362,8 @@ static void imx6_pcie_assert_core_reset(struct imx6_pcie *imx6_pcie) switch (imx6_pcie->variant) { case IMX7D: - case IMX8MQ: /* FALLTHROUGH */ + /* fall through */ + case IMX8MQ: reset_control_assert(imx6_pcie->pciephy_reset); reset_control_assert(imx6_pcie->apps_reset); break; @@ -415,7 +416,8 @@ static int imx6_pcie_enable_ref_clk(struct imx6_pcie *imx6_pcie) regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR12, IMX6SX_GPR12_PCIE_TEST_POWERDOWN, 0); break; - case IMX6QP: /* FALLTHROUGH */ + case IMX6QP: + /* fall through */ case IMX6Q: /* power up core phy and enable ref clock */ regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR1, @@ -607,7 +609,7 @@ static void imx6_pcie_init_phy(struct imx6_pcie *imx6_pcie) regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR12, IMX6SX_GPR12_PCIE_RX_EQ_MASK, IMX6SX_GPR12_PCIE_RX_EQ_2); - /* FALLTHROUGH */ + /* fall through */ default: regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR12, IMX6Q_GPR12_PCIE_CTL_2, 0 << 10); @@ -731,7 +733,8 @@ static void imx6_pcie_ltssm_enable(struct device *dev) IMX6Q_GPR12_PCIE_CTL_2); break; case IMX7D: - case IMX8MQ: /* FALLTHROUGH */ + /* fall through */ + case IMX8MQ: reset_control_deassert(imx6_pcie->apps_reset); break; } @@ -1076,7 +1079,8 @@ static int imx6_pcie_probe(struct platform_device *pdev) } break; case IMX8MQ: - case IMX7D: /* FALLTHROUGH */ + /* fall through */ + case IMX7D: imx6_pcie->pciephy_reset = devm_reset_control_get_exclusive(dev, "pciephy"); if (IS_ERR(imx6_pcie->pciephy_reset)) {