| Message ID | 20190208162414.3996-2-mr.nuke.me@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
| Series | [v1,1/3] PCI / ACPI: Do not export pci_get_hp_params() | expand |
On Fri, Feb 08, 2019 at 10:24:11AM -0600, Alexandru Gagniuc wrote: > This is only used within drivers/pci, and there is no reason to make > it available outside of the PCI core. > > Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com> Applied the whole series to pci/hotplug for v5.2, thanks! I dropped the "list" member from struct hpx_type3 because it didn't seem to be used. > --- > drivers/pci/pci-acpi.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c > index e1949f7efd9c..b25e5fa9d1c9 100644 > --- a/drivers/pci/pci-acpi.c > +++ b/drivers/pci/pci-acpi.c > @@ -366,7 +366,6 @@ int pci_get_hp_params(struct pci_dev *dev, struct hotplug_params *hpp) > } > return -ENODEV; > } > -EXPORT_SYMBOL_GPL(pci_get_hp_params); > > /** > * pciehp_is_native - Check whether a hotplug port is handled by the OS > -- > 2.19.2 >
On 4/22/19 3:58 PM, Bjorn Helgaas wrote: > On Fri, Feb 08, 2019 at 10:24:11AM -0600, Alexandru Gagniuc wrote: >> This is only used within drivers/pci, and there is no reason to make >> it available outside of the PCI core. >> >> Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com> > > Applied the whole series to pci/hotplug for v5.2, thanks! > > I dropped the "list" member from struct hpx_type3 because it didn't > seem to be used. That's a good call. That was a vestigial appendage from when I first intended to store a list of registers in memory. I'm glad we didn't end up needing a list. Alex
diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c index e1949f7efd9c..b25e5fa9d1c9 100644 --- a/drivers/pci/pci-acpi.c +++ b/drivers/pci/pci-acpi.c @@ -366,7 +366,6 @@ int pci_get_hp_params(struct pci_dev *dev, struct hotplug_params *hpp) } return -ENODEV; } -EXPORT_SYMBOL_GPL(pci_get_hp_params); /** * pciehp_is_native - Check whether a hotplug port is handled by the OS
This is only used within drivers/pci, and there is no reason to make it available outside of the PCI core. Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com> --- drivers/pci/pci-acpi.c | 1 - 1 file changed, 1 deletion(-)