From patchwork Fri Apr 19 02:58:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yue Haibing X-Patchwork-Id: 10908617 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 095F91390 for ; Fri, 19 Apr 2019 03:09:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E4BAB28D71 for ; Fri, 19 Apr 2019 03:09:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D4DFE28D75; Fri, 19 Apr 2019 03:09:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6FE9428D71 for ; Fri, 19 Apr 2019 03:09:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727190AbfDSDJc (ORCPT ); Thu, 18 Apr 2019 23:09:32 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:6646 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727158AbfDSDJc (ORCPT ); Thu, 18 Apr 2019 23:09:32 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 5AA5BE97BFE522D62D37; Fri, 19 Apr 2019 11:02:53 +0800 (CST) Received: from localhost (10.177.31.96) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.408.0; Fri, 19 Apr 2019 11:02:45 +0800 From: Yue Haibing To: , , , , , CC: , , YueHaibing Subject: [PATCH] PCI: keystone: Fix build error while only CONFIG_PCI_KEYSTONE is set Date: Fri, 19 Apr 2019 10:58:55 +0800 Message-ID: <20190419025855.40760-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.177.31.96] X-CFilter-Loop: Reflected Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: YueHaibing During randconfig builds, I occasionally run into an invalid configuration drivers/pci/controller/dwc/pci-keystone.o: In function `ks_pcie_link_up': pci-keystone.c:(.text+0x90): undefined reference to `__dw_pcie_read_dbi' pci-keystone.c:(.text+0x90): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `__dw_pcie_read_dbi' drivers/pci/controller/dwc/pci-keystone.o: In function `ks_pcie_v3_65_scan_bus': pci-keystone.c:(.text+0x4f0): undefined reference to `__dw_pcie_write_dbi' pci-keystone.c:(.text+0x4f0): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `__dw_pcie_write_dbi' while CONFIG_PCI_KEYSTONE is selected but CONFIG_PCIE_DW is not set, the building failed like this. This patch selects PCIE_DW to fix it. Reported-by: Hulk Robot Fixes: 5709114f0a97 ("PCI: keystone: Add support for PCIe EP in AM654x Platforms") Signed-off-by: YueHaibing Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig index b450ad2..641fa0f 100644 --- a/drivers/pci/controller/dwc/Kconfig +++ b/drivers/pci/controller/dwc/Kconfig @@ -105,6 +105,7 @@ config PCIE_SPEAR13XX config PCI_KEYSTONE bool "TI Keystone PCIe controller" depends on ARCH_KEYSTONE || ARCH_K3 || ((ARM || ARM64) && COMPILE_TEST) + select PCIE_DW help Say Y here if you want to enable PCI controller support on Keystone SoCs. The PCI controller on Keystone is based on DesignWare hardware