| Message ID | 20191024171228.877974-21-s.miroshnichenko@yadro.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
| Series | PCI: Allow BAR movement during hotplug | expand |
On 25/10/2019 04:12, Sergey Miroshnichenko wrote: > Add a check for the UNSET resource flag to skip the released BARs Where/why does it crash exactly? It is not extremely clear from the code. Thanks, > > CC: Alexey Kardashevskiy <aik@ozlabs.ru> > CC: Oliver O'Halloran <oohall@gmail.com> > CC: Sam Bobroff <sbobroff@linux.ibm.com> > Signed-off-by: Sergey Miroshnichenko <s.miroshnichenko@yadro.com> > --- > arch/powerpc/platforms/powernv/pci-ioda.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c > index c28d0d9b7ee0..33d5ed8c258f 100644 > --- a/arch/powerpc/platforms/powernv/pci-ioda.c > +++ b/arch/powerpc/platforms/powernv/pci-ioda.c > @@ -2976,7 +2976,8 @@ static void pnv_ioda_setup_pe_res(struct pnv_ioda_pe *pe, > int index; > int64_t rc; > > - if (!res || !res->flags || res->start > res->end) > + if (!res || !res->flags || res->start > res->end || > + (res->flags & IORESOURCE_UNSET)) > return; > > if (res->flags & IORESOURCE_IO) { >
diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c index c28d0d9b7ee0..33d5ed8c258f 100644 --- a/arch/powerpc/platforms/powernv/pci-ioda.c +++ b/arch/powerpc/platforms/powernv/pci-ioda.c @@ -2976,7 +2976,8 @@ static void pnv_ioda_setup_pe_res(struct pnv_ioda_pe *pe, int index; int64_t rc; - if (!res || !res->flags || res->start > res->end) + if (!res || !res->flags || res->start > res->end || + (res->flags & IORESOURCE_UNSET)) return; if (res->flags & IORESOURCE_IO) {
Add a check for the UNSET resource flag to skip the released BARs CC: Alexey Kardashevskiy <aik@ozlabs.ru> CC: Oliver O'Halloran <oohall@gmail.com> CC: Sam Bobroff <sbobroff@linux.ibm.com> Signed-off-by: Sergey Miroshnichenko <s.miroshnichenko@yadro.com> --- arch/powerpc/platforms/powernv/pci-ioda.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)