From patchwork Wed Nov 25 19:24:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Quinlan X-Patchwork-Id: 11932083 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MIME_HEADER_CTYPE_ONLY, SPF_HELO_NONE,SPF_PASS,T_TVD_MIME_NO_HEADERS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C9E9C71155 for ; Wed, 25 Nov 2020 19:24:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2AD81206D9 for ; Wed, 25 Nov 2020 19:24:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="fs9O/4bl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727802AbgKYTYs (ORCPT ); Wed, 25 Nov 2020 14:24:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727697AbgKYTYs (ORCPT ); Wed, 25 Nov 2020 14:24:48 -0500 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70DB6C0613D4 for ; Wed, 25 Nov 2020 11:24:48 -0800 (PST) Received: by mail-pg1-x542.google.com with SMTP id 81so3309502pgf.0 for ; Wed, 25 Nov 2020 11:24:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=eloVWZhhtrrJf25ZELrb7x7TyRu+R4fumzd+WBRNc1w=; b=fs9O/4blLbZAhPN6hO0+hrOK4YXIV+4Gu9U7vZ59GsMP5J+0PFeNfdIn1TyqDxRoea lZuoXvtY/EdJN7pGaoM5Tw5oAI27GJXkcWL+o86nfggL0x8VoRFvYDjSBDZn+v5fTkHx 800app/XzUzbfI3Ozk4S53x9wS4Wa5CNhm0mc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=eloVWZhhtrrJf25ZELrb7x7TyRu+R4fumzd+WBRNc1w=; b=j8y3PWBfa2SxWVB+IH2ss41lkOtbfKolVgPnJUzIWpLHIzBiVlUUf0MSdCvN73pxFH bAPCpZ0vR2U4zR84DS292Eu4vckaH5YQZed5dbZUBhc/WlWWdQnBxmBdKAwRvYfmKGcu 4V9MXCvXfeeklSuDe+kbZC8PZKv9FHCrz4OrFN+2aNNf9hy/NZJcIEMOarILTZrmXR9H c/9ycbx2P7qpvxsuTQ6j+fQTx1QivsdKK4mFcDTnY32dnvZCxIoJi+tSTrv90+qOQE7O N27uAaYcqwGMyb5XdAJ9CeWtp9hjZNBc8BOEmO1equMvAznIWjn7MTC7IHI64QapVemz l64g== X-Gm-Message-State: AOAM531fA2tNnoO/UkoW4jyPSehgslB2K/V1HElGYd9AT3ZC9ptwtV9l IsaNYXS5xweoraI4fWL19Amy8SkyUOsYjzoqvNn2kAyRGToysq4THWmWB4YdtJRMZx6kUfY+tIn lB35zynnL4qkzz1aTFluzcfoPz5peJB9FppSu7+9qYmxWoVkFdcvkmpnQUtHEd4XJZZn38eFGHi 6nRIpU X-Google-Smtp-Source: ABdhPJzZB+z5HZ0U9Yq+r9Hs5Zij93+M5LaBi35+NENiriad4Dzsn20S54J8IQmFMiE+G0cuFg3aVw== X-Received: by 2002:a17:90a:ba84:: with SMTP id t4mr5062420pjr.110.1606332287495; Wed, 25 Nov 2020 11:24:47 -0800 (PST) Received: from stbsrv-and-01.and.broadcom.net ([192.19.231.250]) by smtp.gmail.com with ESMTPSA id j69sm2574885pfd.37.2020.11.25.11.24.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Nov 2020 11:24:46 -0800 (PST) From: Jim Quinlan To: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com Cc: Lorenzo Pieralisi , Rob Herring , Bjorn Helgaas , Florian Fainelli , linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v1 6/6] PCI: brcmstb: check return value of clk_prepare_enable() Date: Wed, 25 Nov 2020 14:24:23 -0500 Message-Id: <20201125192424.14440-7-james.quinlan@broadcom.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201125192424.14440-1-james.quinlan@broadcom.com> References: <20201125192424.14440-1-james.quinlan@broadcom.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org The check was missing on PCIe resume. Signed-off-by: Jim Quinlan --- drivers/pci/controller/pcie-brcmstb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c index 469bbb0ebdd9..56c88d2b4f87 100644 --- a/drivers/pci/controller/pcie-brcmstb.c +++ b/drivers/pci/controller/pcie-brcmstb.c @@ -1380,7 +1380,9 @@ static int brcm_pcie_resume(struct device *dev) base = pcie->base; brcm_set_regulators(pcie, TURN_ON); - clk_prepare_enable(pcie->clk); + ret = clk_prepare_enable(pcie->clk); + if (ret) + return ret; ret = brcm_phy_start(pcie); if (ret)