From patchwork Mon Nov 30 21:11:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Quinlan X-Patchwork-Id: 11941331 X-Patchwork-Delegate: lorenzo.pieralisi@arm.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MIME_HEADER_CTYPE_ONLY, SPF_HELO_NONE,SPF_PASS,T_TVD_MIME_NO_HEADERS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 540DAC83018 for ; Mon, 30 Nov 2020 21:13:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D317C221EB for ; Mon, 30 Nov 2020 21:13:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="hzFA7DaZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388458AbgK3VNb (ORCPT ); Mon, 30 Nov 2020 16:13:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388453AbgK3VNb (ORCPT ); Mon, 30 Nov 2020 16:13:31 -0500 Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E3D6C061A4F for ; Mon, 30 Nov 2020 13:12:13 -0800 (PST) Received: by mail-pf1-x441.google.com with SMTP id n137so11253513pfd.3 for ; Mon, 30 Nov 2020 13:12:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=uoV6CQseedgQ0YFqDMvNuBydan70dhFy6EOjMZGi0D8=; b=hzFA7DaZj6GuS/VMBMDD6Gno5rYg76jEq1UH/RHJLLxw0NK3uZigmzLfXDwbijPbCg g+2TTiFWksoXIqOGfEM03KgwKltvNZ9cFAzAx/Ac4my22Q6//UdsWB4o1ZGEdlOqF+Ap WZ7M3GPRU2y6ftJZvverruWcMiD607zzTfIj0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=uoV6CQseedgQ0YFqDMvNuBydan70dhFy6EOjMZGi0D8=; b=O6o/E9DGBuaFZHYdSi9Ny+NoGTpBAuNG88euTGbREZmL10MCSyp6IY7/MuT6abY6Uw aDZTmbWu9pGRraxygFmg49ls2yVhB5T3P85i8R6HYhcrd+0PxJGlFFZe3ekrhtxFHLbi HQG8+rVyrwN3P+frcby6zn1fE44MB5QPsFuJLJos7zP7RONq9YuTkhyK+OsorLHmgQfN I1Naj9fK7KU0ulllx6S+z/qAu7H0MItT4fi4RR/pEZw0TI2uT+iBPX28d+WFlqY8GRJu uk4/I8H7LUSO+dh881UOQjKTeeEccwL/m8pe7ri8UFQnV1W/iFJw02dlQr7UtZMkGFML cr6Q== X-Gm-Message-State: AOAM531Wb/dzEvkrWhGVMFFs/+sjNmXBYiTn0P13frKrlQDVcHSTMQA+ kwtP0cG4Qq4G+lJdiOaeOd1gVZqgZpdynOd9Mz89oIhLQkWxZQ6+I2fhK1CX4j0IBkM3Q4agKG+ yUfiatGGtCa5h6XdgJCJF1pkKwGvZBCBrWt5nApL6NsT+NlD1YK34GLAN+5UPyWSLcKi7N9f5// UM8Qb+ X-Google-Smtp-Source: ABdhPJwnZhJZPf1dQz/a2JUEap4CRZ2bjRrjB7x9Fvg3sOSBstb1+LUHlYAkvj2a9XGY/mKZYYyMOw== X-Received: by 2002:a63:6dca:: with SMTP id i193mr13821834pgc.89.1606770732570; Mon, 30 Nov 2020 13:12:12 -0800 (PST) Received: from stbsrv-and-01.and.broadcom.net ([192.19.231.250]) by smtp.gmail.com with ESMTPSA id m7sm18320441pfh.72.2020.11.30.13.12.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Nov 2020 13:12:11 -0800 (PST) From: Jim Quinlan To: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , broonie@kernel.org, bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com Cc: Lorenzo Pieralisi , Rob Herring , Bjorn Helgaas , Florian Fainelli , linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 6/6] PCI: brcmstb: check return value of clk_prepare_enable() Date: Mon, 30 Nov 2020 16:11:43 -0500 Message-Id: <20201130211145.3012-7-james.quinlan@broadcom.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201130211145.3012-1-james.quinlan@broadcom.com> References: <20201130211145.3012-1-james.quinlan@broadcom.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org The check was missing on PCIe resume. Signed-off-by: Jim Quinlan Acked-by: Florian Fainelli --- drivers/pci/controller/pcie-brcmstb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c index 3983d6c80769..64cf534e44d0 100644 --- a/drivers/pci/controller/pcie-brcmstb.c +++ b/drivers/pci/controller/pcie-brcmstb.c @@ -1344,7 +1344,9 @@ static int brcm_pcie_resume(struct device *dev) base = pcie->base; brcm_set_regulators(pcie, TURN_ON); - clk_prepare_enable(pcie->clk); + ret = clk_prepare_enable(pcie->clk); + if (ret) + return ret; ret = brcm_phy_start(pcie); if (ret)