| Message ID | 20210324030510.29177-3-jianjun.wang@mediatek.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Lorenzo Pieralisi |
| Headers | show |
| Series | PCI: mediatek: Add new generation controller support | expand |
On Wednesday 24 March 2021 11:05:05 Jianjun Wang wrote: > This interface will be used by PCI host drivers for PIO translation, > export it to support compiling those drivers as kernel modules. > > Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com> > --- > drivers/pci/pci.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index 16a17215f633..12bba221c9f2 100644 > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -4052,6 +4052,7 @@ phys_addr_t pci_pio_to_address(unsigned long pio) > > return address; > } > +EXPORT_SYMBOL(pci_pio_to_address); Hello! I'm not sure if EXPORT_SYMBOL is correct because file has GPL-2.0 header. Should not be in this case used only EXPORT_SYMBOL_GPL? Maybe other people would know what is correct? > > unsigned long __weak pci_address_to_pio(phys_addr_t address) > { > -- > 2.25.1 >
On Wed, Mar 24, 2021 at 10:09:42AM +0100, Pali Rohár wrote: > On Wednesday 24 March 2021 11:05:05 Jianjun Wang wrote: > > This interface will be used by PCI host drivers for PIO translation, > > export it to support compiling those drivers as kernel modules. > > > > Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com> > > --- > > drivers/pci/pci.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > > index 16a17215f633..12bba221c9f2 100644 > > --- a/drivers/pci/pci.c > > +++ b/drivers/pci/pci.c > > @@ -4052,6 +4052,7 @@ phys_addr_t pci_pio_to_address(unsigned long pio) > > > > return address; > > } > > +EXPORT_SYMBOL(pci_pio_to_address); > > Hello! I'm not sure if EXPORT_SYMBOL is correct because file has GPL-2.0 > header. Should not be in this case used only EXPORT_SYMBOL_GPL? Maybe > other people would know what is correct? I think this should be EXPORT_SYMBOL_GPL(), I can make this change but this requires Bjorn's ACK to go upstream (Bjorn, it is my fault, it was assigned to me on patchwork, now updated, please have a look). Thanks, Lorenzo > > > > unsigned long __weak pci_address_to_pio(phys_addr_t address) > > { > > -- > > 2.25.1 > >
On Tue, Apr 13, 2021 at 10:53:05AM +0100, Lorenzo Pieralisi wrote: > On Wed, Mar 24, 2021 at 10:09:42AM +0100, Pali Rohár wrote: > > On Wednesday 24 March 2021 11:05:05 Jianjun Wang wrote: > > > This interface will be used by PCI host drivers for PIO translation, > > > export it to support compiling those drivers as kernel modules. > > > > > > Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com> > > > --- > > > drivers/pci/pci.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > > > index 16a17215f633..12bba221c9f2 100644 > > > --- a/drivers/pci/pci.c > > > +++ b/drivers/pci/pci.c > > > @@ -4052,6 +4052,7 @@ phys_addr_t pci_pio_to_address(unsigned long pio) > > > > > > return address; > > > } > > > +EXPORT_SYMBOL(pci_pio_to_address); > > > > Hello! I'm not sure if EXPORT_SYMBOL is correct because file has GPL-2.0 > > header. Should not be in this case used only EXPORT_SYMBOL_GPL? Maybe > > other people would know what is correct? > > I think this should be EXPORT_SYMBOL_GPL(), I can make this change > but this requires Bjorn's ACK to go upstream (Bjorn, it is my fault, > it was assigned to me on patchwork, now updated, please have a look). Yep, looks good to me, and I agree it should be EXPORT_SYMBOL_GPL(). Acked-by: Bjorn Helgaas <bhelgaas@google.com> > > > > > > unsigned long __weak pci_address_to_pio(phys_addr_t address) > > > { > > > -- > > > 2.25.1 > > >
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 16a17215f633..12bba221c9f2 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -4052,6 +4052,7 @@ phys_addr_t pci_pio_to_address(unsigned long pio) return address; } +EXPORT_SYMBOL(pci_pio_to_address); unsigned long __weak pci_address_to_pio(phys_addr_t address) {
This interface will be used by PCI host drivers for PIO translation, export it to support compiling those drivers as kernel modules. Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com> --- drivers/pci/pci.c | 1 + 1 file changed, 1 insertion(+)