| Message ID | 20210510023032.3063932-1-kw@linux.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Lorenzo Pieralisi |
| Headers | show |
| Series | PCI: mobiveil: Remove unused readl and writel functions | expand |
On Mon, 10 May 2021 02:30:32 +0000, Krzysztof Wilczyński wrote: > The PCIe host controller driver for Layerscape 4th generation SoC was > added in the commit d29ad70a813b ("PCI: mobiveil: Add PCIe Gen4 RC > driver for Layerscape SoCs"). > > At this time two static functions were introduced that appear to > currently have no users. Since nothing is using neither of these > functions at the moment they can be safely removed. > > [...] Applied to pci/mobiveil, thanks! [1/1] PCI: mobiveil: Remove unused readl and writel functions https://git.kernel.org/lpieralisi/pci/c/42d7a8dc19 Thanks, Lorenzo
diff --git a/drivers/pci/controller/mobiveil/pcie-layerscape-gen4.c b/drivers/pci/controller/mobiveil/pcie-layerscape-gen4.c index ee0156921ebc..306950272fd6 100644 --- a/drivers/pci/controller/mobiveil/pcie-layerscape-gen4.c +++ b/drivers/pci/controller/mobiveil/pcie-layerscape-gen4.c @@ -42,17 +42,6 @@ struct ls_pcie_g4 { int irq; }; -static inline u32 ls_pcie_g4_lut_readl(struct ls_pcie_g4 *pcie, u32 off) -{ - return ioread32(pcie->pci.csr_axi_slave_base + PCIE_LUT_OFF + off); -} - -static inline void ls_pcie_g4_lut_writel(struct ls_pcie_g4 *pcie, - u32 off, u32 val) -{ - iowrite32(val, pcie->pci.csr_axi_slave_base + PCIE_LUT_OFF + off); -} - static inline u32 ls_pcie_g4_pf_readl(struct ls_pcie_g4 *pcie, u32 off) { return ioread32(pcie->pci.csr_axi_slave_base + PCIE_PF_OFF + off);
The PCIe host controller driver for Layerscape 4th generation SoC was added in the commit d29ad70a813b ("PCI: mobiveil: Add PCIe Gen4 RC driver for Layerscape SoCs"). At this time two static functions were introduced that appear to currently have no users. Since nothing is using neither of these functions at the moment they can be safely removed. This resolves the following build time warnings: drivers/pci/controller/mobiveil/pcie-layerscape-gen4.c:45:19: warning: unused function 'ls_pcie_g4_lut_readl' [-Wunused-function] drivers/pci/controller/mobiveil/pcie-layerscape-gen4.c:50:20: warning: unused function 'ls_pcie_g4_lut_writel' [-Wunused-function] Signed-off-by: Krzysztof Wilczyński <kw@linux.com> --- .../pci/controller/mobiveil/pcie-layerscape-gen4.c | 11 ----------- 1 file changed, 11 deletions(-)