| Message ID | 20211003025439.84783-1-kw@linux.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Lorenzo Pieralisi |
| Headers | show |
| Series | PCI: imx6: Remove unused assignment to variable ret | expand |
On Sun, 3 Oct 2021 02:54:39 +0000, Krzysztof Wilczyński wrote: > Previously, the maximum link speed was set following an "fsl,max-link-speed" > property read, and should the read failed, then the PCIe generation was > manually set to PCIe Gen1 and thus limiting the link speed to 2.5 GT/s. > > Code refactoring completed in the commit 39bc5006501c ("PCI: dwc: > Centralize link gen setting") changed to the logic that was previously > used to limit the maximum link speed leaving behind an unused assignment > to a variable "ret". > > [...] Applied to pci/imx6, thanks! [1/1] PCI: imx6: Remove unused assignment to variable ret https://git.kernel.org/lpieralisi/pci/c/65315ec52c Thanks, Lorenzo
diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index 80fc98acf097..26f49f797b0f 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -1132,7 +1132,7 @@ static int imx6_pcie_probe(struct platform_device *pdev) /* Limit link speed */ pci->link_gen = 1; - ret = of_property_read_u32(node, "fsl,max-link-speed", &pci->link_gen); + of_property_read_u32(node, "fsl,max-link-speed", &pci->link_gen); imx6_pcie->vpcie = devm_regulator_get_optional(&pdev->dev, "vpcie"); if (IS_ERR(imx6_pcie->vpcie)) {
Previously, the maximum link speed was set following an "fsl,max-link-speed" property read, and should the read failed, then the PCIe generation was manually set to PCIe Gen1 and thus limiting the link speed to 2.5 GT/s. Code refactoring completed in the commit 39bc5006501c ("PCI: dwc: Centralize link gen setting") changed to the logic that was previously used to limit the maximum link speed leaving behind an unused assignment to a variable "ret". Since the value returned from the of_property_read_u32() and stored in the variable "ret" is never used in any meaningful way, and it's also immediately reassigned in the code that follows, the assignment can be removed. Signed-off-by: Krzysztof Wilczyński <kw@linux.com> --- drivers/pci/controller/dwc/pci-imx6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)