diff mbox series

[next] PCI: apple: Remove redundant initialization of pointer port_pdev

Message ID 20211012133235.260534-1-colin.king@canonical.com (mailing list archive)
State Accepted
Delegated to: Lorenzo Pieralisi
Headers show
Series [next] PCI: apple: Remove redundant initialization of pointer port_pdev | expand

Commit Message

Colin King Oct. 12, 2021, 1:32 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

The pointer port_pdev is being initialized with a value that is never
read, it is being updated later on. The assignment is redundant and
can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/pci/controller/pcie-apple.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alyssa Rosenzweig Oct. 12, 2021, 3:02 p.m. UTC | #1 
It looks like 

        port_pdev = pcie_find_root_port(pdev);

might've meant to read

        port_pdev = pcie_find_root_port(port_pdev);

in which case the assignment would be used. I have no strong opinions
either way.

Full context for those following along at home:

```
static struct apple_pcie_port *apple_pcie_get_port(struct pci_dev *pdev)
{
        struct pci_config_window *cfg = pdev->sysdata;
        struct apple_pcie *pcie = cfg->priv;
        struct pci_dev *port_pdev = pdev;
        struct apple_pcie_port *port;

        /* Find the root port this device is on */
        port_pdev = pcie_find_root_port(pdev);

        /* If finding the port itself, nothing to do */
        if (WARN_ON(!port_pdev) || pdev == port_pdev)
                return NULL;

        list_for_each_entry(port, &pcie->ports, entry) {
                if (port->idx == PCI_SLOT(port_pdev->devfn))
                        return port;
        }

        return NULL;
}
```

On Tue, Oct 12, 2021 at 02:32:35PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The pointer port_pdev is being initialized with a value that is never
> read, it is being updated later on. The assignment is redundant and
> can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/pci/controller/pcie-apple.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c
> index b4db7a065553..19fd2d38aaab 100644
> --- a/drivers/pci/controller/pcie-apple.c
> +++ b/drivers/pci/controller/pcie-apple.c
> @@ -634,7 +634,7 @@ static struct apple_pcie_port *apple_pcie_get_port(struct pci_dev *pdev)
>  {
>  	struct pci_config_window *cfg = pdev->sysdata;
>  	struct apple_pcie *pcie = cfg->priv;
> -	struct pci_dev *port_pdev = pdev;
> +	struct pci_dev *port_pdev;
>  	struct apple_pcie_port *port;
>  
>  	/* Find the root port this device is on */
> -- 
> 2.32.0
>
Krzysztof Wilczyński Oct. 13, 2021, 12:47 a.m. UTC | #2 
Hi Colin!

> The pointer port_pdev is being initialized with a value that is never
> read, it is being updated later on. The assignment is redundant and
> can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/pci/controller/pcie-apple.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c
> index b4db7a065553..19fd2d38aaab 100644
> --- a/drivers/pci/controller/pcie-apple.c
> +++ b/drivers/pci/controller/pcie-apple.c
> @@ -634,7 +634,7 @@ static struct apple_pcie_port *apple_pcie_get_port(struct pci_dev *pdev)
>  {
>  	struct pci_config_window *cfg = pdev->sysdata;
>  	struct apple_pcie *pcie = cfg->priv;
> -	struct pci_dev *port_pdev = pdev;
> +	struct pci_dev *port_pdev;

Thank you!

Reviewed-by: Krzysztof Wilczyński <kw@linux.com>

	Krzysztof
Lorenzo Pieralisi Oct. 13, 2021, 1:41 p.m. UTC | #3 
On Tue, Oct 12, 2021 at 02:32:35PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The pointer port_pdev is being initialized with a value that is never
> read, it is being updated later on. The assignment is redundant and
> can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/pci/controller/pcie-apple.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Squashed into the commit it is fixing.

Thanks !
Lorenzo

> diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c
> index b4db7a065553..19fd2d38aaab 100644
> --- a/drivers/pci/controller/pcie-apple.c
> +++ b/drivers/pci/controller/pcie-apple.c
> @@ -634,7 +634,7 @@ static struct apple_pcie_port *apple_pcie_get_port(struct pci_dev *pdev)
>  {
>  	struct pci_config_window *cfg = pdev->sysdata;
>  	struct apple_pcie *pcie = cfg->priv;
> -	struct pci_dev *port_pdev = pdev;
> +	struct pci_dev *port_pdev;
>  	struct apple_pcie_port *port;
>  
>  	/* Find the root port this device is on */
> -- 
> 2.32.0
>
Alyssa Rosenzweig Oct. 13, 2021, 2:06 p.m. UTC | #4 
Hi Lorenzo,

> > The pointer port_pdev is being initialized with a value that is never
> > read, it is being updated later on. The assignment is redundant and
> > can be removed.
> > 
> > Addresses-Coverity: ("Unused value")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> >  drivers/pci/controller/pcie-apple.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Squashed into the commit it is fixing.

It seems the commit already landed in linux-next? [1]

[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=00723f494020aceb92f789af634fecba1477fc01

Alyssa
Lorenzo Pieralisi Oct. 13, 2021, 2:14 p.m. UTC | #5 
On Wed, Oct 13, 2021 at 10:06:20AM -0400, Alyssa Rosenzweig wrote:
> Hi Lorenzo,
> 
> > > The pointer port_pdev is being initialized with a value that is never
> > > read, it is being updated later on. The assignment is redundant and
> > > can be removed.
> > > 
> > > Addresses-Coverity: ("Unused value")
> > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > > ---
> > >  drivers/pci/controller/pcie-apple.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > Squashed into the commit it is fixing.
> 
> It seems the commit already landed in linux-next? [1]
> 
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=00723f494020aceb92f789af634fecba1477fc01

I know thanks. The updated one will land in next shortly.

Lorenzo
Colin King Oct. 13, 2021, 2:22 p.m. UTC | #6 
On 13/10/2021 14:41, Lorenzo Pieralisi wrote:
> On Tue, Oct 12, 2021 at 02:32:35PM +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The pointer port_pdev is being initialized with a value that is never
>> read, it is being updated later on. The assignment is redundant and
>> can be removed.
>>
>> Addresses-Coverity: ("Unused value")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>>   drivers/pci/controller/pcie-apple.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Squashed into the commit it is fixing.
> 

Thanks. Much appreciated.

> Thanks !
> Lorenzo
> 
>> diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c
>> index b4db7a065553..19fd2d38aaab 100644
>> --- a/drivers/pci/controller/pcie-apple.c
>> +++ b/drivers/pci/controller/pcie-apple.c
>> @@ -634,7 +634,7 @@ static struct apple_pcie_port *apple_pcie_get_port(struct pci_dev *pdev)
>>   {
>>   	struct pci_config_window *cfg = pdev->sysdata;
>>   	struct apple_pcie *pcie = cfg->priv;
>> -	struct pci_dev *port_pdev = pdev;
>> +	struct pci_dev *port_pdev;
>>   	struct apple_pcie_port *port;
>>   
>>   	/* Find the root port this device is on */
>> -- 
>> 2.32.0
>>
diff mbox series

Patch

diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c
index b4db7a065553..19fd2d38aaab 100644
--- a/drivers/pci/controller/pcie-apple.c
+++ b/drivers/pci/controller/pcie-apple.c
@@ -634,7 +634,7 @@  static struct apple_pcie_port *apple_pcie_get_port(struct pci_dev *pdev)
 {
 	struct pci_config_window *cfg = pdev->sysdata;
 	struct apple_pcie *pcie = cfg->priv;
-	struct pci_dev *port_pdev = pdev;
+	struct pci_dev *port_pdev;
 	struct apple_pcie_port *port;
 
 	/* Find the root port this device is on */