| Message ID | 20211223011054.1227810-17-helgaas@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Lorenzo Pieralisi |
| Headers | show |
| Series | PCI: Name structs, functions consistently | expand |
Hi Bjorn, On Thu, Dec 23, 2021 at 2:11 AM Bjorn Helgaas <helgaas@kernel.org> wrote: > > From: Bjorn Helgaas <bhelgaas@google.com> > > mt7621_pci_ops is used only in this file. Make it static. > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > Cc: Sergio Paracuellos <sergio.paracuellos@gmail.com> > Cc: Matthias Brugger <matthias.bgg@gmail.com> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-mediatek@lists.infradead.org > --- > drivers/pci/controller/pcie-mt7621.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/pcie-mt7621.c b/drivers/pci/controller/pcie-mt7621.c > index b60dfb45ef7b..4138c0e83513 100644 > --- a/drivers/pci/controller/pcie-mt7621.c > +++ b/drivers/pci/controller/pcie-mt7621.c > @@ -148,7 +148,7 @@ static void __iomem *mt7621_pcie_map_bus(struct pci_bus *bus, > return pcie->base + RALINK_PCI_CONFIG_DATA + (where & 3); > } > > -struct pci_ops mt7621_pci_ops = { > +static struct pci_ops mt7621_pci_ops = { > .map_bus = mt7621_pcie_map_bus, > .read = pci_generic_config_read, > .write = pci_generic_config_write, > -- > 2.25.1 > This one was already sent and added to Lorenzo's tree. See: https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git/commit/?h=pci/mt7621&id=8a0c1afb8560c2f64bcbdb559931f5ca8b83de87 Thanks, Sergio Paracuellos
On Thu, Dec 23, 2021 at 07:04:32AM +0100, Sergio Paracuellos wrote: > Hi Bjorn, > > On Thu, Dec 23, 2021 at 2:11 AM Bjorn Helgaas <helgaas@kernel.org> wrote: > > > > From: Bjorn Helgaas <bhelgaas@google.com> > > > > mt7621_pci_ops is used only in this file. Make it static. > > > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > > Cc: Sergio Paracuellos <sergio.paracuellos@gmail.com> > > Cc: Matthias Brugger <matthias.bgg@gmail.com> > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-mediatek@lists.infradead.org > > --- > > drivers/pci/controller/pcie-mt7621.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/pci/controller/pcie-mt7621.c b/drivers/pci/controller/pcie-mt7621.c > > index b60dfb45ef7b..4138c0e83513 100644 > > --- a/drivers/pci/controller/pcie-mt7621.c > > +++ b/drivers/pci/controller/pcie-mt7621.c > > @@ -148,7 +148,7 @@ static void __iomem *mt7621_pcie_map_bus(struct pci_bus *bus, > > return pcie->base + RALINK_PCI_CONFIG_DATA + (where & 3); > > } > > > > -struct pci_ops mt7621_pci_ops = { > > +static struct pci_ops mt7621_pci_ops = { > > .map_bus = mt7621_pcie_map_bus, > > .read = pci_generic_config_read, > > .write = pci_generic_config_write, > > -- > > 2.25.1 > > > > This one was already sent and added to Lorenzo's tree. See: > > https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git/commit/?h=pci/mt7621&id=8a0c1afb8560c2f64bcbdb559931f5ca8b83de87 Thanks, I dropped this one. Bjorn
diff --git a/drivers/pci/controller/pcie-mt7621.c b/drivers/pci/controller/pcie-mt7621.c index b60dfb45ef7b..4138c0e83513 100644 --- a/drivers/pci/controller/pcie-mt7621.c +++ b/drivers/pci/controller/pcie-mt7621.c @@ -148,7 +148,7 @@ static void __iomem *mt7621_pcie_map_bus(struct pci_bus *bus, return pcie->base + RALINK_PCI_CONFIG_DATA + (where & 3); } -struct pci_ops mt7621_pci_ops = { +static struct pci_ops mt7621_pci_ops = { .map_bus = mt7621_pcie_map_bus, .read = pci_generic_config_read, .write = pci_generic_config_write,