| Message ID | 20220226213703.24041-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2a8b7b24b85080f565408e5c118c451fc634dc77 |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
| Series | [-next?] x86: PCI: asm/pci_x86.h needs more #includes | expand |
On Sat, Feb 26, 2022 at 01:37:03PM -0800, Randy Dunlap wrote: > <asm/pci_x86.h> uses EINVAL, __init, and raw_spinlock_t, so it > should #include the appropriate files to prevent build errors. > > ../arch/x86/include/asm/pci_x86.h:150:10: error: ‘EINVAL’ undeclared (first use in this function) > return -EINVAL; > > ../arch/x86/include/asm/pci_x86.h:105:8: error: unknown type name ‘raw_spinlock_t’ > extern raw_spinlock_t pci_config_lock; > > ../arch/x86/include/asm/pci_x86.h:141:20: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘dmi_check_pciprobe’ > extern void __init dmi_check_pciprobe(void); > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Thanks, applied to pci/misc for v5.18. > Cc: Mark Brown <broonie@kernel.org> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Ingo Molnar <mingo@redhat.com> > Cc: Borislav Petkov <bp@alien8.de> > Cc: Dave Hansen <dave.hansen@linux.intel.com> > Cc: x86@kernel.org > Cc: linux-pci@vger.kernel.org > --- > Without this patch, I am seeing *many* build errors in > linux-next-20220225. > > I don't know why this showed up in linux-next-20220225 all of a > sudden. > > arch/x86/include/asm/pci_x86.h | 3 +++ > 1 file changed, 3 insertions(+) > > --- linux-next-20220225.orig/arch/x86/include/asm/pci_x86.h > +++ linux-next-20220225/arch/x86/include/asm/pci_x86.h > @@ -5,7 +5,10 @@ > * (c) 1999 Martin Mares <mj@ucw.cz> > */ > > +#include <linux/errno.h> > +#include <linux/init.h> > #include <linux/ioport.h> > +#include <linux/spinlock.h> > > #undef DEBUG >
--- linux-next-20220225.orig/arch/x86/include/asm/pci_x86.h +++ linux-next-20220225/arch/x86/include/asm/pci_x86.h @@ -5,7 +5,10 @@ * (c) 1999 Martin Mares <mj@ucw.cz> */ +#include <linux/errno.h> +#include <linux/init.h> #include <linux/ioport.h> +#include <linux/spinlock.h> #undef DEBUG
<asm/pci_x86.h> uses EINVAL, __init, and raw_spinlock_t, so it should #include the appropriate files to prevent build errors. ../arch/x86/include/asm/pci_x86.h:150:10: error: ‘EINVAL’ undeclared (first use in this function) return -EINVAL; ../arch/x86/include/asm/pci_x86.h:105:8: error: unknown type name ‘raw_spinlock_t’ extern raw_spinlock_t pci_config_lock; ../arch/x86/include/asm/pci_x86.h:141:20: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘dmi_check_pciprobe’ extern void __init dmi_check_pciprobe(void); Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Mark Brown <broonie@kernel.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@redhat.com> Cc: Borislav Petkov <bp@alien8.de> Cc: Dave Hansen <dave.hansen@linux.intel.com> Cc: x86@kernel.org Cc: linux-pci@vger.kernel.org --- Without this patch, I am seeing *many* build errors in linux-next-20220225. I don't know why this showed up in linux-next-20220225 all of a sudden. arch/x86/include/asm/pci_x86.h | 3 +++ 1 file changed, 3 insertions(+)