| Message ID | 20220416135458.104048-3-linux@fw-web.de (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Lorenzo Pieralisi |
| Headers | show |
| Series | RK3568 PCIe V3 support | expand |
On 16/04/2022 15:54, Frank Wunderlich wrote: > From: Frank Wunderlich <frank-w@public-files.de> > > Add compatibles for PCIe v3 General Register Files. > > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> > --- > Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > index 3be3cfd52f7b..ae48b58bd062 100644 > --- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > @@ -14,6 +14,8 @@ properties: > oneOf: > - items: > - enum: > + - rockchip,pcie30-phy-grf > + - rockchip,pcie30-pipe-grf These are without SoC parts. Are these PCIe v3 General Register Files part of some PCIe spec? > - rockchip,rk3288-sgrf > - rockchip,rk3566-pipe-grf > - rockchip,rk3568-usb2phy-grf Best regards, Krzysztof
> Gesendet: Montag, 18. April 2022 um 17:54 Uhr > Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org> > > --- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > > +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > > @@ -14,6 +14,8 @@ properties: > > oneOf: > > - items: > > - enum: > > + - rockchip,pcie30-phy-grf > > + - rockchip,pcie30-pipe-grf > > These are without SoC parts. Are these PCIe v3 General Register Files > part of some PCIe spec? imho they are shared across SoCs rk3568 and rk3588, but have only seen rk3568 implementation yet. PCIe driver currently supports these 2 Soc (different offsets in the Phy-GRF), but can only test rk3568. pipe-grf seems only be used for rk35688 (offset used in probe is defined for this SoC), which i cannot test. so i have left them SoC independed. > > - rockchip,rk3288-sgrf > > - rockchip,rk3566-pipe-grf > > - rockchip,rk3568-usb2phy-grf regards Frank
On 19/04/2022 19:29, Frank Wunderlich wrote: >> Gesendet: Montag, 18. April 2022 um 17:54 Uhr >> Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org> > >>> --- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml >>> +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml >>> @@ -14,6 +14,8 @@ properties: >>> oneOf: >>> - items: >>> - enum: >>> + - rockchip,pcie30-phy-grf >>> + - rockchip,pcie30-pipe-grf >> >> These are without SoC parts. Are these PCIe v3 General Register Files >> part of some PCIe spec? > > imho they are shared across SoCs rk3568 and rk3588, but have only seen rk3568 implementation yet. > PCIe driver currently supports these 2 Soc (different offsets in the Phy-GRF), but can only test rk3568. > > pipe-grf seems only be used for rk35688 (offset used in probe is defined for this SoC), which i cannot test. > > so i have left them SoC independed. Compatibles should be SoC dependent, with some exceptions. Lack of documentation or lack of possibility of testing is actually argument against any exception, so they should be SoC specific/dependent. Best regards, Krzysztof
> Gesendet: Dienstag, 19. April 2022 um 21:40 Uhr > Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org> > On 19/04/2022 19:29, Frank Wunderlich wrote: > >> Gesendet: Montag, 18. April 2022 um 17:54 Uhr > >> Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org> > > > >>> --- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > >>> +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > >>> @@ -14,6 +14,8 @@ properties: > >>> oneOf: > >>> - items: > >>> - enum: > >>> + - rockchip,pcie30-phy-grf > >>> + - rockchip,pcie30-pipe-grf > >> > >> These are without SoC parts. Are these PCIe v3 General Register Files > >> part of some PCIe spec? > > > > imho they are shared across SoCs rk3568 and rk3588, but have only seen rk3568 implementation yet. > > PCIe driver currently supports these 2 Soc (different offsets in the Phy-GRF), but can only test rk3568. > > > > pipe-grf seems only be used for rk35688 (offset used in probe is defined for this SoC), which i cannot test. > > > > so i have left them SoC independed. > > Compatibles should be SoC dependent, with some exceptions. Lack of > documentation or lack of possibility of testing is actually argument > against any exception, so they should be SoC specific/dependent. so i will change to - rockchip,rk3568-pcie30-phy-grf - rockchip,rk3588-pcie30-pipe-grf and maybe add - rockchip,rk3588-pcie30-phy-grf these compatibles are not directly taken by any driver as the nodes be linked via phandle (rockchip,phy-grf property) from the phy driver (rockchip,rk3568-pcie3-phy / rockchip,rk3588-pcie3-phy). So these compatibles are only in the yaml and dts present. regards Frank
diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml index 3be3cfd52f7b..ae48b58bd062 100644 --- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml @@ -14,6 +14,8 @@ properties: oneOf: - items: - enum: + - rockchip,pcie30-phy-grf + - rockchip,pcie30-pipe-grf - rockchip,rk3288-sgrf - rockchip,rk3566-pipe-grf - rockchip,rk3568-usb2phy-grf