| Message ID | 20220422120850.769480-4-herve.codina@bootlin.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | RZN1 USB Host support | expand |
On Fri, Apr 22, 2022 at 02:08:45PM +0200, Herve Codina wrote: > Add Renesas RZ/N1 SOCs family support to the Renesas R-Car > gen2 PCI bridge driver. > The Renesas RZ/N1 SOCs internal PCI bridge is comptible with > the one available in the R-Car Gen2 family. > Tested with the RZ/N1D (R9A06G032) SOC. Nits (only address if you have some other reason to repost this series): - Subject claims this adds "support," which suggests that this adds some piece of new functionality. But it adds no new functionality, it merely adds a new compatible string. I would say "Add RZ/N1 SOC compatible string" - Add blank lines between paragraphs - Rewrap paragraphs to fill 75 characters - s/comptible/compatible/ - s/R-Car gen2/R-Car Gen2/ to write this consistently instead of capitalizing "Gen2" sometimes but not others > Signed-off-by: Herve Codina <herve.codina@bootlin.com> > --- > drivers/pci/controller/pci-rcar-gen2.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/pci-rcar-gen2.c b/drivers/pci/controller/pci-rcar-gen2.c > index 35804ea394fd..839695791757 100644 > --- a/drivers/pci/controller/pci-rcar-gen2.c > +++ b/drivers/pci/controller/pci-rcar-gen2.c > @@ -328,6 +328,7 @@ static const struct of_device_id rcar_pci_of_match[] = { > { .compatible = "renesas,pci-r8a7791", }, > { .compatible = "renesas,pci-r8a7794", }, > { .compatible = "renesas,pci-rcar-gen2", }, > + { .compatible = "renesas,pci-rzn1", }, > { }, > }; > > -- > 2.35.1 >
Hi Bjorn, On Fri, 22 Apr 2022 11:47:44 -0500 Bjorn Helgaas <helgaas@kernel.org> wrote: > On Fri, Apr 22, 2022 at 02:08:45PM +0200, Herve Codina wrote: > > Add Renesas RZ/N1 SOCs family support to the Renesas R-Car > > gen2 PCI bridge driver. > > The Renesas RZ/N1 SOCs internal PCI bridge is comptible with > > the one available in the R-Car Gen2 family. > > Tested with the RZ/N1D (R9A06G032) SOC. > > Nits (only address if you have some other reason to repost this > series): > > - Subject claims this adds "support," which suggests that this adds > some piece of new functionality. But it adds no new > functionality, it merely adds a new compatible string. I would > say "Add RZ/N1 SOC compatible string" > > - Add blank lines between paragraphs > > - Rewrap paragraphs to fill 75 characters > > - s/comptible/compatible/ > > - s/R-Car gen2/R-Car Gen2/ to write this consistently instead of > capitalizing "Gen2" sometimes but not others I plan a v4 and so, I will take these points into account. Thanks for the review. Regards, Hervé
diff --git a/drivers/pci/controller/pci-rcar-gen2.c b/drivers/pci/controller/pci-rcar-gen2.c index 35804ea394fd..839695791757 100644 --- a/drivers/pci/controller/pci-rcar-gen2.c +++ b/drivers/pci/controller/pci-rcar-gen2.c @@ -328,6 +328,7 @@ static const struct of_device_id rcar_pci_of_match[] = { { .compatible = "renesas,pci-r8a7791", }, { .compatible = "renesas,pci-r8a7794", }, { .compatible = "renesas,pci-rcar-gen2", }, + { .compatible = "renesas,pci-rzn1", }, { }, };
Add Renesas RZ/N1 SOCs family support to the Renesas R-Car gen2 PCI bridge driver. The Renesas RZ/N1 SOCs internal PCI bridge is comptible with the one available in the R-Car Gen2 family. Tested with the RZ/N1D (R9A06G032) SOC. Signed-off-by: Herve Codina <herve.codina@bootlin.com> --- drivers/pci/controller/pci-rcar-gen2.c | 1 + 1 file changed, 1 insertion(+)