| Message ID | 20220531215815.2408477-1-robh@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | fe3f70eec425af77f3ea9818d8fe43a4b524bc7c |
| Headers | show |
| Series | [v2] dt-bindings: PCI: apple: Add missing 'power-domains' property | expand |
> On 31. May 2022, at 23:58, Rob Herring <robh@kernel.org> wrote: > > The 'unevaluatedProperties' schema checks is not fully working and doesn't > catch some cases where there's a $ref to another schema. A fix is pending, > but results in new warnings in examples. > > The Apple PCIe host schema is missing 'power-domains' in the schema. > The example has 3 power domains. However, this is wrong too as actual > dts files have a single power domain and Sven confirmed 1 is correct. > > Cc: Sven Peter <sven@svenpeter.dev> > Signed-off-by: Rob Herring <robh@kernel.org> Reviewed-by: Sven Peter <sven@svenpeter.dev>
On Tue, 31 May 2022 16:58:14 -0500, Rob Herring wrote: > The 'unevaluatedProperties' schema checks is not fully working and doesn't > catch some cases where there's a $ref to another schema. A fix is pending, > but results in new warnings in examples. > > The Apple PCIe host schema is missing 'power-domains' in the schema. > The example has 3 power domains. However, this is wrong too as actual > dts files have a single power domain and Sven confirmed 1 is correct. > > Cc: Sven Peter <sven@svenpeter.dev> > Signed-off-by: Rob Herring <robh@kernel.org> > --- > v2: > - Correct the power-domains to be 1 and update the example > --- > Documentation/devicetree/bindings/pci/apple,pcie.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > Applied, thanks!
diff --git a/Documentation/devicetree/bindings/pci/apple,pcie.yaml b/Documentation/devicetree/bindings/pci/apple,pcie.yaml index daf602ac0d0f..aa38680aaaca 100644 --- a/Documentation/devicetree/bindings/pci/apple,pcie.yaml +++ b/Documentation/devicetree/bindings/pci/apple,pcie.yaml @@ -68,6 +68,9 @@ properties: iommu-map: true iommu-map-mask: true + power-domains: + maxItems: 1 + required: - compatible - reg @@ -134,7 +137,7 @@ examples: ranges = <0x43000000 0x6 0xa0000000 0x6 0xa0000000 0x0 0x20000000>, <0x02000000 0x0 0xc0000000 0x6 0xc0000000 0x0 0x40000000>; - power-domains = <&ps_apcie>, <&ps_apcie_gp>, <&ps_pcie_ref>; + power-domains = <&ps_apcie_gp>; pinctrl-0 = <&pcie_pins>; pinctrl-names = "default";
The 'unevaluatedProperties' schema checks is not fully working and doesn't catch some cases where there's a $ref to another schema. A fix is pending, but results in new warnings in examples. The Apple PCIe host schema is missing 'power-domains' in the schema. The example has 3 power domains. However, this is wrong too as actual dts files have a single power domain and Sven confirmed 1 is correct. Cc: Sven Peter <sven@svenpeter.dev> Signed-off-by: Rob Herring <robh@kernel.org> --- v2: - Correct the power-domains to be 1 and update the example --- Documentation/devicetree/bindings/pci/apple,pcie.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)