| Message ID | 20220819231415.3860210-2-mail@conchuod.ie (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Fix RISC-V/PCI dt-schema issues with dt-schema v2022.08 | expand |
On Sat, 20 Aug 2022 00:14:10 +0100, Conor Dooley wrote: > From: Conor Dooley <conor.dooley@microchip.com> > > The commit b92225b034c0 ("dt-bindings: PCI: designware: Fix > 'unevaluatedProperties' warnings") removed the clock-names property as > a requirement and from the example as it triggered unevaluatedProperty > warnings. dtbs_check was not able to pick up on this at the time, but > now can: > > arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dtb: pcie@e00000000: Unevaluated properties are not allowed ('clock-names' was unexpected) > From schema: linux/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml > > The property was already in use by the FU740 DTS and the clock must be > enabled. The Linux and FreeBSD drivers require the property to enable > the clocks correctly Re-add the property and its "clocks" dependency, > while making it required. > > Fixes: b92225b034c0 ("dt-bindings: PCI: designware: Fix 'unevaluatedProperties' warnings") > Fixes: 43cea116be0b ("dt-bindings: PCI: Add SiFive FU740 PCIe host controller") > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > --- > v2022.08 of dt-schema is required. > --- > .../devicetree/bindings/pci/sifive,fu740-pcie.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
On Mon, Aug 22, 2022 at 02:20:32PM -0500, Rob Herring wrote: > On Sat, 20 Aug 2022 00:14:10 +0100, Conor Dooley wrote: > > From: Conor Dooley <conor.dooley@microchip.com> > > > > The commit b92225b034c0 ("dt-bindings: PCI: designware: Fix > > 'unevaluatedProperties' warnings") removed the clock-names property as > > a requirement and from the example as it triggered unevaluatedProperty > > warnings. dtbs_check was not able to pick up on this at the time, but > > now can: > > > > arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dtb: pcie@e00000000: Unevaluated properties are not allowed ('clock-names' was unexpected) > > From schema: linux/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml > > > > The property was already in use by the FU740 DTS and the clock must be > > enabled. The Linux and FreeBSD drivers require the property to enable > > the clocks correctly Re-add the property and its "clocks" dependency, > > while making it required. > > > > Fixes: b92225b034c0 ("dt-bindings: PCI: designware: Fix 'unevaluatedProperties' warnings") > > Fixes: 43cea116be0b ("dt-bindings: PCI: Add SiFive FU740 PCIe host controller") > > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > > --- > > v2022.08 of dt-schema is required. > > --- > > .../devicetree/bindings/pci/sifive,fu740-pcie.yaml | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > Reviewed-by: Rob Herring <robh@kernel.org> Should I pick these bindings updates up ? Lorenzo
On 23/08/2022 08:43, Lorenzo Pieralisi wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Mon, Aug 22, 2022 at 02:20:32PM -0500, Rob Herring wrote: >> On Sat, 20 Aug 2022 00:14:10 +0100, Conor Dooley wrote: >>> From: Conor Dooley <conor.dooley@microchip.com> >>> >>> The commit b92225b034c0 ("dt-bindings: PCI: designware: Fix >>> 'unevaluatedProperties' warnings") removed the clock-names property as >>> a requirement and from the example as it triggered unevaluatedProperty >>> warnings. dtbs_check was not able to pick up on this at the time, but >>> now can: >>> >>> arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dtb: pcie@e00000000: Unevaluated properties are not allowed ('clock-names' was unexpected) >>> From schema: linux/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml >>> >>> The property was already in use by the FU740 DTS and the clock must be >>> enabled. The Linux and FreeBSD drivers require the property to enable >>> the clocks correctly Re-add the property and its "clocks" dependency, >>> while making it required. >>> >>> Fixes: b92225b034c0 ("dt-bindings: PCI: designware: Fix 'unevaluatedProperties' warnings") >>> Fixes: 43cea116be0b ("dt-bindings: PCI: Add SiFive FU740 PCIe host controller") >>> Signed-off-by: Conor Dooley <conor.dooley@microchip.com> >>> --- >>> v2022.08 of dt-schema is required. >>> --- >>> .../devicetree/bindings/pci/sifive,fu740-pcie.yaml | 8 ++++++++ >>> 1 file changed, 8 insertions(+) >>> >> >> Reviewed-by: Rob Herring <robh@kernel.org> > > Should I pick these bindings updates up ? It was my expectation anyway that you would take the binding patches. They're marked "not applicable" in the dt patchwork so appear that Rob does not want to take them. Won't speak for him though! I intend to take the dts part of the series through riscv's fixes as the series will get the arch down to zero dtbs_check warnings. Could you take the patches through the PCI fixes tree please? Thanks, Conor.
diff --git a/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml b/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml index 195e6afeb169..844fc7142302 100644 --- a/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml @@ -51,6 +51,12 @@ properties: description: A phandle to the PCIe power up reset line. maxItems: 1 + clocks: + maxItems: 1 + + clock-names: + const: pcie_aux + pwren-gpios: description: Should specify the GPIO for controlling the PCI bus device power on. maxItems: 1 @@ -66,6 +72,7 @@ required: - interrupt-map-mask - interrupt-map - clocks + - clock-names - resets - pwren-gpios - reset-gpios @@ -104,6 +111,7 @@ examples: <0x0 0x0 0x0 0x2 &plic0 58>, <0x0 0x0 0x0 0x3 &plic0 59>, <0x0 0x0 0x0 0x4 &plic0 60>; + clock-names = "pcie_aux"; clocks = <&prci FU740_PRCI_CLK_PCIE_AUX>; resets = <&prci 4>; pwren-gpios = <&gpio 5 0>;