| Message ID | 20220901152324.29654-1-jesper.nilsson@axis.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
| Series | PCI: Map PCI bios specific error to generic errno | expand |
diff --git a/drivers/pci/of.c b/drivers/pci/of.c index 196834ed44fe..130bcfe61e04 100644 --- a/drivers/pci/of.c +++ b/drivers/pci/of.c @@ -440,8 +440,10 @@ static int of_irq_parse_pci(const struct pci_dev *pdev, struct of_phandle_args * * for PCI. If you do different, then don't use that routine. */ rc = pci_read_config_byte(pdev, PCI_INTERRUPT_PIN, &pin); - if (rc != 0) + if (rc != 0) { + rc = pcibios_err_to_errno(rc); goto err; + } /* No pin, exit with no error message. */ if (pin == 0) return -ENODEV;
pci_read_config_byte() may return a PCI bios specific error value (in my case PCIBIOS_DEVICE_NOT_FOUND 0x86) which is nonsensical to return to the caller of of_irq_parse_pci() which expects a negative errno if something goes wrong. Use the appropriate mapping function before passing the error on. Signed-off-by: Jesper Nilsson <jesper.nilsson@axis.com> --- drivers/pci/of.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)