| Message ID | 20230317112019.9090-1-johan+linaro@kernel.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Krzysztof Wilczyński |
| Headers | show |
| Series | dt-bindings: PCI: Fix unit address of example root port | expand |
On Fri, 17 Mar 2023 12:20:19 +0100, Johan Hovold wrote: > Fix the unit address of the example root port which is identical to the > device number (i.e. 1). > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- > Documentation/devicetree/bindings/pci/pci.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Rob Herring <robh@kernel.org>
On Fri, Mar 17, 2023 at 12:20:19PM +0100, Johan Hovold wrote: > Fix the unit address of the example root port which is identical to the > device number (i.e. 1). > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- This one hasn't showed up in linux-next yet. Could you pick it up for 6.4, Lorenzo? > Documentation/devicetree/bindings/pci/pci.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pci/pci.txt b/Documentation/devicetree/bindings/pci/pci.txt > index 6a8f2874a24d..8b7c52436558 100644 > --- a/Documentation/devicetree/bindings/pci/pci.txt > +++ b/Documentation/devicetree/bindings/pci/pci.txt > @@ -76,7 +76,7 @@ Example: > pcie@10000000 { > compatible = "pci-host-ecam-generic"; > ... > - pcie@0008 { > + pcie@1 { > /* Root port 00:01.0 is external-facing */ > reg = <0x00000800 0 0 0 0>; > external-facing; Johan
On Wed, Apr 5, 2023 at 6:19 AM Johan Hovold <johan@kernel.org> wrote: > > On Fri, Mar 17, 2023 at 12:20:19PM +0100, Johan Hovold wrote: > > Fix the unit address of the example root port which is identical to the > > device number (i.e. 1). > > > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > > --- > > This one hasn't showed up in linux-next yet. Could you pick it up for > 6.4, Lorenzo? On 2nd thought, I think it's time to just remove this file. The schema is just missing some descriptions and 1 property (external-facing). I've added all that here[1]. I didn't add the example to the schema because the example here is incomplete and won't validate. Rob [1] https://github.com/robherring/dt-schema/commit/8445eb010e61496681e2504faf400e9fbc5b1acf
On Wed, Apr 05, 2023 at 08:38:29AM -0500, Rob Herring wrote: > On Wed, Apr 5, 2023 at 6:19 AM Johan Hovold <johan@kernel.org> wrote: > > > > On Fri, Mar 17, 2023 at 12:20:19PM +0100, Johan Hovold wrote: > > > Fix the unit address of the example root port which is identical to the > > > device number (i.e. 1). > > > > > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > > > --- > > > > This one hasn't showed up in linux-next yet. Could you pick it up for > > 6.4, Lorenzo? > > On 2nd thought, I think it's time to just remove this file. The schema > is just missing some descriptions and 1 property (external-facing). > I've added all that here[1]. Sounds good to me. Will you send a patch? > I didn't add the example to the schema because the example here is > incomplete and won't validate. Fair enough. Having a decent example in the tree would be helpful, but hopefully we can get the in-tree DT sources up to par at some point so that they can serve that purpose. Johan > [1] https://github.com/robherring/dt-schema/commit/8445eb010e61496681e2504faf400e9fbc5b1acf
diff --git a/Documentation/devicetree/bindings/pci/pci.txt b/Documentation/devicetree/bindings/pci/pci.txt index 6a8f2874a24d..8b7c52436558 100644 --- a/Documentation/devicetree/bindings/pci/pci.txt +++ b/Documentation/devicetree/bindings/pci/pci.txt @@ -76,7 +76,7 @@ Example: pcie@10000000 { compatible = "pci-host-ecam-generic"; ... - pcie@0008 { + pcie@1 { /* Root port 00:01.0 is external-facing */ reg = <0x00000800 0 0 0 0>; external-facing;
Fix the unit address of the example root port which is identical to the device number (i.e. 1). Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- Documentation/devicetree/bindings/pci/pci.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)