| Message ID | 20230607204750.27837-1-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Krzysztof Wilczyński |
| Headers | show |
| Series | [v2] PCI: rcar: use proper naming for R-Car | expand |
On Wed, Jun 7, 2023 at 10:49 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > Neither RCar, nor Rcar, but R-Car. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > > Change since V1: > * fix typo in $subject (Thanks, Biju!) Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
Hello Wolfram-san, > From: Wolfram Sang, Sent: Thursday, June 8, 2023 5:48 AM > > Neither RCar, nor Rcar, but R-Car. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Thank you for the patch! Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Best regards, Yoshihiro Shimoda > --- > > Change since V1: > * fix typo in $subject (Thanks, Biju!) > > drivers/pci/controller/pcie-rcar-host.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/controller/pcie-rcar-host.c b/drivers/pci/controller/pcie-rcar-host.c > index e80e56b2a842..f4dac8ff97cb 100644 > --- a/drivers/pci/controller/pcie-rcar-host.c > +++ b/drivers/pci/controller/pcie-rcar-host.c > @@ -684,7 +684,7 @@ static void rcar_compose_msi_msg(struct irq_data *data, struct msi_msg *msg) > } > > static struct irq_chip rcar_msi_bottom_chip = { > - .name = "Rcar MSI", > + .name = "R-Car MSI", > .irq_ack = rcar_msi_irq_ack, > .irq_mask = rcar_msi_irq_mask, > .irq_unmask = rcar_msi_irq_unmask, > @@ -813,7 +813,7 @@ static int rcar_pcie_enable_msi(struct rcar_pcie_host *host) > > /* > * Setup MSI data target using RC base address address, which > - * is guaranteed to be in the low 32bit range on any RCar HW. > + * is guaranteed to be in the low 32bit range on any R-Car HW. > */ > rcar_pci_write_reg(pcie, lower_32_bits(res.start) | MSIFE, PCIEMSIALR); > rcar_pci_write_reg(pcie, upper_32_bits(res.start), PCIEMSIAUR); > -- > 2.35.1
Hello,
> Neither RCar, nor Rcar, but R-Car.
Applied to controller/rcar, thank you!
[1/1] PCI: rcar: Use correct product family name for Renesas R-Car
https://git.kernel.org/pci/pci/c/e28e75e9f589
Krzysztof
Hello,
> > Neither RCar, nor Rcar, but R-Car.
There might be one more variance left to correct:
drivers/gpu/drm/rcar-du/rcar_du_plane.h:
18-/*
19: * The RCAR DU has 8 hardware planes, shared between primary and overlay planes.
20- * As using overlay planes requires at least one of the CRTCs being enabled, no
21- * more than 7 overlay planes can be available. We thus create 1 primary plane
22- * per CRTC and 7 overlay planes, for a total of up to 9 KMS planes.
23- */
For the sake of completeness.
Krzysztof
On Tue, Jun 27, 2023 at 12:45:37AM +0900, Krzysztof Wilczyński wrote: > Hello, > > > > Neither RCar, nor Rcar, but R-Car. > > There might be one more variance left to correct: You are right, thank you, I will fix it, too.
diff --git a/drivers/pci/controller/pcie-rcar-host.c b/drivers/pci/controller/pcie-rcar-host.c index e80e56b2a842..f4dac8ff97cb 100644 --- a/drivers/pci/controller/pcie-rcar-host.c +++ b/drivers/pci/controller/pcie-rcar-host.c @@ -684,7 +684,7 @@ static void rcar_compose_msi_msg(struct irq_data *data, struct msi_msg *msg) } static struct irq_chip rcar_msi_bottom_chip = { - .name = "Rcar MSI", + .name = "R-Car MSI", .irq_ack = rcar_msi_irq_ack, .irq_mask = rcar_msi_irq_mask, .irq_unmask = rcar_msi_irq_unmask, @@ -813,7 +813,7 @@ static int rcar_pcie_enable_msi(struct rcar_pcie_host *host) /* * Setup MSI data target using RC base address address, which - * is guaranteed to be in the low 32bit range on any RCar HW. + * is guaranteed to be in the low 32bit range on any R-Car HW. */ rcar_pci_write_reg(pcie, lower_32_bits(res.start) | MSIFE, PCIEMSIALR); rcar_pci_write_reg(pcie, upper_32_bits(res.start), PCIEMSIAUR);
Neither RCar, nor Rcar, but R-Car. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- Change since V1: * fix typo in $subject (Thanks, Biju!) drivers/pci/controller/pcie-rcar-host.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)