| Message ID | 20230609112417.632313-1-suijingfeng@loongson.cn (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
| Series | [v5,1/4] PCI/VGA: Use unsigned type for the io_state variable | expand |
Hi Sui, On Fri, Jun 09, 2023 at 07:24:14PM +0800, Sui Jingfeng wrote: > The io_state variable in the vga_arb_write() function is declared with > unsigned int type, while the vga_str_to_iostate() function takes int * > type. To keep them consistent, replace the third argument of > vga_str_to_iostate() function with the unsigned int * type. > > Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Andi > --- > drivers/pci/vgaarb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/vgaarb.c b/drivers/pci/vgaarb.c > index 5a696078b382..c1bc6c983932 100644 > --- a/drivers/pci/vgaarb.c > +++ b/drivers/pci/vgaarb.c > @@ -77,7 +77,7 @@ static const char *vga_iostate_to_str(unsigned int iostate) > return "none"; > } > > -static int vga_str_to_iostate(char *buf, int str_size, int *io_state) > +static int vga_str_to_iostate(char *buf, int str_size, unsigned int *io_state) > { > /* we could in theory hand out locks on IO and mem > * separately to userspace but it can cause deadlocks */ > -- > 2.25.1
Hi, On 2023/6/9 19:48, Andi Shyti wrote: > Hi Sui, > > On Fri, Jun 09, 2023 at 07:24:14PM +0800, Sui Jingfeng wrote: >> The io_state variable in the vga_arb_write() function is declared with >> unsigned int type, while the vga_str_to_iostate() function takes int * >> type. To keep them consistent, replace the third argument of >> vga_str_to_iostate() function with the unsigned int * type. >> >> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn> > Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Thanks a lot. > Andi > >> --- >> drivers/pci/vgaarb.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/pci/vgaarb.c b/drivers/pci/vgaarb.c >> index 5a696078b382..c1bc6c983932 100644 >> --- a/drivers/pci/vgaarb.c >> +++ b/drivers/pci/vgaarb.c >> @@ -77,7 +77,7 @@ static const char *vga_iostate_to_str(unsigned int iostate) >> return "none"; >> } >> >> -static int vga_str_to_iostate(char *buf, int str_size, int *io_state) >> +static int vga_str_to_iostate(char *buf, int str_size, unsigned int *io_state) >> { >> /* we could in theory hand out locks on IO and mem >> * separately to userspace but it can cause deadlocks */ >> -- >> 2.25.1
diff --git a/drivers/pci/vgaarb.c b/drivers/pci/vgaarb.c index 5a696078b382..c1bc6c983932 100644 --- a/drivers/pci/vgaarb.c +++ b/drivers/pci/vgaarb.c @@ -77,7 +77,7 @@ static const char *vga_iostate_to_str(unsigned int iostate) return "none"; } -static int vga_str_to_iostate(char *buf, int str_size, int *io_state) +static int vga_str_to_iostate(char *buf, int str_size, unsigned int *io_state) { /* we could in theory hand out locks on IO and mem * separately to userspace but it can cause deadlocks */
The io_state variable in the vga_arb_write() function is declared with unsigned int type, while the vga_str_to_iostate() function takes int * type. To keep them consistent, replace the third argument of vga_str_to_iostate() function with the unsigned int * type. Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn> --- drivers/pci/vgaarb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)