| Message ID | 20240129-x1e80100-pci-v2-2-5751ab805483@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | PCI: qcom: Add PCIe support for X1E80100 | expand |
On Mon, Jan 29, 2024 at 04:41:20PM +0200, Abel Vesa wrote: > Add the compatible and the driver data for X1E80100. > If you happen to respin the series, please add info about the PCIe controller found on this SoC. Like IP version, Gen speed, max. link width etc... > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> - Mani > --- > drivers/pci/controller/dwc/pcie-qcom.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > index 10f2d0bb86be..2a6000e457bc 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom.c > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > @@ -1642,6 +1642,7 @@ static const struct of_device_id qcom_pcie_match[] = { > { .compatible = "qcom,pcie-sm8450-pcie0", .data = &cfg_1_9_0 }, > { .compatible = "qcom,pcie-sm8450-pcie1", .data = &cfg_1_9_0 }, > { .compatible = "qcom,pcie-sm8550", .data = &cfg_1_9_0 }, > + { .compatible = "qcom,pcie-x1e80100", .data = &cfg_1_9_0 }, > { } > }; > > > -- > 2.34.1 >
On Tue, Jan 30, 2024 at 12:25:06PM +0530, Manivannan Sadhasivam wrote: > On Mon, Jan 29, 2024 at 04:41:20PM +0200, Abel Vesa wrote: > > Add the compatible and the driver data for X1E80100. > > If you happen to respin the series, please add info about the PCIe controller > found on this SoC. Like IP version, Gen speed, max. link width etc... FWIW, I always prefer actual speeds, e.g., "8 GT/s", instead of things like "Gen3", for the reason mentioned in the spec: Terms like "PCIe Gen3" are ambiguous and should be avoided. For example, "gen3" could mean (1) compliant with Base 3.0, (2) compliant with Base 3.1 (last revision of 3.x), (3) compliant with Base 3.0 and supporting 8.0 GT/s, (4) compliant with Base 3.0 or later and supporting 8.0 GT/s, .... Bjorn
On Tue, Jan 30, 2024 at 12:00:40PM -0600, Bjorn Helgaas wrote: > On Tue, Jan 30, 2024 at 12:25:06PM +0530, Manivannan Sadhasivam wrote: > > On Mon, Jan 29, 2024 at 04:41:20PM +0200, Abel Vesa wrote: > > > Add the compatible and the driver data for X1E80100. > > > > If you happen to respin the series, please add info about the PCIe controller > > found on this SoC. Like IP version, Gen speed, max. link width etc... > > FWIW, I always prefer actual speeds, e.g., "8 GT/s", instead of things > like "Gen3", for the reason mentioned in the spec: > > Terms like "PCIe Gen3" are ambiguous and should be avoided. For > example, "gen3" could mean (1) compliant with Base 3.0, (2) > compliant with Base 3.1 (last revision of 3.x), (3) compliant with > Base 3.0 and supporting 8.0 GT/s, (4) compliant with Base 3.0 or > later and supporting 8.0 GT/s, .... > Makes sense. Will keep a note of it, thanks! - Mani
diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c index 10f2d0bb86be..2a6000e457bc 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -1642,6 +1642,7 @@ static const struct of_device_id qcom_pcie_match[] = { { .compatible = "qcom,pcie-sm8450-pcie0", .data = &cfg_1_9_0 }, { .compatible = "qcom,pcie-sm8450-pcie1", .data = &cfg_1_9_0 }, { .compatible = "qcom,pcie-sm8550", .data = &cfg_1_9_0 }, + { .compatible = "qcom,pcie-x1e80100", .data = &cfg_1_9_0 }, { } };
Add the compatible and the driver data for X1E80100. Signed-off-by: Abel Vesa <abel.vesa@linaro.org> --- drivers/pci/controller/dwc/pcie-qcom.c | 1 + 1 file changed, 1 insertion(+)