| Message ID | 20240313105804.100168-4-cassel@kernel.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | PCI: endpoint: set prefetchable bit for 64-bit BARs | expand |
On Wed, Mar 13, 2024 at 11:57:55AM +0100, Niklas Cassel wrote: > The pci-epf-test does no special configuration at all, it simply requests > a 64-bit BAR if the hardware requires it. However, this flag is now > automatically set when allocating a BAR that can only be a 64-bit BAR, > so we can drop pci_epf_configure_bar() completely. > > Signed-off-by: Niklas Cassel <cassel@kernel.org> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> - Mani > --- > drivers/pci/endpoint/functions/pci-epf-test.c | 14 -------------- > 1 file changed, 14 deletions(-) > > diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c > index 8c9802b9b835..7dc9704128dc 100644 > --- a/drivers/pci/endpoint/functions/pci-epf-test.c > +++ b/drivers/pci/endpoint/functions/pci-epf-test.c > @@ -877,19 +877,6 @@ static int pci_epf_test_alloc_space(struct pci_epf *epf) > return 0; > } > > -static void pci_epf_configure_bar(struct pci_epf *epf, > - const struct pci_epc_features *epc_features) > -{ > - struct pci_epf_bar *epf_bar; > - int i; > - > - for (i = 0; i < PCI_STD_NUM_BARS; i++) { > - epf_bar = &epf->bar[i]; > - if (epc_features->bar[i].only_64bit) > - epf_bar->flags |= PCI_BASE_ADDRESS_MEM_TYPE_64; > - } > -} > - > static int pci_epf_test_bind(struct pci_epf *epf) > { > int ret; > @@ -914,7 +901,6 @@ static int pci_epf_test_bind(struct pci_epf *epf) > test_reg_bar = pci_epc_get_first_free_bar(epc_features); > if (test_reg_bar < 0) > return -EINVAL; > - pci_epf_configure_bar(epf, epc_features); > > epf_test->test_reg_bar = test_reg_bar; > epf_test->epc_features = epc_features; > -- > 2.44.0 >
diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c index 8c9802b9b835..7dc9704128dc 100644 --- a/drivers/pci/endpoint/functions/pci-epf-test.c +++ b/drivers/pci/endpoint/functions/pci-epf-test.c @@ -877,19 +877,6 @@ static int pci_epf_test_alloc_space(struct pci_epf *epf) return 0; } -static void pci_epf_configure_bar(struct pci_epf *epf, - const struct pci_epc_features *epc_features) -{ - struct pci_epf_bar *epf_bar; - int i; - - for (i = 0; i < PCI_STD_NUM_BARS; i++) { - epf_bar = &epf->bar[i]; - if (epc_features->bar[i].only_64bit) - epf_bar->flags |= PCI_BASE_ADDRESS_MEM_TYPE_64; - } -} - static int pci_epf_test_bind(struct pci_epf *epf) { int ret; @@ -914,7 +901,6 @@ static int pci_epf_test_bind(struct pci_epf *epf) test_reg_bar = pci_epc_get_first_free_bar(epc_features); if (test_reg_bar < 0) return -EINVAL; - pci_epf_configure_bar(epf, epc_features); epf_test->test_reg_bar = test_reg_bar; epf_test->epc_features = epc_features;
The pci-epf-test does no special configuration at all, it simply requests a 64-bit BAR if the hardware requires it. However, this flag is now automatically set when allocating a BAR that can only be a 64-bit BAR, so we can drop pci_epf_configure_bar() completely. Signed-off-by: Niklas Cassel <cassel@kernel.org> --- drivers/pci/endpoint/functions/pci-epf-test.c | 14 -------------- 1 file changed, 14 deletions(-)