diff mbox series

[v2,6/7] Revert "x86/apic/msi: Enable PCI/IMS"

Message ID 20240410221307.2162676-7-helgaas@kernel.org (mailing list archive)
State Accepted
Commit 73d9acd8c45f1c318383b22cd4a4557b15d3f551
Delegated to: Bjorn Helgaas
Headers show
Series PCI/MSI: Remove IMS (Interrupt Message Store) support for now | expand

Commit Message

Bjorn Helgaas April 10, 2024, 10:13 p.m. UTC 
From: Bjorn Helgaas <bhelgaas@google.com>

This reverts commit 6e24c887732901140f4e82ba2315c2e15f06f1d6.

IMS (Interrupt Message Store) support appeared in v6.2, but there are no
users yet.

Remove it for now.  We can add it back when a user comes along.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
 arch/x86/kernel/apic/msi.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Tian, Kevin April 11, 2024, 5:13 a.m. UTC | #1 
> From: Bjorn Helgaas <helgaas@kernel.org>
> Sent: Thursday, April 11, 2024 6:13 AM
> 
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> This reverts commit 6e24c887732901140f4e82ba2315c2e15f06f1d6.
> 
> IMS (Interrupt Message Store) support appeared in v6.2, but there are no
> users yet.
> 
> Remove it for now.  We can add it back when a user comes along.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

Reviewed-by: Kevin Tian <kevin.tian@intel.com>
diff mbox series

Patch

diff --git a/arch/x86/kernel/apic/msi.c b/arch/x86/kernel/apic/msi.c
index d9651f15ae4f..340769242dea 100644
--- a/arch/x86/kernel/apic/msi.c
+++ b/arch/x86/kernel/apic/msi.c
@@ -184,7 +184,6 @@  static int x86_msi_prepare(struct irq_domain *domain, struct device *dev,
 		alloc->type = X86_IRQ_ALLOC_TYPE_PCI_MSI;
 		return 0;
 	case DOMAIN_BUS_PCI_DEVICE_MSIX:
-	case DOMAIN_BUS_PCI_DEVICE_IMS:
 		alloc->type = X86_IRQ_ALLOC_TYPE_PCI_MSIX;
 		return 0;
 	default:
@@ -229,10 +228,6 @@  static bool x86_init_dev_msi_info(struct device *dev, struct irq_domain *domain,
 	case DOMAIN_BUS_PCI_DEVICE_MSI:
 	case DOMAIN_BUS_PCI_DEVICE_MSIX:
 		break;
-	case DOMAIN_BUS_PCI_DEVICE_IMS:
-		if (!(pops->supported_flags & MSI_FLAG_PCI_IMS))
-			return false;
-		break;
 	default:
 		WARN_ON_ONCE(1);
 		return false;