From patchwork Tue May 28 19:39:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13677229 X-Patchwork-Delegate: kw@linux.com Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2071.outbound.protection.outlook.com [40.107.21.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FF5717BB07; Tue, 28 May 2024 19:40:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.21.71 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716925207; cv=fail; b=Cv4buc7CdVZUs0rRPMftYXhVEnxs7E57yh8f6ggn3MKDyPqWZQjHv1q1KCV894f3dRx3dUpB49tPL+JE042qXOT+fTbMGmjtFF41STFBb1sFC0Ug0i9uHb0qvDLxp+n9teqbvDO0NLdCRtgf/3UxV68xnAH7NasznKVuIiGMoAM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716925207; c=relaxed/simple; bh=8xOc8FHVDA5CYg4ysfXUDK0s+odx3UuJLqh5Cmr2E2M=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=PFw3YpE0pEFC4OVnPrsW2ZNgfpfW8bpEwvo1G/slLYQJ+BgRyk3E0aGtj8bNOHxtpgaWoIaQhk4h6HTFtb2E4r9aVNhg0Pu6wL//nyT3bEm43jNMxNrrmIF6IjW1470kWpUQprWGF7NDKDHn7MgTiRws5zOPAPqVeFBYzwPE0Vk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b=l5wwo/lw; arc=fail smtp.client-ip=40.107.21.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="l5wwo/lw" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fXXe6d6mVPiAISQIfqPuCHXgumL//7EFDkQ5QlI6ANUEIFuplwxIIJr78yk8oCVe1P2erSaFgGx5W1GMGyX8da30c52UaPuSmIfgkplnGUzReT8pf4O8pw87gF7Ub3Jqtmkl1laI8F8WYtuArNdM2yBXjM4ArKLkVgfM30mrHmHTG47tanLRO/Pdm8n4WJpCjR0sjn7CEGhRZl2ptpk8xdyP5GNgIDtK/oUUiZTm7e5QSFnjXCisnjaJZrcwO20AQdQasMbifLb8rSNpWPtaY6TrElndLifZ5q9Py63aYkxwTP/bdVVPcA7KSxmACtnkUQttDvEMT1k1LxG1vm6SAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0M9WIgOQl4llIMpW1aAUyGhkZhEC+Fe2S4zElR+oQH4=; b=fX+2qevUZTVeNkyQHu+954ym4TZFNS3zGw+FFre+d7iNIyby4Xsrh1++O3D7FQh+QJCrMmA5clEHaxYpqSrg5ir/WQ0yS3ZjrJouZb6dUdNGSlyCKV8KhIQ1J4Ej8+g8Z+HicGn8cpjuLtO/SID+zSCFINb4XdkTrwuysxCtBVyAn8R02JtB+yWVG4ErhAEoI/b7oZyqUOOwlVwFa2/lekvg6w5tUhQuZ/Dn5qsQHHKwRaSNc2vQbeK4bHoebo5CVJPYinCapkJ1XMBSCiRg8PzRaoRShuy5tdiNA1pWFWs/BcycXXfyYScS1rcBed0QZgOi+SjVbZu+cDtl9LT2qw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0M9WIgOQl4llIMpW1aAUyGhkZhEC+Fe2S4zElR+oQH4=; b=l5wwo/lwpRAM+156in7bfpjWHomt6EQQVXq90UOYCsGOSHxtT/1GVT7p0TNYjnz8PLW48GANhJ7T2ZEMmwfI9Tma1S1IO5lftAQMjhsUHKFY2lPJJMMw2jKfTu+m01OH8WxxonG+XIjtQtjAH2HqABxB/Bgk9yPQJSjBHYd5QaI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by PAXPR04MB8655.eurprd04.prod.outlook.com (2603:10a6:102:21e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.30; Tue, 28 May 2024 19:40:01 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.7611.016; Tue, 28 May 2024 19:40:01 +0000 From: Frank Li Date: Tue, 28 May 2024 15:39:19 -0400 Subject: [PATCH v5 06/12] PCI: imx6: Improve comment for workaround ERR010728 Message-Id: <20240528-pci2_upstream-v5-6-750aa7edb8e2@nxp.com> References: <20240528-pci2_upstream-v5-0-750aa7edb8e2@nxp.com> In-Reply-To: <20240528-pci2_upstream-v5-0-750aa7edb8e2@nxp.com> To: Richard Zhu , Lucas Stach , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy?= =?utf-8?q?=C5=84ski?= , Rob Herring , Bjorn Helgaas , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Philipp Zabel , Liam Girdwood , Mark Brown , Manivannan Sadhasivam , Krzysztof Kozlowski , Conor Dooley Cc: linux-pci@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, devicetree@vger.kernel.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1716925161; l=1779; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=8xOc8FHVDA5CYg4ysfXUDK0s+odx3UuJLqh5Cmr2E2M=; b=QJZ6JJZw+iCIa2mgfIFRpS8hV4kH/8cpSYH3EcOuAOFnJXzcbPqQjw6Fm+W8j8cx1XHxfp/kz Npf7iy0FkYKDZnAoUvNE+eYkZ+Iu3t/3tWG1BYffA89B8TlIHyFyXPG X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BYAPR05CA0021.namprd05.prod.outlook.com (2603:10b6:a03:c0::34) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|PAXPR04MB8655:EE_ X-MS-Office365-Filtering-Correlation-Id: 67a2e174-b692-4404-ba16-08dc7f4df6f4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|376005|52116005|7416005|1800799015|366007|921011|38350700005; X-Microsoft-Antispam-Message-Info: =?utf-8?q?MQEpnOnsPtgxdMZATKHc1dVEPX9rjYG?= =?utf-8?q?VtVlk0JNH+4/AsTrTNXT0gzIO0m3yTLice4FLU14aMDSBi4utAn1DDG18rjnhuPlQ?= =?utf-8?q?Kl1z+nVevhcYH94UHXjdgiQka/M8krIfc075wecMO1FIWAtzFXUGbn7V4LocLymvi?= =?utf-8?q?yx9F6235EiXsiesbtuQl/8FQOh4q0/3CzaM6YrjKALIpDd9MwZqAp0RwtPhI+0nKb?= =?utf-8?q?EzsimYBrm3PtZB3DKmSwEyYayzcCnZeUFH5aZl6VESVvozr1rj7q4fO5GZTFZxODz?= =?utf-8?q?a297Lqjt9Kz8r5UeMBoLDrLmyRI9De1HorVANtYnCcaH4Gc6m2Su8cqVQUc5QcTPM?= =?utf-8?q?tctTV345gI8jvlAhlRoc7NlFgGGQe9xwkJOD2UiFz69P8L74vqrETTm/4k/Vq4Bqo?= =?utf-8?q?6093FYBMgaXMRf7dObNnengCQ21zg1BAEHZEIshkdPJm0AOU9PqVnQeBt9dSWlkan?= =?utf-8?q?/0vp2zVKgC0my8wbgYM97hkq73KBboWFEXZ3q8fgF8EYCY21L3xxmuzg68L1UypuT?= =?utf-8?q?XojKU7xOwglqfcDQwlIuj+mGtduKewqwExgp+qypCg0miZsN0PCVQA8VFQjSoXI1l?= =?utf-8?q?OIQoQLI5KZ6+n+cWHrhCI9MiIS0mddavM+OHLnyT5Av6NqUNDdBMyrVp+ATOsOWf9?= =?utf-8?q?kLW28EDTiqgofQtNNO5ox3dt/oFCBsDhMTol7Pu3TCBUnko4MlmEFtqfgNWWiq2Eu?= =?utf-8?q?D80kst6JSH6vqwxvZBhBeIW+hM5rpsCC/tuletR4QgzzTIIp1OHSm3Vb6nXC8vmsp?= =?utf-8?q?UcpfNYTwEzHvPQT837CdCgaXG9nHOYdxwnqaq2WZ7kx/EscSAQwR4w60TSk+9AWTZ?= =?utf-8?q?HmqclK9ZYYXspLB5NE1qdrQESPSzBznLABYB8P/y24XNXqI8kS5gnsBbCwfSfMNyN?= =?utf-8?q?yzg8DolaFLexTtCbwHAc+R0FgKJjREA5ATqa2pY65/K97XzHttBxdLqpdGIzzSEUs?= =?utf-8?q?6Rz8tov9/7KSLX5FhCnl9T3u1vAWADv7SGJ3StBL0+CKvIf1Fx/FkDpYl+Xjdi/5h?= =?utf-8?q?wpkHIlS661Xry12UetEW9SsNys9TxrujgzPDiMqLunjo0St4sL0sE4X5Xd5xUrMQD?= =?utf-8?q?yQr+XYcYvO/eC7vnNpPCe2EDHDUvlPa6xG3cggtFVneSqvuamhZeXkqol4nikEE+P?= =?utf-8?q?JS+rkpaHuihRkQHHr0OXuDbOGi+vJwkFLJUcDWbH02XaHIY4cBLDrVz1SWPKf3QW/?= =?utf-8?q?9i6OocFTBfwPyfKtWPMYKLoa37Z2TZBmQoj2Tn4xxqnDYs6gcv1tvEvT/lZfdQgdt?= =?utf-8?q?v9sbE040VcppYPwDCIh+gXzOvxN4VnCepjw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(52116005)(7416005)(1800799015)(366007)(921011)(38350700005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?cwyObQj6krrWMAqwoSnC/E6ptz4T?= =?utf-8?q?4FCJn54OKqeIQYsl+KiewpVbOm8bCHKJhOGlRpnplMIP9HJE0y/Fn1yVCzqMy1amw?= =?utf-8?q?AIMtLZZvHwgoq9hBN+p+1b7TA2Yp8EMZryhQjJAjzQBZBcIorhqD7J3t+13HKpq/W?= =?utf-8?q?W24fGqFco+Ug83RE+IIbF6uXjHORbmzQOXS9lud1UWwx0GLGOGyFyNTCMr9WutQxr?= =?utf-8?q?MVGWKY6P1oxBTOi9ZqKPToBJ5axpIBbkrEnaRA0HERuGNWsJUCSPR/q9/LPCL90wh?= =?utf-8?q?KhkGn853KBSuxaeVGet2JAGf/Q+Yx7sHcLSNda0ZtrNc3Ui6NMYWjNAlwkeomUybI?= =?utf-8?q?wNNtob1da0QhARhSKt5vz8ThzPsewT2zZS3gdsoOvuFmc4PLi4Oz+vv1U4b+amhb2?= =?utf-8?q?W5DuZ/WxqKL6DAsZIvJRXgd/Ikyi06VwxLdUxPs6PLrzpFRtn34Yc82kDacgQwebx?= =?utf-8?q?sp5EkjrG0EMqmEM2bKISAU71sXREgGqbODqalwckF2m93F7mlfIevuelKuckRvdms?= =?utf-8?q?+qOf+SPMn7rK7F+vnTKZaWwMw3YPbmrY/p9lXKQuPoExy8ynDPRXrYh9+DQemSbBs?= =?utf-8?q?YjtQM9L4qPmHUWDTxBcWgQv1s4eEghKS4Pb101EbbjuLeyCH5uSu+QaX2hsWXdynN?= =?utf-8?q?px8oComjD++VSGFBM4xWp9a8BMj5zv99sJ6aGW0b+uwuK+f03MVIMHAk8YyBglBgn?= =?utf-8?q?vaQFkFUsF9k4kMvImvsYK2PE/dE+bi3wZ4xdDUC2h9bPE0qZxvDV9xzP0RiC/ZWZF?= =?utf-8?q?HTF1Bi5mU3DQ9c44pWhABmFfEwS5mf0W0BJRi7QoxMYXfYChwFjqhSTvgyFE/PSN6?= =?utf-8?q?ktTQvkA5Bc6ef62WXdgXEZkb9eIMd734i+ZtOtcN+tHBe0u9CQ2u0RALNE5C22CBl?= =?utf-8?q?FQGI6nz2+jcxGTUlcc3kHq8ifs8tfi/drFKRHzw9bZ79ig6IhCVBbfqc3zBh/rKeB?= =?utf-8?q?LyyNSDnQ5nm3LZDHeVxFRcUQFa4EFE1QwZngfneSp7o+LUiM9edMt3bd5WYhvqFKD?= =?utf-8?q?K1IuY+yesNWkWgD2eiGo4X+ke6/7jy5Biy7ZknvLLDwTgrekatbOSQ6OMl95Ck37U?= =?utf-8?q?yoLfz/fyaxToiGRBErmW6FxnaifztcO3q3PbUhC5CezIBY9IBukKoPZjZSk/AbRa5?= =?utf-8?q?3cjv/X/OvMrgDmymT85VDGIWhXcp+Krwttux0bx7hucUJr+J4HAxZnL+0JmOPk4hZ?= =?utf-8?q?plmuqnT7mZ3SCxIQdObqBK6F0BLk5Uy4OQBcn4cF9MP1QvqhX67mLAn3QMfcbcRZZ?= =?utf-8?q?CkGz9JgmcX5V2dDqPY4AhyDhfH560GMt3pAun2QStNKOQ5iMqmi76Yqa36YxW+xd4?= =?utf-8?q?vTha/qOTzhzoylVwoJnTJudeKBRjUX9rZgyW5amKs2pf8PZeASBu+7mpcmQA1eMSt?= =?utf-8?q?Vs+e4OprrIAxb28ovsRrfgB8RKH7sQDFYQt6+xnaxDCDKK0PHIfbER9wU7A/UQoWs?= =?utf-8?q?mDLJrDGJ31y1KuatdlpAS+0fuP8Xwoxt6IFWFQxNEwiTfnMeKeWzCAcY=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 67a2e174-b692-4404-ba16-08dc7f4df6f4 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2024 19:40:01.3175 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pbsX5tOYV2pupuol3g1juA6zmN6BU/9PjpSBXRewclZvjc34VTjRbdYDbITmDPRP0/egFmON8148tDQ9e6r3TQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8655 Improve comment about workaround ERR010727 by using official errata document content. Signed-off-by: Frank Li --- drivers/pci/controller/dwc/pci-imx6.c | 22 +++++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index 5e21fc942e90e..5533b7ad0f092 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -713,9 +713,25 @@ static int imx7d_pcie_core_reset(struct imx_pcie *imx_pcie, bool assert) return 0; /* - * Workaround for ERR010728, failure of PCI-e PLL VCO to - * oscillate, especially when cold. This turns off "Duty-cycle - * Corrector" and other mysterious undocumented things. + * Workaround for ERR010728 (IMX7DS_2N09P, Rev. 1.1, 4/2023): + * + * PCIe: PLL may fail to lock under corner conditions Initial VCO + * oscillation may fail under corner conditions such as cold + * temperature which will cause the PCIe PLL fail to lock in the + * initialization phase. + * + * The Duty-cycle Corrector calibration must be disabled. + * + * 1. De-assert the G_RST signal by clearing + * SRC_PCIEPHY_RCR[PCIEPHY_G_RST]. + * 2. De-assert DCC_FB_EN by writing data “0x29” to the register + * address 0x306d0014 (PCIE_PHY_CMN_REG4). + * 3. Assert RX_EQS, RX_EQ_SEL by writing data “0x48” to the register + * address 0x306d0090 (PCIE_PHY_CMN_REG24). + * 4. Assert ATT_MODE by writing data “0xbc” to the register + * address 0x306d0098 (PCIE_PHY_CMN_REG26). + * 5. De-assert the CMN_RST signal by clearing register bit + * SRC_PCIEPHY_RCR[PCIEPHY_BTN] */ if (likely(imx_pcie->phy_base)) {