| Message ID | 20240610-md-drivers-pci-v1-1-139c135853ea@quicinc.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3dadb4871578389c3c3bd6b081b1fe2af1dcdfe7 |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
| Series | PCI: add missing MODULE_DESCRIPTION() macros | expand |
On Mon, Jun 10, 2024 at 06:21:16PM -0700, Jeff Johnson wrote: > When ARCH=x86, make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pci/pci-stub.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pci/pci-pf-stub.o > > Add the missing invocations of the MODULE_DESCRIPTION() macro. > > Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> Applied to pci/misc for v6.11, with updates to the text: > --- > drivers/pci/pci-pf-stub.c | 1 + > drivers/pci/pci-stub.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/pci/pci-pf-stub.c b/drivers/pci/pci-pf-stub.c > index 45855a5e9fca..04815fcb0ce7 100644 > --- a/drivers/pci/pci-pf-stub.c > +++ b/drivers/pci/pci-pf-stub.c > @@ -39,4 +39,5 @@ static struct pci_driver pf_stub_driver = { > }; > module_pci_driver(pf_stub_driver); > > +MODULE_DESCRIPTION("Simple stub driver for PCI SR-IOV PF device"); +MODULE_DESCRIPTION("SR-IOV PF stub driver with no functionality"); > MODULE_LICENSE("GPL"); > diff --git a/drivers/pci/pci-stub.c b/drivers/pci/pci-stub.c > index d1f4c1ce7bd1..d4fec791b321 100644 > --- a/drivers/pci/pci-stub.c > +++ b/drivers/pci/pci-stub.c > @@ -92,5 +92,6 @@ static void __exit pci_stub_exit(void) > module_init(pci_stub_init); > module_exit(pci_stub_exit); > > +MODULE_DESCRIPTION("Simple stub driver to reserve a PCI device"); +MODULE_DESCRIPTION("VM device assignment stub driver"); > MODULE_LICENSE("GPL"); > MODULE_AUTHOR("Chris Wright <chrisw@sous-sol.org>"); > > --- > base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670 > change-id: 20240610-md-drivers-pci-831cb8f308a9 >
On 6/13/2024 3:20 PM, Bjorn Helgaas wrote: > On Mon, Jun 10, 2024 at 06:21:16PM -0700, Jeff Johnson wrote: >> When ARCH=x86, make allmodconfig && make W=1 C=1 reports: >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pci/pci-stub.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pci/pci-pf-stub.o >> >> Add the missing invocations of the MODULE_DESCRIPTION() macro. >> >> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> > > Applied to pci/misc for v6.11, with updates to the text: thanks for the cleanups! /jeff
diff --git a/drivers/pci/pci-pf-stub.c b/drivers/pci/pci-pf-stub.c index 45855a5e9fca..04815fcb0ce7 100644 --- a/drivers/pci/pci-pf-stub.c +++ b/drivers/pci/pci-pf-stub.c @@ -39,4 +39,5 @@ static struct pci_driver pf_stub_driver = { }; module_pci_driver(pf_stub_driver); +MODULE_DESCRIPTION("Simple stub driver for PCI SR-IOV PF device"); MODULE_LICENSE("GPL"); diff --git a/drivers/pci/pci-stub.c b/drivers/pci/pci-stub.c index d1f4c1ce7bd1..d4fec791b321 100644 --- a/drivers/pci/pci-stub.c +++ b/drivers/pci/pci-stub.c @@ -92,5 +92,6 @@ static void __exit pci_stub_exit(void) module_init(pci_stub_init); module_exit(pci_stub_exit); +MODULE_DESCRIPTION("Simple stub driver to reserve a PCI device"); MODULE_LICENSE("GPL"); MODULE_AUTHOR("Chris Wright <chrisw@sous-sol.org>");
When ARCH=x86, make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pci/pci-stub.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pci/pci-pf-stub.o Add the missing invocations of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> --- drivers/pci/pci-pf-stub.c | 1 + drivers/pci/pci-stub.c | 1 + 2 files changed, 2 insertions(+) --- base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670 change-id: 20240610-md-drivers-pci-831cb8f308a9