[v9,5/5] misc: pci_endpoint_test: Document a policy about adding pci_device_id

Commit Message

Yoshihiro Shimoda June 11, 2024, 12:50 p.m. UTC

Add a comment suggesting that if the endpoint controller Vendor and
Device ID are programmable, an existing entry might be usable for
testing without having to add an entry to pci_endpoint_test_tbl[].

Signed-off-by: Yoshihiro Shimoda <[e-mail]>
Reviewed-by: Manivannan Sadhasivam <[e-mail]>
Reviewed-by: Frank Li <[e-mail]>
---
 drivers/misc/pci_endpoint_test.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Krzysztof Wilczyński June 29, 2024, 7:43 p.m. UTC | #1

Hello,

> Add a comment suggesting that if the endpoint controller Vendor and
> Device ID are programmable, an existing entry might be usable for
> testing without having to add an entry to pci_endpoint_test_tbl[].

Applied to endpoint, thank you!

[1/1] misc: pci_endpoint_test: Document a policy about adding pci_device_id
      https://git.kernel.org/pci/pci/c/1947ff399bb7

	Krzysztof

Patch

diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c
index c38a6083f0a7..75ac447ffd34 100644
--- a/drivers/misc/pci_endpoint_test.c
+++ b/drivers/misc/pci_endpoint_test.c
@@ -980,6 +980,10 @@  static const struct pci_endpoint_test_data j721e_data = {
 	.irq_type = IRQ_TYPE_MSI,
 };
 
+/*
+ * If the controller's Vendor/Device ID are programmable, you may be able to
+ * use one of the existing entries for testing instead of adding a new one.
+ */
 static const struct pci_device_id pci_endpoint_test_tbl[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_DRA74x),
 	  .driver_data = (kernel_ulong_t)&default_data,