| Message ID | 20240701221612.2112668-1-Frank.Li@nxp.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Krzysztof Wilczyński |
| Headers | show |
| Series | [v3,1/1] dt-bindings: PCI: layerscape-pci: Fix property 'fsl,pcie-scfg' type | expand |
On Mon, Jul 1, 2024 at 4:16 PM Frank Li <Frank.Li@nxp.com> wrote: > > fsl,pcie-scfg actually need an argument when there are more than one PCIe > instances. Change it to phandle-array and use items to describe each field > means. > > Fix below warning. > > arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dtb: pcie@3400000: fsl,pcie-scfg:0: [22, 0] is too long > from schema $id: http://devicetree.org/schemas/pci/fsl,layerscape-pcie.yaml# > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > Change form v2 to v3 > - remove minItems because all dts use one argument. > Change from v1 to v2 > - update commit message. > --- > .../devicetree/bindings/pci/fsl,layerscape-pcie.yaml | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) Reviewed-by: Rob Herring <robh@kernel.org>
On Mon, Jul 01, 2024 at 06:16:12PM -0400, Frank Li wrote: > fsl,pcie-scfg actually need an argument when there are more than one PCIe > instances. Change it to phandle-array and use items to describe each field > means. > > Fix below warning. > > arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dtb: pcie@3400000: fsl,pcie-scfg:0: [22, 0] is too long > from schema $id: http://devicetree.org/schemas/pci/fsl,layerscape-pcie.yaml# > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- Bjorn and Krzysztof Wilczyński: Can you take care this patch? Rob already acked. Frank > Change form v2 to v3 > - remove minItems because all dts use one argument. > Change from v1 to v2 > - update commit message. > --- > .../devicetree/bindings/pci/fsl,layerscape-pcie.yaml | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml > index 793986c5af7ff..741b96defcc95 100644 > --- a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml > @@ -43,10 +43,15 @@ properties: > - const: config > > fsl,pcie-scfg: > - $ref: /schemas/types.yaml#/definitions/phandle > + $ref: /schemas/types.yaml#/definitions/phandle-array > description: A phandle to the SCFG device node. The second entry is the > physical PCIe controller index starting from '0'. This is used to get > SCFG PEXN registers. > + items: > + items: > + - description: A phandle to the SCFG device node > + - description: PCIe controller index starting from '0' > + maxItems: 1 > > big-endian: > $ref: /schemas/types.yaml#/definitions/flag > -- > 2.34.1 >
On Wed, Jul 03, 2024 at 11:27:21AM -0600, Rob Herring wrote: > On Mon, Jul 1, 2024 at 4:16 PM Frank Li <Frank.Li@nxp.com> wrote: > > > > fsl,pcie-scfg actually need an argument when there are more than one PCIe > > instances. Change it to phandle-array and use items to describe each field > > means. > > > > Fix below warning. > > > > arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dtb: pcie@3400000: fsl,pcie-scfg:0: [22, 0] is too long > > from schema $id: http://devicetree.org/schemas/pci/fsl,layerscape-pcie.yaml# > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > --- > > Change form v2 to v3 > > - remove minItems because all dts use one argument. > > Change from v1 to v2 > > - update commit message. > > --- > > .../devicetree/bindings/pci/fsl,layerscape-pcie.yaml | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > Reviewed-by: Rob Herring <robh@kernel.org> Krzysztof Wilczyński: can you help care about this patch, rob already acked. Frank
On Mon, 01 Jul 2024 18:16:12 -0400, Frank Li wrote: > fsl,pcie-scfg actually need an argument when there are more than one PCIe > instances. Change it to phandle-array and use items to describe each field > means. > > Fix below warning. > > arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dtb: pcie@3400000: fsl,pcie-scfg:0: [22, 0] is too long > from schema $id: http://devicetree.org/schemas/pci/fsl,layerscape-pcie.yaml# > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > Change form v2 to v3 > - remove minItems because all dts use one argument. > Change from v1 to v2 > - update commit message. > --- > .../devicetree/bindings/pci/fsl,layerscape-pcie.yaml | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > It's been 2 months and no response to multiple pings, so I applied it. Rob
Hello, > fsl,pcie-scfg actually need an argument when there are more than one PCIe > instances. Change it to phandle-array and use items to describe each field > means. > > Fix below warning. > > arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dtb: pcie@3400000: fsl,pcie-scfg:0: [22, 0] is too long > from schema $id: http://devicetree.org/schemas/pci/fsl,layerscape-pcie.yaml# Applied to dt-bindings, thank you! [1/1] dt-bindings: PCI: layerscape-pci: Change property 'fsl,pcie-scfg' type https://git.kernel.org/pci/pci/c/f66b63ef10d6 Krzysztof
On Mon, Aug 26, 2024 at 11:05:58AM -0500, Rob Herring (Arm) wrote: > > On Mon, 01 Jul 2024 18:16:12 -0400, Frank Li wrote: > > fsl,pcie-scfg actually need an argument when there are more than one PCIe > > instances. Change it to phandle-array and use items to describe each field > > means. > > > > Fix below warning. > > > > arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dtb: pcie@3400000: fsl,pcie-scfg:0: [22, 0] is too long > > from schema $id: http://devicetree.org/schemas/pci/fsl,layerscape-pcie.yaml# > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > --- > > Change form v2 to v3 > > - remove minItems because all dts use one argument. > > Change from v1 to v2 > > - update commit message. > > --- > > .../devicetree/bindings/pci/fsl,layerscape-pcie.yaml | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > It's been 2 months and no response to multiple pings, so I applied it. Krzysztof Wilczyński: Rob said he already picked this patch. I am not sure if cause conflict if you also picked. https://lore.kernel.org/linux-pci/20240904150338.GD3032973@rocinante/T/#t " Applied to dt-bindings, thank you! [1/1] dt-bindings: PCI: layerscape-pci: Change property 'fsl,pcie-scfg' type https://git.kernel.org/pci/pci/c/f66b63ef10d6 Krzysztof" Frank > > Rob
diff --git a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml index 793986c5af7ff..741b96defcc95 100644 --- a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml @@ -43,10 +43,15 @@ properties: - const: config fsl,pcie-scfg: - $ref: /schemas/types.yaml#/definitions/phandle + $ref: /schemas/types.yaml#/definitions/phandle-array description: A phandle to the SCFG device node. The second entry is the physical PCIe controller index starting from '0'. This is used to get SCFG PEXN registers. + items: + items: + - description: A phandle to the SCFG device node + - description: PCIe controller index starting from '0' + maxItems: 1 big-endian: $ref: /schemas/types.yaml#/definitions/flag
fsl,pcie-scfg actually need an argument when there are more than one PCIe instances. Change it to phandle-array and use items to describe each field means. Fix below warning. arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dtb: pcie@3400000: fsl,pcie-scfg:0: [22, 0] is too long from schema $id: http://devicetree.org/schemas/pci/fsl,layerscape-pcie.yaml# Signed-off-by: Frank Li <Frank.Li@nxp.com> --- Change form v2 to v3 - remove minItems because all dts use one argument. Change from v1 to v2 - update commit message. --- .../devicetree/bindings/pci/fsl,layerscape-pcie.yaml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)