From patchwork Tue Oct 1 08:34:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jian-Hong Pan X-Patchwork-Id: 13817642 X-Patchwork-Delegate: kw@linux.com Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 950B319ABDE for ; Tue, 1 Oct 2024 08:36:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727771781; cv=none; b=fUYOkBgiK57REiNsXrxFLdXNrcK9tJhO/AKofDNFP8XjCHTeE3UnZbemf8lj2wOCvSXDor55w8CqaaU/6Q1k2ZiG7pisUOV/oPCEzacaw8fFmPcS4wLectYur/bkIgrgEzhlyqrv0b7EBaYZwqvLzwvY6209Mgv/mhcEc5JX21o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727771781; c=relaxed/simple; bh=X762HUvHe79Sfszvlpr6AaCEObfNJ8XwLibj0VikeaA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Of2+Sdkq6s5M0CQqeYxvkDiyZjuz4a8Hc+oTeG0PJRPf52spCROoU18/ID2faTJ8nDIqd1vJHPrIFyXKyJwu9FqFbxxPHPbSt6jhMUvmWLj3PfcvlaeV1RMvmhWFrhex1QCO5e9ZTbvb8/aYtuJjojhV5kJWDnkAV8mA7lh4orI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=endlessos.org; spf=pass smtp.mailfrom=endlessos.org; dkim=pass (2048-bit key) header.d=endlessos.org header.i=@endlessos.org header.b=V3N4fUM+; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=endlessos.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=endlessos.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=endlessos.org header.i=@endlessos.org header.b="V3N4fUM+" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-7178df70f28so4112958b3a.2 for ; Tue, 01 Oct 2024 01:36:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=endlessos.org; s=google; t=1727771779; x=1728376579; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9imT704LRAGL7Jvi8rBCp96QNuC359qUawNx+2cRI5g=; b=V3N4fUM+jzchbc3zlZM9EluBS4pOABr07F1u+GBSOZkqin3P8yVF1GDZMNusbKOdEi Hgvr7oSDYd1Ujw1c/kSin6tWYdTa8SJEZzlIhsmUT4NH8shCD8S1ndojm87oSuEmE5Bb TV3OKupMa6+XibwSOmJzqQYRRYkCP2fHFmMhNmElO1f9u4vuO8bXPfrybgytdlM1IES9 6N9yJqja1LCdmkbPv1UdPEtUTRx5llBaBz9hm4A7rE366FKRSvZxz/s/nCg1PCp7v5Wj gn9zhqpQQbyXbBUiWyTwbhTR0bc0d4cM9AJE3s5q9NZiEHk3xp3F0kfE0XMsOZEZjWQg ux6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727771779; x=1728376579; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9imT704LRAGL7Jvi8rBCp96QNuC359qUawNx+2cRI5g=; b=S+D7cpUZZRr7nFcuShLin3x603NyLXdCMNS9HKbAj52JGlLray5ePFa4fO5kGlY0zN C5mTS3v+nBZiiGlaNDMQAvZW9oIBwR2VC55ZahKTwWNQRBGhDtZiVFbX3Slb1eTsS3GO YQs3ulocPuxt+i2KA6e3BocKBZLC3H4a3+hFNKhHfvNr5nJLmVcUfe/y0LWhU9m/Egf6 VBUOfoPnyyi7BGM/Ha3d7hANYOEA8ywpbWvqi+giMqj1N5q5XF4rU9JghST9T0+kKdvk qfVC0ue+3M2y1b9UCwMi4Gev4rDnNNUEo2lS8RnPMAPQ5vz2ibhVNkvPyqswkAb7qwYy 4A0w== X-Forwarded-Encrypted: i=1; AJvYcCWHvTvFHKy4TSjpUwlDnEFqCgvY+ogNhw3+u0MI1VGHGTqENZsb9l47/TcjcoouhPgRzAlpexvK5wg=@vger.kernel.org X-Gm-Message-State: AOJu0YzI6fftRS37zih49jBdORbxpclXNgLQcuqMEcu1N+j+6n10bmPU XfXEKRRZNPpatBDKCQf4R9hQ2fBqsTdbGsYOAB1CJiedaESryG9CZMH4b5dzsDg= X-Google-Smtp-Source: AGHT+IGTYZspzAErDSrmscoQdRmq6XKHRbgb09e/7smZlcCyPbeS3xskua8DxYNdwUkvMDs21Dj2bw== X-Received: by 2002:a05:6a00:39a2:b0:717:8d5d:94d6 with SMTP id d2e1a72fcca58-71b25f4416cmr23558820b3a.12.1727771778836; Tue, 01 Oct 2024 01:36:18 -0700 (PDT) Received: from localhost.localdomain ([123.51.167.56]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-71b26516148sm7521573b3a.110.2024.10.01.01.36.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2024 01:36:18 -0700 (PDT) From: Jian-Hong Pan To: Bjorn Helgaas Cc: Johan Hovold , David Box , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Kuppuswamy Sathyanarayanan , Nirmal Patel , Jonathan Derrick , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux@endlessos.org, Jian-Hong Pan , Bjorn Helgaas Subject: [PATCH v12 2/3] PCI/ASPM: Add notes about enabling PCI-PM L1SS to pci_enable_link_state(_locked) Date: Tue, 1 Oct 2024 16:34:40 +0800 Message-ID: <20241001083438.10070-6-jhp@endlessos.org> X-Mailer: git-send-email 2.46.2 In-Reply-To: <20241001083438.10070-2-jhp@endlessos.org> References: <20241001083438.10070-2-jhp@endlessos.org> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 According to "PCIe r6.0, sec 5.5.4", add note about D0 requirement in pci_enable_link_state() kernel-doc. Signed-off-by: Jian-Hong Pan Acked-by: Bjorn Helgaas Reviewed-by: Kuppuswamy Sathyanarayanan --- v3: - Fix as readable comments v4: - The same v5: - Tweak and simplify the commit message v6~12: - The same drivers/pci/pcie/aspm.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c index cee2365e54b8..bd0a8a05647e 100644 --- a/drivers/pci/pcie/aspm.c +++ b/drivers/pci/pcie/aspm.c @@ -1442,6 +1442,9 @@ static int __pci_enable_link_state(struct pci_dev *pdev, int state, bool locked) * touch the LNKCTL register. Also note that this does not enable states * disabled by pci_disable_link_state(). Return 0 or a negative errno. * + * Note: Ensure devices are in D0 before enabling PCI-PM L1 PM Substates, per + * PCIe r6.0, sec 5.5.4. + * * @pdev: PCI device * @state: Mask of ASPM link states to enable */ @@ -1458,6 +1461,9 @@ EXPORT_SYMBOL(pci_enable_link_state); * can't touch the LNKCTL register. Also note that this does not enable states * disabled by pci_disable_link_state(). Return 0 or a negative errno. * + * Note: Ensure devices are in D0 before enabling PCI-PM L1 PM Substates, per + * PCIe r6.0, sec 5.5.4. + * * @pdev: PCI device * @state: Mask of ASPM link states to enable *