| Message ID | 20241111203624.1817328-1-helgaas@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Krzysztof Wilczyński |
| Headers | show |
| Series | PCI: Drop duplicate pcie_get_speed_cap(), pcie_get_width_cap() declarations | expand |
[Public] > -----Original Message----- > From: Bjorn Helgaas <helgaas@kernel.org> > Sent: Monday, November 11, 2024 3:36 PM > To: linux-pci@vger.kernel.org > Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Tal Gilboa > <talgi@mellanox.com>; Bjorn Helgaas <bhelgaas@google.com> > Subject: [PATCH] PCI: Drop duplicate pcie_get_speed_cap(), pcie_get_width_cap() > declarations > > From: Bjorn Helgaas <bhelgaas@google.com> > > 6cf57be0f78e ("PCI: Add pcie_get_speed_cap() to find max supported link > speed") and c70b65fb7f12 ("PCI: Add pcie_get_width_cap() to find max supported > link width") added declarations to drivers/pci/pci.h. > > 576c7218a154 ("PCI: Export pcie_get_speed_cap and pcie_get_width_cap") > subsequently added duplicates to include/linux/pci.h. > > Remove the originals from drivers/pci/pci.h. Both interfaces are used by amdgpu, > so they must be in include/linux/pci.h. > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Acked-by: Alex Deucher <alexander.deucher@amd.com> > --- > drivers/pci/pci.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h index 7573f81f58c4..1d5c519e19b1 > 100644 > --- a/drivers/pci/pci.h > +++ b/drivers/pci/pci.h > @@ -395,8 +395,6 @@ static inline int pcie_dev_speed_mbps(enum > pci_bus_speed speed) > > u8 pcie_get_supported_speeds(struct pci_dev *dev); const char > *pci_speed_string(enum pci_bus_speed speed); -enum pci_bus_speed > pcie_get_speed_cap(struct pci_dev *dev); -enum pcie_link_width > pcie_get_width_cap(struct pci_dev *dev); void __pcie_print_link_status(struct > pci_dev *dev, bool verbose); void pcie_report_downtraining(struct pci_dev *dev); > > -- > 2.34.1
Hello, > 6cf57be0f78e ("PCI: Add pcie_get_speed_cap() to find max supported link > speed") and c70b65fb7f12 ("PCI: Add pcie_get_width_cap() to find max > supported link width") added declarations to drivers/pci/pci.h. > > 576c7218a154 ("PCI: Export pcie_get_speed_cap and pcie_get_width_cap") > subsequently added duplicates to include/linux/pci.h. > > Remove the originals from drivers/pci/pci.h. Both interfaces are used by > amdgpu, so they must be in include/linux/pci.h. Acked-by: Krzysztof Wilczyński <kw@linux.com> Thank you for the clean-up! Krzysztof
diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h index 7573f81f58c4..1d5c519e19b1 100644 --- a/drivers/pci/pci.h +++ b/drivers/pci/pci.h @@ -395,8 +395,6 @@ static inline int pcie_dev_speed_mbps(enum pci_bus_speed speed) u8 pcie_get_supported_speeds(struct pci_dev *dev); const char *pci_speed_string(enum pci_bus_speed speed); -enum pci_bus_speed pcie_get_speed_cap(struct pci_dev *dev); -enum pcie_link_width pcie_get_width_cap(struct pci_dev *dev); void __pcie_print_link_status(struct pci_dev *dev, bool verbose); void pcie_report_downtraining(struct pci_dev *dev);