From patchwork Tue Nov 26 07:56:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Zhu X-Patchwork-Id: 13885543 Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11013041.outbound.protection.outlook.com [40.107.162.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAF131AF4EE; Tue, 26 Nov 2024 07:58:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.162.41 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732607896; cv=fail; b=eWuBmHZL8SZK98ZIWM6hvEab7h32KaxsPn6MnPOBt/lJrKrBp/nHH/MuQuOWbDc6AaTPqfz5GoZTbbHrYGQGQlQK0O5r5BMtjjMYYKb4ZtZFlBhs3cfWsWIPEonWo7up2jQbQdH7qGT6RKhCMy1uPQe24oKVvfKFpSFNyDmK2nQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732607896; c=relaxed/simple; bh=b6p7bctUqbrBwEYJnwNFTABSq8TtcXK6Z3nJ5qL/pJs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=mWmnPMV+cuaXKh0MgcFyQ4Fv+0jy2VGVbsYBUyxViAEvtZPh6abGFHNDkF+tEasJLACxtfAYRF6z8n68RjdWx9C97IzWhb2fnFrqAKAxKUDwYOKvC4RcAT0YQN3WzCavmJ+GWqpto+VXF4ntEWSeo3owKFgkTaydABej0d2oEB8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=B/OVxgxI; arc=fail smtp.client-ip=40.107.162.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="B/OVxgxI" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=N9M/ic3DiUosb3LIJuxT7C2S3DgU+SSTbgEGiSGox3fzOgz4aGY5/pjf/HcdN5dwQfVFazBZPBYwx73EsmKFceERuaS9SB0ClBz+y48WqEg6FxEmaVCE7F9V/fDQY8NzdMZq4UpqbghdyG6GqoJnbLegqlA4r8jqVqSGssSthn2HElnXlRLx50eI+XEIHFh+u+fzzmtWcI096PtpRBHS+lrRwmqfxzZoVMcRyvBUu3kCsHHg02uFiVBIIcjRz0urmTcF/v2Jou/bz5qdwWVAblt2HTqDfCR5WqNyChwOMtRgi6vuda+W9yUjJ7jAQ8kVUN0tMfmnV4UVvLzBaxpr2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CxI4VLAgO8GCMamGaj7SYQwMPhK96gaRu9Y/7KCJ42E=; b=f3sV3BwCT+YgDA8EySUXbPDojhYKd/6mQMZWiE1TnXazre+5QG2+BaQMMbx06WsYDZgUw3AbHh5RhA6Id6YWoptRGwySCPjqoBNw1LngbPwbctWiazf3uD6otEgblrOWcvoqEbF9DLFpQE2kBxf1nXBpKijGt46iOXwueQLbW0zVD521nPIg0ZL6fHZiTel8cO1ZxIdMAULLpulVRU3A9Wk9wzk73NADPz5sKsBnL1M5pZHPvFdiqOWweuOcYZVhxAzkcGY1lvuPDMl2zfTHoKKpMeNJ3NNSphKzK005ESOv3dcZ0OAkKHofeZqQa1MDPgjd7M0pVpBHnBXQtnOLcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CxI4VLAgO8GCMamGaj7SYQwMPhK96gaRu9Y/7KCJ42E=; b=B/OVxgxIrjwNIF2rBhgdORDUNJvK5PU7mbD3kYSuXyiNdDiu0/7BL6+7wwCrOBWANdoyi0W8j7a7/Gw4noqSNeAP3V926/ZXJDXTK/JRqOYc5XR6+tn69Rl1rmoniH9TWbEIroqDCIsVeDvkEuSKzpTCP1q3fx2VQDHHap7tqiEA3Ijxip6tWscWHcikYqn76cjKy5xfHVq/0szUrX/MrIU33YGdYq+y+PDbvtOA0szLqAw4ef0YHMs1W6vlpJTboPYbA8tYnx00fwN1NJ1htyjj11++Elb8um4yfi0GsRm31PeyaU175DLwt1x8iO0ZpUd2IzgdE77/dKrVZ84oBg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8676.eurprd04.prod.outlook.com (2603:10a6:20b:42b::10) by PAXPR04MB8489.eurprd04.prod.outlook.com (2603:10a6:102:1dd::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8182.20; Tue, 26 Nov 2024 07:58:11 +0000 Received: from AS8PR04MB8676.eurprd04.prod.outlook.com ([fe80::28b2:de72:ad25:5d93]) by AS8PR04MB8676.eurprd04.prod.outlook.com ([fe80::28b2:de72:ad25:5d93%4]) with mapi id 15.20.8182.019; Tue, 26 Nov 2024 07:58:11 +0000 From: Richard Zhu To: l.stach@pengutronix.de, bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com, manivannan.sadhasivam@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, frank.li@nxp.com, s.hauer@pengutronix.de, festevam@gmail.com Cc: imx@lists.linux.dev, kernel@pengutronix.de, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Richard Zhu , Frank Li Subject: [PATCH v7 05/10] PCI: imx6: Deassert apps_reset in imx_pcie_deassert_core_reset() Date: Tue, 26 Nov 2024 15:56:57 +0800 Message-Id: <20241126075702.4099164-6-hongxing.zhu@nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20241126075702.4099164-1-hongxing.zhu@nxp.com> References: <20241126075702.4099164-1-hongxing.zhu@nxp.com> X-ClientProxiedBy: SI1PR02CA0060.apcprd02.prod.outlook.com (2603:1096:4:1f5::17) To AS8PR04MB8676.eurprd04.prod.outlook.com (2603:10a6:20b:42b::10) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8676:EE_|PAXPR04MB8489:EE_ X-MS-Office365-Filtering-Correlation-Id: 5b550961-c669-4ac9-923d-08dd0df012a9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|7416014|376014|1800799024|366016|38350700014|921020; X-Microsoft-Antispam-Message-Info: XDHjEt3T/XhZvdR9x7xa3xtG3+mtWRuaVDN3diq6bqcV0r7v2yTzs4TbFWFrRDxpx/ImmZUFnT3f/ZctjjlqsnaNO/rpuW0nRM2NW521dh4eAWa88Xhg4NoY/6iPEwEmHOKx8fkracTEkESL9OP2pFSPtZqhFZzvuL4QB8y3PS2I/Tct8ptMjf5+rrvmb7ZjoF5xntCETh72px0MWbA54QbLBKiBlTEUSQJ0TlgXLLxu9SEl6QthBNbG/DdlsL9SN4yfVRQapeUpuR2STz1h/iH4GErfIcw5wwXopd32OF/hO9c3k+gV0nBeS1X8McIDrtI/Q4xywBjGfjiUcIK7OmEkz3ZUcjlCOp49oZRllEYShmVjWgf28gpReZkY6gT4/CbwRhsqAPHM0rL17w7eTaE8sFWCj+3+SUKzhyZRrCJS1YL+zTazR8xJ+1zk7IZ5Su2/M4vOWfaxkxISwWGZFrZJ5Xx5yu6eyF9ap7ZAKLkjkH3USviEVj2nnuK/o1tTz5qHtLmTqHpRRXOgveGOrunFIZfDm0WcmJ/EQW37GsUWbc1bkuADPPhf7tAE+9pcnZO1P7pF7DpRHpEbYHs6KPQw/uSorIpVHVTqtLAL9dLhqazxBqVOzmoYuNNFiZJRkXU2UWm45gPOuxpF7aqNfEDp19yKjFGA2tk3H56zh5sNrD8VT+uDe59wG3c0Rb8oPuzQG1mHUK396lWLzF4H7isiwzUKPpYRW1C5GwIv3c4UI3nlRXeCHFlFecNWieAJWR8Wwo0tC77cZL+7Km6ZNASKbACHSH0QHDCnTKFtXSZPNelsdFs6FiyjKedmd19v8rkuO4Q18CcKMondv914bmiuK8gENyNirQy599t6OHz1DQaKK+6AVFc0nMaRlSseFf8MWKmyugEqENpgLffHQzys5oDPSD4gHdL0kimsz74ySWE0IO93gfxem/8yeUXGPhKT1GAFotauQZV7m2qqNH8i1YOD59VrSg/uS+Sr7LLbiJRhgy2y75xKMjEiFHCVjs2RO9TWXy2K64g2X5vBBEgs07HFeI3SAzVwJRkV6KvFKWBTJfA7u3weoBZ2vVtbRvVx26lQl4xTsWht2MTUAT2Ip6S13zUGsXZoyq965NGJmZaicYje/Fg48IHJ8/IlcJ36wi5q8W9Yd1cYmgqQcaUlotXofQc8zTWYfz7jmJPAo2JxfA4T0FhRQ7d3jcx9miZi6gg2CKAO3o+ctU29hRuy4gxwNVajZena4YoORco0t6PlBXWE8wAhN3lanY9T5cXFF1YTKXzwptUbgx+D2d3WuYug8RyrJ3zJTSevx8zEH9t/KKi3OJA9VRBZ/SruHF0Qxdbjal5OOZbhHvjApyJtwKYcA01aPymqbRtotvJTwzuB8ZRZvFkdwqvAjegL4oiBSBDah9E9puiDlR/Ow9SFWevu0vmb+AlHEaOAmhQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8676.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(7416014)(376014)(1800799024)(366016)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: adLTZHBlYNMjIUuQCbWR4vzh/EP8Lg/wiD/RQCIs2V7nkX0iH0cFtV6qnfreFdi/I4dZplDzHMpV5LCGesijI+/GVAeiNvFakAKMUffCiNLDcCHraJXT+QnOSGnq5FXsd5djx6zYkHrge7bwfKU50UXkOLS64riwAC3Dv5HTJTSi0VnCVJZI+Gla7JB8RwxHtEIJRQyV3851WuUvJ2rx2j9Yb9hCERnMeiiboHjblOe4u/X/6MaNQWPXPHGjuh6u/rjsffL8pkrX3et4aIQwo3kA8KwgKFtdDU2UTWuRakde0xyrwRrs5HAYcaEEvRiXOTFSAHjkezIB6UWrf4JyjmNdhHi73Z/ZnTmJYwfBnbNsJVylq/HkcyYK11aYTwos5Fy9e1Qd1c+c7vfnpUthTctu592gYmS2PJLYXvlss+ock6idw/6IHf9vr2IckjLlwfzUiHK+Ljyqx65sPImJFih4182oCtYRQtaqATQ4NegJYzlCd3n0z7F1Bfn69KY0vLRivsFUOGnvf7J29trGNGWSdY1Vr5FoS+yS8bymSV22urD/5a292btnQ4BSli+EuKRnQMFIqbMDjIqE306+CElXJmst0rB70skNOGdpyFhX0Qst4Ga2z52cD7tIqxvgSiPPz4BOkVqTjfSHvpmLVrr/aRPPHlZflQhmh6KeqeLqQ9KVkN9WANvo05bffPj+Q+raTrOCRZ8qEyljKD92Ckkf1ZwA4GbjQryI1KLml8iRSqPIg1WgTmHdYHwg7QqLlNHw7HIQoBjPqxUMcKaWe+N3wUSll1eZV6/0CHXbUru0M22dttBn3+5hrfv8aO/0/T/iauLduV4pHNsgxK8VQ0368gBWMk8R31vOASzOUCoeEUmBX6hBmBdDfCN0gATk/DOzJ+5XFzlcHdJaOB0UkenHS/BPNCHFNSb+7Rs9tcLx1wm61aTdl+flScYLl8fffLJGztJ3Gpa7/RYAqciJXilsV5S92r1yzZQ4Pi3P1f1Fd3eNwWfTwvAz6AA0j2Zz+uT9ntxb8nCmjC1unjjrmk33r2/tKNCmaKVu2YZscfJKKG++tjLYjdhDWSkbgikgls4HrMTIEqkddPEtMcY8k2k31wV0lacR5Df9XSDjMbBBqGNbWkOL4gKRFr9SZPirtm+G9RMASed+cZCwFbhcT3zR6QRPs4aku7ZTx7tVUQoyfQzmgWXjWXJu5J4Zu2R4/ePxMypLm2Lk8JCmwOSFNfJxdRXC1fRJ7M4qKAfjMGc0nld04qZuk8MZSYbpewrX0j3YtWYFX+WU+8ihN76PQzN0Tb38eI3jCn2UuaoMBGxLOwcIalvrJSg5lDLmlKeDAnR7ZtV7/PbPv8tUfhDKnw6z3zFm7UYnucO9Eko+1br/nP7vWVzXXoj89XlyNME6ObnmxIrDkTbKptwA0B7otnBN620vQT69XXPJAam7m/4mk3x3sJYTO1WsUXrhtu5M1ihazx/NFVsH9B774ln72ECSF5R3GztxY5BlkFaNf4Tw5SuQ/5XQirdr481jMSMKvZR8/faLllsP7MTgACmxzG4d/79eL4q+gfFc6FNcZqr6J8xPHbcB7+6hAUIAuyAH X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b550961-c669-4ac9-923d-08dd0df012a9 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8676.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Nov 2024 07:58:11.6370 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JGC6B4VeL4ZqWlSGcnGQSEwzqv8aOmlFD8uToYZWgq+ZU3OqExUFEMSlDgkxtIayo4AecdRVVcMc1V8GvSdR+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8489 Since the apps_reset is asserted in imx_pcie_assert_core_reset(), it should be deasserted in imx_pcie_deassert_core_reset(). Fixes: 9b3fe6796d7c ("PCI: imx6: Add code to support i.MX7D") Signed-off-by: Richard Zhu Reviewed-by: Manivannan Sadhasivam Reviewed-by: Frank Li --- drivers/pci/controller/dwc/pci-imx6.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index 3538440601a7..413db182ce9f 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -776,6 +776,7 @@ static void imx_pcie_assert_core_reset(struct imx_pcie *imx_pcie) static int imx_pcie_deassert_core_reset(struct imx_pcie *imx_pcie) { reset_control_deassert(imx_pcie->pciephy_reset); + reset_control_deassert(imx_pcie->apps_reset); if (imx_pcie->drvdata->core_reset) imx_pcie->drvdata->core_reset(imx_pcie, false);