@@ -270,16 +270,15 @@ static __init int gicv2m_allocate_domains(struct irq_domain *parent)
if (!v2m)
return 0;
- inner_domain = irq_domain_create_hierarchy(parent, 0, 0, v2m->fwnode,
- &gicv2m_domain_ops, v2m);
+ inner_domain = msi_create_parent_irq_domain(v2m->fwnode,
+ &gicv2m_msi_parent_ops,
+ &gicv2m_domain_ops,
+ 0, 0, v2m, parent);
if (!inner_domain) {
pr_err("Failed to create GICv2m domain\n");
return -ENOMEM;
}
- irq_domain_update_bus_token(inner_domain, DOMAIN_BUS_NEXUS);
- inner_domain->flags |= IRQ_DOMAIN_FLAG_MSI_PARENT;
- inner_domain->msi_parent_ops = &gicv2m_msi_parent_ops;
return 0;
}
@@ -5114,20 +5114,16 @@ static int its_init_domain(struct its_node *its)
info->ops = &its_msi_domain_ops;
info->data = its;
- inner_domain = irq_domain_create_hierarchy(its_parent,
- its->msi_domain_flags, 0,
- its->fwnode_handle, &its_domain_ops,
- info);
+ inner_domain = msi_create_parent_irq_domain(its->fwnode_handle,
+ &gic_v3_its_msi_parent_ops,
+ &its_domain_ops,
+ its->msi_domain_flags, 0,
+ info, its_parent);
if (!inner_domain) {
kfree(info);
return -ENOMEM;
}
- irq_domain_update_bus_token(inner_domain, DOMAIN_BUS_NEXUS);
-
- inner_domain->msi_parent_ops = &gic_v3_its_msi_parent_ops;
- inner_domain->flags |= IRQ_DOMAIN_FLAG_MSI_PARENT;
-
return 0;
}
@@ -211,14 +211,13 @@ static int mbi_allocate_domain(struct irq_domain *parent)
{
struct irq_domain *nexus_domain;
- nexus_domain = irq_domain_create_hierarchy(parent, 0, 0, parent->fwnode,
- &mbi_domain_ops, NULL);
+ nexus_domain = msi_create_parent_irq_domain(parent->fwnode,
+ &gic_v3_mbi_msi_parent_ops,
+ &mbi_domain_ops,
+ 0, 0, NULL, parent);
if (!nexus_domain)
return -ENOMEM;
- irq_domain_update_bus_token(nexus_domain, DOMAIN_BUS_NEXUS);
- nexus_domain->flags |= IRQ_DOMAIN_FLAG_MSI_PARENT;
- nexus_domain->msi_parent_ops = &gic_v3_mbi_msi_parent_ops;
return 0;
}
Now that we have a concise helper to create an MSI parent domain, switch the GIC family over to that. Signed-off-by: Marc Zyngier <maz@kernel.org> --- drivers/irqchip/irq-gic-v2m.c | 9 ++++----- drivers/irqchip/irq-gic-v3-its.c | 14 +++++--------- drivers/irqchip/irq-gic-v3-mbi.c | 9 ++++----- 3 files changed, 13 insertions(+), 19 deletions(-)