| Message ID | 20241220101551.3505917-3-kever.yang@rock-chips.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Krzysztof Wilczyński |
| Headers | show |
| Series | Rockchip: add Rockchip rk3576 EVB1 board | expand |
On Fri, 20 Dec 2024 18:15:46 +0800, Kever Yang wrote: > rk3576 is using dwc controller, but use msi interrupt instead of its, > so the msi-map is not required, and need to add a new 'msi' interrupt name. > > Signed-off-by: Kever Yang <kever.yang@rock-chips.com> > --- > > Changes in v2: > - remove required 'msi-map' > - add interrupt name 'msi' > > .../devicetree/bindings/pci/rockchip-dw-pcie-common.yaml | 1 + > Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml | 4 +--- > 2 files changed, 2 insertions(+), 3 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-ep.example.dtb: pcie-ep@fe150000: interrupt-names:5: 'msi' was expected from schema $id: http://devicetree.org/schemas/pci/rockchip-dw-pcie-ep.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-ep.example.dtb: pcie-ep@fe150000: interrupt-names:6: 'dma0' was expected from schema $id: http://devicetree.org/schemas/pci/rockchip-dw-pcie-ep.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-ep.example.dtb: pcie-ep@fe150000: interrupt-names:7: 'dma1' was expected from schema $id: http://devicetree.org/schemas/pci/rockchip-dw-pcie-ep.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-ep.example.dtb: pcie-ep@fe150000: interrupt-names:8: 'dma2' was expected from schema $id: http://devicetree.org/schemas/pci/rockchip-dw-pcie-ep.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-ep.example.dtb: pcie-ep@fe150000: Unevaluated properties are not allowed ('power-domains' was unexpected) from schema $id: http://devicetree.org/schemas/pci/rockchip-dw-pcie-ep.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241220101551.3505917-3-kever.yang@rock-chips.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Fri, Dec 20, 2024 at 06:15:46PM +0800, Kever Yang wrote: > rk3576 is using dwc controller, but use msi interrupt instead of its, > so the msi-map is not required, and need to add a new 'msi' interrupt name. > > Signed-off-by: Kever Yang <kever.yang@rock-chips.com> > --- > > Changes in v2: > - remove required 'msi-map' > - add interrupt name 'msi' > > .../devicetree/bindings/pci/rockchip-dw-pcie-common.yaml | 1 + > Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml | 4 +--- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml > index cc9adfc7611c..e5e1a2c7ae05 100644 > --- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml > +++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml > @@ -81,6 +81,7 @@ properties: > - const: msg > - const: legacy > - const: err > + - const: msi ABI break without clear reasons. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml index cc9adfc7611c..e5e1a2c7ae05 100644 --- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml +++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml @@ -81,6 +81,7 @@ properties: - const: msg - const: legacy - const: err + - const: msi - const: dma0 - const: dma1 - const: dma2 diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml index 550d8a684af3..9a464731fa4a 100644 --- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml @@ -26,6 +26,7 @@ properties: - const: rockchip,rk3568-pcie - items: - enum: + - rockchip,rk3576-pcie - rockchip,rk3588-pcie - const: rockchip,rk3568-pcie @@ -71,9 +72,6 @@ properties: vpcie3v3-supply: true -required: - - msi-map - unevaluatedProperties: false examples:
rk3576 is using dwc controller, but use msi interrupt instead of its, so the msi-map is not required, and need to add a new 'msi' interrupt name. Signed-off-by: Kever Yang <kever.yang@rock-chips.com> --- Changes in v2: - remove required 'msi-map' - add interrupt name 'msi' .../devicetree/bindings/pci/rockchip-dw-pcie-common.yaml | 1 + Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml | 4 +--- 2 files changed, 2 insertions(+), 3 deletions(-)